80 replies to this topic

[littlesat]

Strange.... here no disalignment...??? I asked you to put the SRT here.

[littlesat]

I suspect the srt you have is not anymore in the correct format... it is converted in linux format...

[TheMystery]

I have tested it with an mkv with embedded subtitles witch i can choose, so i don't use srt files
Maybe that the format is then different.

[littlesat]

I indeed kan confirm it.... but the next questions is why it does rendering it like this when a color change code is at the end of a line...?

[littlesat]

I'm scared it is something when the last character is a color change at a end of a line (font.cpp)

case 'c':
				    {
					   char color[8];
					   int codeidx;
					   for (codeidx = 0; codeidx < 8; codeidx++)
					   {
						  if ((i + 2 + codeidx) == uc_visual.end()) break;
						  color[codeidx] = (char)((*(i + 2 + codeidx)) & 0xff);
					   }
					   if (codeidx == 8)
					   {
						  pGlyph ng;
						  ng.newcolor = gRGB(color).argb();
						  ng.flags = GS_COLORCHANGE;
						  ng.w = 0;
						  glyphs.push_back(ng);
						  i += 1 + codeidx;
						  continue;
					   }
					   break;
				    }

[littlesat]

pieterg,

Please help. Something is incorrect here when the color escape string is at the end of a row.

[ims]

@littlesat: trying:

text = replace_all(text, "<i>", (std::string) gRGB(0,255,255));
text = replace_all(text, "<b>", (std::string) gRGB(255,255,0));
text = replace_all(text, "</i>", "");
text = replace_all(text, "</b>", "");

=> is not color on the end . And it is same:

COLORED1
			COLORED2

It is in case:

7
00:00:33,067 --> 00:00:35,456
<i>-Baldricku!</i>
<b>Ano, pane.</b>

There is on end of first line

<br />

[littlesat]

I also discovered this in between.... something strange is going on here. I also replaced the color back to white string by e.g. 1234567890 and with the same results....? Strange why it is not renedering to the begin of the next line. I cannot find the reason yet. I still suggest we need a fix in font.cpp

Strange thing was that I tested with e.g.

3
00:01:00,503 --> 00:01:03,965
Ik <b>heb</b> gewonnen.
- Geef die tak aan mij.

which was rendered fine...

[ims]

but if i displaying it with <i>.....</i> (without replacement chars) and have set for all subs yellow color (text = (std::string) gRGB(255,255,0) + text;), then are both texts true centered (of course, with <i> )

I think, there works bad centering, if is changed colors.

Problem making this variant only:

line1
<>line2</>

<>line1</>
<>line2</>

[littlesat]

I do not have the idea it is bad centering, but render the next line it goes not back to the begin position or so and render the both lines as one line???

[ims]

in both cases are both line bad centered. 1st is more left, second is more right. Line break is made well ( text arent in same line).

[littlesat]

I think it is related to the linebreak. Ik goes to the next line and when you teke the complete thing as it was one line then the centering is OK.

[ims]

there is 0x0d 0x0a ("\n") between line. May be, replace it with <> ?

[littlesat]

What do you mean by replacing it with <>? Normally 0x0d 0x0a is working fine.

[ims]

ok. but in this case \n+color make problems...

It is stupid, but it helps:

text = replace_all(text, "<i>", " " + (std::string) gRGB(0,255,255));
text = replace_all(text, "<b>", " " + (std::string) gRGB(255,255,0));

Space before color info... :-)

[littlesat]

Indeed... it happens when the color change in the begin of the line second (or third etc...) line.

Now I understand what happens here... the color change just works a round as it is a not printable character and if it is the first line it does not see the first char in line flag.

Nextflags was copied to flags and made zero after the copy and then color escape code is renedered. So the nextline flag is never seen again - I have to set a nextflags = flags before the continue in the code above in font.cpp.

Later today I'll fix it... (Kids are watching TV).

Thanks ims for thinking with me.... it was a brainbraker for me the whole morning as I was looking after the color change. At the end in esubtitle.cpp we do not have to change anything.

[littlesat]

FYI: http://openpli.git.s...0cdb0f13a55af2a

[ims]

Works well

[littlesat]

Thanks for help ims...

Now the start of the srt subtitles.... I have the idea the second and afterwards it starts with the third subtitle. The first two are skipped due to the push/pull mechanism which is very tricky in servicemp3.cpp

[ims]

Thanks for help ims...

Now the start of the srt subtitles.... I have the idea the second and afterwards it starts with the third subtitle. The first two are skipped due to the push/pull mechanism which is very tricky in servicemp3.cpp

And what in this case adding into buffer with .srt subs at first permanently 2 subtitle lines with space on position 00:00:00,000 and 00:00:00:010 ? => all subs could be displayed ... Ugly ?