1748 replies to this topic

[Erik Slagter]

Mostly in Python but also in the C++ code, in enigma2 the "de facto standard" has always been to use tabs as delimiters. Sometimes "space" die-hards added patches that introduced spaces, but most of these we already converted to "the right thing". If there are still places where tabs and spaces are mixed (evil!) they are only a handful and we need to clean them up too.

 

I don't care whether the whole world is misguided and does not understand the meaning of a delimiter in a computer program and really that it does not matter whether it indents 4 of 8 positions and really that you can set the tab width in your favourite editor yourself! And apparently most of the enigma2 developers agreed with me.

 

EDIT: this is the one and only occasion where Schimmelreiter and I agree.

Edited by Erik Slagter, 29 April 2020 - 19:10.

[Dimitrij]

Mixing (one file spaces, other tabs) I don't really prefer. Maybe only if we want to move slowly to spaces. (Mixing in one file is bad and shouldn't be done).

 

I really prefer tabs. I don't understand why spaces are the standard. Doesn't make sense for me. For me as long as tabs are allowed we should use them.

Thank you for understanding.
 

[littlesat]

Now the patch replaces >99% tabs by spaces... better replace <1% spaces by taps and that is exactly following the pep guidelines... e2 has usually tabs.... but we’re repeating here... I hope pp also reads and understands.

[ims]

Now the patch replaces >99% tabs by spaces... better replace <1% spaces by taps and that is exactly following the pep guidelines... e2 has usually tabs.... but we’re repeating here... I hope pp also reads and understands.

It should not be problem with script find all .py files, where line has before first valid char any space, imho.

[littlesat]

So pp did it with a script

[ims]

it will not be many files ...

Edited by ims, 29 April 2020 - 23:35.

[WanWizard]

I've got a PHP script (I used for PHP files), which should work find for py files too...

[ims]

I found with script cca 18 files ... in most cases is problem only in divided pars to more lines with added spaces. Example...

			self.instance.setScrollbarMode(int(
				{ "showOnDemand": 0,
				  "showAlways": 1,
				  "showNever": 2,
				}[mode]))

remove spaces and change it to this?

			self.instance.setScrollbarMode(int(
				{
				"showOnDemand": 0,
				"showAlways": 1,
				"showNever": 2,
				}[mode]))

Edited by ims, 30 April 2020 - 01:29.

[littlesat]

Where is pp? He tries to push it to all the others and we know eg openatv merge everything without thinking....

Edited by littlesat, 30 April 2020 - 06:33.

[Erik Slagter]

 

I found with script cca 18 files ... in most cases is problem only in divided pars to more lines with added spaces. Example...

			self.instance.setScrollbarMode(int(
				{ "showOnDemand": 0,
				  "showAlways": 1,
				  "showNever": 2,
				}[mode]))

remove spaces and change it to this?

			self.instance.setScrollbarMode(int(
				{
				"showOnDemand": 0,
				"showAlways": 1,
				"showNever": 2,
				}[mode]))

Already better indeed, but if the strings are also indented it's even better, but I am not sure if Python allows it. Or maybe it's the formatting on the forum?

[Erik Slagter]

BTW if you use the command line version of git, there is an option to show indentation errors (as in: mix tabs/space or leave tabs/space at the end of a line).

[color]
    ui = true
    diff = true

Before you do a commit, do git diff and you'll see the problems. Even after a commit with git show it will show the problems, you can still fix them using git commit --amend when there not pushed yet. Otherwise it will have to be another (fix) commit.

Edited by Erik Slagter, 30 April 2020 - 09:32.

[ims]

 

 

I found with script cca 18 files ... in most cases is problem only in divided pars to more lines with added spaces. Example...

			self.instance.setScrollbarMode(int(
				{ "showOnDemand": 0,
				  "showAlways": 1,
				  "showNever": 2,
				}[mode]))

remove spaces and change it to this?

			self.instance.setScrollbarMode(int(
				{
				"showOnDemand": 0,
				"showAlways": 1,
				"showNever": 2,
				}[mode]))

Already better indeed, but if the strings are also indented it's even better, but I am not sure if Python allows it. Or maybe it's the formatting on the forum?

 

 

			self.instance.setScrollbarMode(int(
				{
                                        "showOnDemand": 0,
                                        "showAlways": 1,
                                        "showNever": 2,
				}[mode]))

Yes, it is possible ...

 

Btw - here is list with any spaces before text
 

Attached Files

•  list.txt   6.91KB   4 downloads

[littlesat]

I suggest shorter than replace tabs by spaces... as the pep says when the common use was tabs in existing projects keep tabs it should be better to go that way...

Edited by littlesat, 30 April 2020 - 11:09.

[Erik Slagter]

Shorter is not a valid argument (as Wanwizard already explained).

 

My main issue with spaces is that a given random point in a random file, seeing an indent of 12 spaces, does that mean the indent level is 3 spaces by 4 levels or 4 spaces by 3 levels etc. Using tabs one level is always one character.

 

There are a number of other issues with spaces (like having to backspace over all of them when going back one level) but they are more or less workaroundable. Also using tabs one can configure the shift width themselves, some of use prefer a small shift width, others like a wider shift width. Using tabs, that is never an issue, your not forced to use the same as someone else.

[littlesat]

Shorter was an argument here as pep says the current project already uses tabs most times then keep tabs... with shorter I meant here the required changes... and indeed a tab is a tab and a space comes with one four eight or what else....?

Edited by littlesat, 30 April 2020 - 11:51.

[Erik Slagter]

I really don't understand the arguments of the pro-space folks.

[WanWizard]

This article sums up the debate in the PHP community: http://paul-m-jones....er-tabs-in-php/

 

In the end, it is only about what IMS posted above, indentation and alignment of multi-line statements.

[littlesat]

That is also about php... != python where tabs/spaces are important , they are replacing the {} -and- != cpp

Edited by littlesat, 30 April 2020 - 15:26.

[WanWizard]

The spaces/tabs discussion is exactly the same, it has no relation to the language used.

 

They argue that spaces should be used because the example of IMS will look incorrectly formatted if you change your tab setting.

 

Which imho is a rather weak argument. The only point I wanted to make.

[Erik Slagter]

Yes I understand the "alignment" issue, but is insignificant compared to the other arguments (I think you agree).

 

I think the point Littlesat is trying to make that compared to C, in Python the delimiter is a syntactical element, the amount of white space has implications on the way the input is interpreted. Which I think is one of the weakest points of Python anyway. Python uses all sorts of heuristics to determine whether indentation has increased, decreased or remained the same from the previous line, very ugly. One more reason to stick to tabs, where one tab is exactly one level of indent, no misinterpretation possible.