39 replies to this topic

[Pr2]

Hi,

 

Take this setup, a STB with one tuner DVB-S2 and one tuner DVB-C.

 

While watching the DVB-S2 tuner on the main screen, I enable the PiP then enable the PiP zap feature. Then I zap to a DVB-C channel (everything is working fine). Wide screen is DVB-S2, small screen is DVB-C.

I am still in PiP-Zap and call back the channel selection, in the DVB-C channel list everything is greyed out except the channels on the same TP.

And if I zap to a greyed out channel it works, the box zap properly which is normal since the tuner is not really blocked on this particular specific TP since I plan to zap.

 

So according to me, when we are in PiP with Pip-Zap enabled we don't need to grey out channels of the tuner used for the small screen, since we call it to zap, so potentially all the channels are available for zapping on the tuner used for the PiP small picture, there is no reason to grey them out.

 

What do you think of this improvement (cosmetic I must admit since zapping is working anyway)?

 

Pr2

[Dimitrij]

This is a problem not only DVB-C,on receiver in twin tuner DVB-S2 the same problem.

[Pr2]

Hi,

 

Yes but it was easier to explain with two different DVB tuner type. 

 

Pr2

[Dimitrij]

Problem is found.

ChannelSelection.py --> def __evServiceStart/def __evServiceEnd

Intermediate option to check:

	def zap(self, enable_pipzap=False, preview_zap=False, checkParentalControl=True, ref=None):
		self.curRoot = self.startRoot
		nref = ref or self.getCurrentSelection()
		ref = self.session.nav.getCurrentlyPlayingServiceOrGroup()
		if enable_pipzap and self.dopipzap:
			ref = self.session.pip.getCurrentService()
			if ref is None or ref != nref:
				if not checkParentalControl or Components.ParentalControl.parentalControl.isServicePlayable(nref, boundFunction(self.zap, enable_pipzap=True, checkParentalControl=False)):
					if not self.session.pip.playService(nref):
						# XXX: Make sure we set an invalid ref
						self.session.pip.playService(None)
					else:
+						self.servicelist.setPlayableIgnoreService(self.session.pip.getCurrentService())
				else:
					self.setStartRoot(self.curRoot)
					self.setCurrentSelection(ref)
		elif ref is None or ref != nref:

[littlesat]

Dima,

Can you post here your latest channelselection.py and send me a pm.... So I can take a look at this tomorrow (today likely no time).

[Dimitrij]

Dima,

Can you post here your latest channelselection.py and send me a pm.... So I can take a look at this tomorrow (today likely no time).

There is only one line added.
And this is not a complete solution.

[littlesat]

And the else?

[Dimitrij]

And the else?

PM

[Dimitrij]

littlesat

open MoviePlayer -->run video -->press blue button and press "Move Picture in Picture"(pip not enabled)

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 191, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1800, in extensionCallback
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1937, in movePiP
AttributeError: Session instance has no attribute 'pip'

InfoBar.py

class MoviePlayer

--- a/InfoBar.py
+++ b/InfoBar.py
@@ -381,10 +381,17 @@
 			from Screens.PictureInPicture import PictureInPicture
 			self.session.pip = self.session.instantiateDialog(PictureInPicture)
 			self.session.pip.show()
-			self.session.pipshown = True
-			self.session.pip.playService(slist.getCurrentSelection())
-			self.session.pip.servicePath = slist.getCurrentServicePath()
+			if self.session.pip.playService(slist.getCurrentSelection()):
+				self.session.pipshown = True
+				self.session.pip.servicePath = slist.getCurrentServicePath()
+			else:
+				self.session.pipshown = False
+				del self.session.pip
 
+	def movePiP(self):
+		if self.session.pipshown:
+			InfoBarPiP.movePiP(self)
+
 	def swapPiP(self):
 		pass

 

[littlesat]

I do not see move pip when no pip is active....

[Dimitrij]

I do not see move pip when no pip is active....

open MoviePlayer -->run video

[littlesat]

Ok... I understand... Now I need time...
To speedup commit time please post your inforbar.py here..
Please learn how how to make proper patch files for us soon... So your patches also become yours...
Thanks for all the effort to improve pip stuff and the other stuff you contributed to us! This is very appriciated!

[Dimitrij]

Ok... I understand... Now I need time...
To speedup commit time please post your inforbar.py here..
Please learn how how to make proper patch files for us soon... So your patches also become yours...
Thanks for all the effort to improve pip stuff and the other stuff you contributed to us! This is very appriciated!

[Dimitrij]

+

Fix first enable togglePipzap in MoviePlayer

[littlesat]

Cool....

[Dimitrij]

littlesat

1)

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 191, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1800, in extensionCallback
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1901, in togglePipzap
AttributeError: Session instance has no attribute 'pip'

--- a/lib/python/Screens/InfoBarGenerics.py
+++ b/lib/python/Screens/InfoBarGenerics.py
@@ -1897,9 +1897,10 @@
 		slist = self.servicelist
 		if slist and self.session.pipshown:
 			slist.togglePipzap()
-			currentServicePath = self.servicelist.getCurrentServicePath()
-			self.servicelist.setCurrentServicePath(self.session.pip.servicePath, doZap=False)
-			self.session.pip.servicePath = currentServicePath
+			if slist.dopipzap:
+				currentServicePath = self.servicelist.getCurrentServicePath()
+				self.servicelist.setCurrentServicePath(self.session.pip.servicePath, doZap=False)
+				self.session.pip.servicePath = currentServicePath
 
 	def showPiP(self):
 		if self.session.pipshown:

 

2)

What is this feature?

http://sourceforge.n...42d0ae38c0bdf5/

[littlesat]

1. Why
2. It is for et boxes.... They can also zap differently on scart instead of pip

[Dimitrij]

1. Why
 

enable pip-->togglePipzap-->zap to service type 4097-->disable pip

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 191, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1800, in extensionCallback
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1901, in togglePipzap
AttributeError: Session instance has no attribute 'pip'

[littlesat]

Ok... Gstreamer stuff again...

[Dimitrij]

2. It is for et boxes.... They can also zap differently on scart instead of pip

Enabling this feature results in a very negative effect.
The receiver is out of control, the remote buttons do not work.

Edited by Dima73, 6 January 2014 - 19:15.