998 replies to this topic

[Taapat]

I

We really need to think about a way to get the community together, put all ego's aside, and redesign / rebuild Enigma.  As an (ex) professional programmer and designer, I cringe every time I have to look at the code.

It is better than a few years ago, and quite a few of us from other images post code back to PLi. But it is discouraging when PLi members tell us they don't care about other images. Or in one case when one of the PLi team members changed some code deliberately to break other images. There are too few enigma dvelopers left for that sort of stupidity. We need to work together.

That's what I write.
Here you add the greren button action: https://github.com/O...df99c48d5ab06c4
You saw what I've done but decided to do it differently.
You point to this in this commit.
You could keep backward compatibility, but you never worried about it, so you created it differently.

And now you're writing that PLi team members changed some code deliberately to break other images.
This commit indicates that you changed some code deliberately.

[Huevos]

 

 

I

We really need to think about a way to get the community together, put all ego's aside, and redesign / rebuild Enigma.  As an (ex) professional programmer and designer, I cringe every time I have to look at the code.

It is better than a few years ago, and quite a few of us from other images post code back to PLi. But it is discouraging when PLi members tell us they don't care about other images. Or in one case when one of the PLi team members changed some code deliberately to break other images. There are too few enigma dvelopers left for that sort of stupidity. We need to work together.

 

That's what I write.
Here you add the greren button action: https://github.com/O...df99c48d5ab06c4
You saw what I've done but decided to do it differently.
You point to this in this commit.
You could keep backward compatibility, but you never worried about it, so you created it differently.

And now you're writing that PLi team members changed some code deliberately to break other images.
This commit indicates that you changed some code deliberately.

 

Taapat, you are jumping to conclusions. I wasn't even talking about the vkeyboard code. And I am nothing to do with Ian's upgrades to his code. And anyway you should not have a plugin fishing around inside the vkeyboard code.

Edited by Huevos, 7 April 2019 - 15:44.

[IanSav]

Hi,

 

This is all water under the bridge as I fixed the OpenPLi exclusive version of EPGSearch as soon as I became aware of an issue.  It was a less than 20 second fix.  The issue could easily have been corrected by anyone.  The VirtualKeyBoard changes are all documented.  I stand by my VirtualKeyBoard changes as they fixed significant issues with the previous OpenPLi code.

 

I see no point in giving further weight or dragging out this whinge so this post is all I will say on this matter.

 

Regards,

Ian.

Edited by IanSav, 7 April 2019 - 15:55.

[Taapat]

And anyway you should not have a plugin fishing around inside the vkeyboard code.

And that's exactly what you've created.
Before that, we could simply point any text on the green button. And the argument "keyGreen" clearly indicated what it does.

Now you have created unnecessary global variables that are banging the green button and allowing only those texts that you think can be used. And the "style" argument does not explain that it is just for a green button.
Now really need a plugin for fishing inside the VirtualKeyBoard code to use only specific variables from VirtualKeyBoard. And if you need something add then you need to change both- in the VirtualKeyBoard and in the plugin.

I already wrote that I only see improvements for icons here.
And you can only specify an "Enter" icon with limited text.

And don't refer to the documentation because you yourself have not changed anything in the documentation in your commit: https://github.com/O...df99c48d5ab06c4

I'm not saying that you don't need to change anything. I recommend not to ignore others.

Edited by Taapat, 7 April 2019 - 17:58.

[Huevos]

 

And anyway you should not have a plugin fishing around inside the vkeyboard code.

And that's exactly what you've created.[...]
I'm not saying that you don't need to change anything. I recommend not to ignore others.

 

@Taapat, I don't know why you keep saying "you" and quoting me. These changes are nothing to do with me. They are changes by Ian to his original code.No idea what you are so annoyed about. The virtual keyboard is now working properly and so is the EPG plugin. And if PLi had pushed their changes back to the master copy of the plugin as they happened the code would be synchronized and it would be much easier sorting virtual keyboard to work in both versions. All this having duplicate repos is not good for progress.

Edited by Huevos, 7 April 2019 - 18:29.

[Taapat]

The virtual keyboard is now working properly?
Also Latvian layout working properly: https://github.com/O...igma2/pull/2097
Also green button translation working properly: https://github.com/O...igma2/pull/2100

[Taapat]

Give examples that do not work properly.

And don't mention the color buttons in keybord, which I didn't introduce because I don't see why they are needed on the keyboard if their names are shown on buttons.

[Huevos]

 

Give examples that do not work properly.

And don't mention the color buttons in keybord, which I didn't introduce because I don't see why they are needed on the keyboard if their names are shown on buttons.

 

Of course they are needed. Do you think every skin has a button bar attached to the virtual keyboard?

[IanSav]

Hi Huevos,

 

Of course they are needed. Do you think every skin has a button bar attached to the virtual keyboard?

 

Tapaat only appears to consider things that directly affect him and his code.  He has no obvious concerns that Enigma2 is a massive project with many alternatives including many different skins that each have different requirements.  As long as his code works for himself seems to be the extent of his concerns.

 

Regards,

Ian.

[Abu Baniaz]

There are three Latvians listed on On http://kbdlayout.info/
00000426 Latvian
00010426 Latvian (QWERTY)
00020426 Latvian (Standard)

Current code only shows two. How can the third be added?

Edited by Abu Baniaz, 7 April 2019 - 20:20.

[IanSav]

Hi,

 

As many keyboard layouts can be added as required.  They are just part of a single lookup table.

 

I believe that Taapat wants "Latvian - Standard" to be the default for the "lv_LV" locale.  While this is not how I understand Latvian to be defined it is an easy change to make in the code.  There is no need to replicate multiple Latvian tables as Taapat has proposed.

 

Regards,

Ian.

Edited by IanSav, 8 April 2019 - 03:17.

[IanSav]

Hi,

 

I am now testing and updated VirtualKeyBoard with "Latvian (QWERTY)" as the default keyboard for the "lv_LV" locale.  The "Latvian - Latvian", "Latvian - Standard" and "Latvian - QWERTY" keyboard locale options are now all available.  A new Hungarian keyboard to has been added to support future adoption of the VirtualKeyBoard by OpenATV.

 

I have also reviewed and reconsidered the issue of text buffer button translations.  To support string harvesting by language processing I have now changed the code to process the text buttons EXACTLY as defined.  NOTE: Translations will no longer be performed automatically!  The documentation has been changed to instruct coders to always directly translate text in the keyboard grid if they want or expect translation to occur.

 

Regards,

Ian.

[littlesat]

Please let me know what should be merged and what not??

[IanSav]

Hi Littlesat,
 
Pull Request #2101 has been raised to address the concerns raised by Taapat.  All three Latvian variants are now available with "Latvian - QWERTY" is the default for the "lv_LV" locale (as requested by Taapat).  I have also added Hungarian as a new language option.

 

I have modified the way test translations now work.  The change removed the automatic translation option I previously used to favour explicit translation requests.  This should now make the text strings used in the code available for harvesting by the translation engine.  The VIRTUALKEYBOARD documentation have been changed to reflect this functionality change.

 

No skins or images will be affected by this change.  This change is being applied to all copies of the VirtualKeyBoard code in all images.

 

The two pull requests from Taapat can be closed.  Not only are they not needed, they break the code. 

 

Regards,

Ian.

Edited by IanSav, 8 April 2019 - 10:26.

[Abu Baniaz]

That commit does not help anyone else learn how to add a language layout as you have dealt with several issues together. Please post simple instructions so in future people can add a language easily.

[Taapat]

Hi IanSav

 

1.The "Latvian - Latvian" layout.

It seems to me that you do not understand basic things.

There is no need to add multiple layouts for one language if only one is used.

As I wrote "Latvian - Latvian" by default is offered in Latvian language in enigma2.

Do you think it is very useful every time when you use the keyboard, switch it to another layout?

 

I don't know how it is in other languages, but there are no need 3 layouts in Latvian, but only one - usable.

 

2 Do you think the footer looks good?

Check the color buttons. Here's how it looks in your offer:

 screenshot1.jpg   83.77KB   2 downloads

 

That's how I fix it for Latvian:

 screenshot2.jpg   82.5KB   1 downloads

 

The color buttons are grouped together, keyboard without duplicate keys, the directional keys are on the right side, as on the computer keyboard.

But I respect others, so I offer the following changes only for Latvian.

[blzr]

Hi IanSav,

Could you please explain the reason behind this change?

-			"pl_PL": [_("Polish"), _("Poland"), self.polish(self.english)],
+			"pl_PL": [_("Polish"), _("Poland"), self.polish(self.german)],

We use QWERTY layout and not QWERTZU...

Edited by blzr, 8 April 2019 - 22:25.

[IanSav]

Hi,

 

That commit does not help anyone else learn how to add a language layout as you have dealt with several issues together. Please post simple instructions so in future people can add a language easily.

 

I felt the Hungarian change was pretty simple and self explanatory but I will add some documentation to the VIRTUALKEYBOARD documentation.

 

Regards,

Ian.

[IanSav]

Hi Blzr,

 

Could you please explain the reason behind this change?

-			"pl_PL": [_("Polish"), _("Poland"), self.polish(self.english)],
+			"pl_PL": [_("Polish"), _("Poland"), self.polish(self.german)],

We use QWERTY layout and not QWERTZU...

 

 

When I moved to the "eye candy" version of the VirtualKeyBoard I switched to using the reference keyboard layouts at http://kbdlayout.info/ and for Polish I used http://kbdlayout.info/00010415/.

 

There was a Programmer's version (http://kbdlayout.info/00000415/) so I had a 50/50 chance of making the right or wrong choice.  It would seem I made the wrong choice.  Do you want both versions available or should I switch to only using the Programmer's version?

 

Regards,

Ian.

[IanSav]

Hi,

 

I am finishing off some more documentation for the VirtualKeyBoard.  I just wanted to note and ask why I am being asked to write instructions on how to write the code I already write and maintain?  I have never seen any such documentation anywhere in Enigma2.  I thought the documentation was to designed to explain to other developers how the interface to and use the new code.

 

Even if I add some more coding documentation it still required coders to be careful and considerate of how the code is designed and structured.  They must check the changes to ensure that they don't complicate or bloat the code.  They must also ensure that they don't break existing code or features.

 

I note that documentation is severely lacking across Enigma2.  I think I have put more documentation into /doc than any other contributor.  As an Enigma2 coder I have had to study the existing code and work out how to make changes.  There was no documentation for me to follow.  While I am happy to comply with the request for more documentation I wanted to highlight that everyone should be helping to expand the documentation base for Enigma2.

 

Regards,

Ian.

Edited by IanSav, 9 April 2019 - 05:54.