998 replies to this topic

[IanSav]

Hi Persian Prince,

 

I did add it as a patch for develop and easy testing, if Ian finishes his work I'm willing to test and create merge requests for PLi's enigma2 and all wanted skins

 

The code has been complete for quite a while.  I held back from creating a pull request because I wanted to get user feedback on the changes.  I also did not want to file a pull request on language changes that may have been wrong or offensive to users of the languages that I don't know or understand.

 

Regards,

Ian.

[IanSav]

Hi Littlesat,

 

i also counted now a normal keyboard. There the top two rows have 14 keys, then 13, then 12 and then 8 (with the big space bar). In between I also verified some screenshots.

 

Have a look at this link for a range of "standard" keyboards: https://en.wikipedia...Keyboard_layout

 

Try this one: https://www.google.c...ource=univ&sa=X

 

What you should note is that what I proposed is a closer match to reality that what is currently offered in the firmware.

 

Regards,

Ian.

Edited by IanSav, 15 August 2018 - 09:22.

[littlesat]

The code has been complete for quite a while.  I held back from creating a pull request because I wanted to get user feedback on the changes.  I also did not want to file a pull request on language changes that may have been wrong or offensive to users of the languages that I don't know or understand.

+1!!!

[littlesat]

Have a look at this link for a range of "standard" keyboards: https://en.wikipedia...Keyboard_layout

 

Try this one: https://www.google.c...ource=univ&sa=X

 

What you should note is that what I proposed is a closer match to reality that what is currently offered.

+1000

[littlesat]

And now I think it is time to retrieve a good merge request on develop.... So we can all test it first before we go live with RC6.3 or RC7.0

But the same with the auto red/green/yellow/blue bottons we have a risk with old skins... When we know it we can take this risk...

Edited by littlesat, 15 August 2018 - 09:24.

[Persian Prince]

@IanSav

 

Is my patch ok or you want to send the PR yourself?

 

I can patch enigma2 skins if you want

 

Regards,

Persian Prince

[IanSav]

Hi Littlesat,

 

Have you tried the test kit yourself?  What about any of the other developers?

 

Have you looked at the code?  Do you appreciate how my rewrite has simplified and improved the code?

 

Regards,

Ian.

[IanSav]

Hi Persian Prince,

 

I have heard no feedback about the language and character sets.  Are the changes acceptable and/or not offensive?  Was my correction to the Persian character set correct?

 

I think we should at least wait for Zeros to complete their tests before creating the pull request.

 

I am happy to file a pull request so I can include all the development and change notes.

 

Is someone able to co-ordinate all the required skin changes.  I have provided the instructions but I can't access or test all the skins myself.  This is one of the reasons why I would like the assistance of an OpenPLi development partner.

 

Regards,

Ian.

Edited by IanSav, 15 August 2018 - 09:37.

[Persian Prince]

Hi Persian Prince,

 

I have heard no feedback about the language and character sets.  Are the changes acceptable and/or not offensive?  Was my correction to the Persian character set correct?

 

I am happy to file a pull request so I can include all the development and change notes.

 

Is someone able to co-ordinate all the required skin changes.  I have provided the instructions but I can't access or test all the skins myself.  This is one of the reasons why I would like the assistance of an OpenPLi development partner.

 

Regards,

Ian.

 

Persian is ok except the font which I have to use DejaVuSans.ttf

 

As I said I could help you with the skins.

 

Regards,

Persian Prince

[littlesat]

I did not verify it myself yet... but I first verify on Q of the code... So I checked this 'patch' diff https://github.com/P...wkeyboard.patch looks straight forward. No anomalies or wierd thinks to see here...

 

One tiny cosmetic thing... Shift0,1,2,3  (pictures and so) could be improved by giving it names...  (small, capital, symbols, extra???)

 

And you add a lot of comments in the code. This is good for documentation... but this is not done much in E2. It can also be in the patch, but then it is lost. Or consider to add it as separate document that is not included in the build (am file)...

[littlesat]

@PP,

Why do you need a different skin. Better to use (or extend) the standard skin... but still indeed the skin decides the skin.

[littlesat]

I prefer to go for merge requests on the develop branch and the standard skins on the littlesat branches.

[Persian Prince]

For TTF fonts I think we need a new option for enigma2, something like "Skin fonts" in settings which reads what fonts do we have in /usr/share/fonts and let us change them like:

 

Regular = "?.ttf"

LCD = "?.ttf"

Console = "?.ttf"

Fixed = "?.ttf"

 

Then we can provide some packages like "enigma2-fonts-x.ipk" on the feeds and let users change the skin fonts, for Persian it's good to use "DejaVuSans.ttf" but maybe it won't be good for Turkish.

 

Is it possible to have these settings?

[Persian Prince]

I did not verify it myself yet... but I first verify on Q of the code... So I checked this 'patch' diff https://github.com/P...wkeyboard.patch looks straight forward. No anomalies or wierd thinks to see here...

 

One tiny cosmetic thing... Shift0,1,2,3  (pictures and so) could be improved by giving it names...  (small, capital, symbols, extra???)

 

And you add a lot of comments in the code. This is good for documentation... but this is not done much in E2. It can also be in the patch, but then it is lost. Or consider to add it as separate document that is not included in the build (am file)...

 

The document could be here: https://github.com/O...ree/develop/doc as "VIRTUALKEYBOARD"

[Persian Prince]

@PP,

Why do you need a different skin. Better to use (or extend) the standard skin... but still indeed the skin decides the skin.

 

 

I prefer to go for merge requests on the develop branch and the standard skins on the littlesat branches.

 

I did patch https://github.com/l...esat/skin-PLiHD skins, give me the links to all needed skins please.

[IanSav]

Hi Littlesat,

 

I did not verify it myself yet... but I first verify on Q of the code... So I checked this 'patch' diff https://github.com/P...wkeyboard.patch looks straight forward. No anomalies or wierd thinks to see here...

 

One tiny cosmetic thing... Shift0,1,2,3  (pictures and so) could be improved by giving it names...  (small, capital, symbols, extra???)

 

And you add a lot of comments in the code. This is good for documentation... but this is not done much in E2. It can also be in the patch, but then it is lost. Or consider to add it as separate document that is not included in the build (am file)...

 

Do you mean this...

 

(The filename was changed to be legal as an attachment here.)

 

I wrote the manual a while ago ready to put in the pull request to go in the /doc directory.

 

Regards,

Ian.

 

Attached Files

•  VIRTUALKEYBOARD.txt   5.86KB   2 downloads

[Pr2]

I second Persian Prince idea about the fonts but we should have an option to reset them easily to the default value.

 

@littlesat,

 

I am surprised that you complaint about comments in code, this is the pitfall of current E2 code, there are nearly no comment in it, so somebody willing to understand it needs to perform a huge reverse engineering works to understand it.

Aren't the comment suppressed in the generated .pyo files?

[IanSav]

Hi Persian Prince,

 

For TTF fonts I think we need a new option for enigma2, something like "Skin fonts" in settings which reads what fonts do we have in /usr/share/fonts and let us change them like:

 

Regular = "?.ttf"

LCD = "?.ttf"

Console = "?.ttf"

Fixed = "?.ttf"

 

Then we can provide some packages like "enigma2-fonts-x.ipk" on the feeds and let users change the skin fonts, for Persian it's good to use "DejaVuSans.ttf" but maybe it won't be good for Turkish.

 

Is it possible to have these settings?

 

All my testing showed that the DejaVu fonts are a good quality (and free) font to use in all images.

 

I think it should just be added and used as per my skin modification suggestion.

 

Regards,

Ian.

[IanSav]

Hi Littlesat,

 

The SHIFT buttons are named as vkey_shift[0, 1, 2, ...].png as you can't tell what any shift level will contain.  It may be upper case, it could be lower case, it could be special.  I should also note that the new code is written to allow an unlimited number of shift levels.  I only created 4 levels because that is all we should need for now.  It is VERY easy to add more shift levels if we ever need them.  Existing keymaps do NOT need to change if any new language wants to have more levels.  The code is dynamic and works out what is required to support the keymap table for any given language.

 

Regards,

Ian.

[Persian Prince]

I second Persian Prince idea about the fonts but we should have an option to reset them easily to the default value.

 

@littlesat,

 

I am surprised that you complaint about comments in code, this is the pitfall of current E2 code, there are nearly no comment in it, so somebody willing to understand it needs to perform a huge reverse engineering works to understand it.

Aren't the comment suppressed in the generated .pyo files?

 

Why reset them? Just read ttf font names from /usr/share/fonts and have an option like "do nothing"

 

pyo still has the comments and the size will be increased also what Ian writes is not comment, he's really good at writing documentations so why not have them in doc folder and don't go deep in py files for finding them