998 replies to this topic

[IanSav]

Hi Persian Prince,

 

My apologies, the sample code dies NOT use the DejaVu fonts.  For testing I wanted to keep the changes simple.

 

Would you like to create a pull request to add the DejaVu fonts and then we can simply refer to them in the VirtualKeyBoard font alias setting.

 

Regards,

Ian.

[IanSav]

Hi,

 

I thought the .pyo files had all comments removed.  Am I wrong?

 

If the comments are kept in the .pyo file then I would like to remove the big comment block and simply point to the documentation in the /doc directory.

 

Regards,

Ian.

[Persian Prince]

Hi Persian Prince,

 

For TTF fonts I think we need a new option for enigma2, something like "Skin fonts" in settings which reads what fonts do we have in /usr/share/fonts and let us change them like:

 

Regular = "?.ttf"

LCD = "?.ttf"

Console = "?.ttf"

Fixed = "?.ttf"

 

Then we can provide some packages like "enigma2-fonts-x.ipk" on the feeds and let users change the skin fonts, for Persian it's good to use "DejaVuSans.ttf" but maybe it won't be good for Turkish.

 

Is it possible to have these settings?

 

All my testing showed that the DejaVu fonts are a good quality (and free) font to use in all images.

 

I think it should just be added and used as per my skin modification suggestion.

 

Regards,

Ian.

 

Yeah DejaVuSans.ttf is great but will PLi accept it for all? I don't think so.

 

https://forums.openp...ndpost&p=897151 shows it has almost everything but maybe it's better to be tested by more users, still I think having a "Font settings" option would be better.

 

Regards,

Persian Prince

[Persian Prince]

Hi,

 

I thought the .pyo files had all comments removed.  Am I wrong?

 

If the comments are kept in the .pyo file then I would like to remove the big comment block and simply point to the documentation in the /doc directory.

 

Regards,

Ian.

 

I'm not 100% sure about this but I decompiled some pyo files long ago and I saw the comments again.

[IanSav]

Hi Persian Prince,

 

 

Yeah DejaVuSans.ttf is great but will PLi accept it for all? I don't think so.

https://forums.openp...ndpost&p=897151 shows it has almost everything but maybe it's better to be tested by more users, still I think having a "Font settings" option would be better.

 

Submit the pull request and see what happens. 

 

Have you ever looked at my OverlayHD skin?  It has a lot of configurable / dynamic changes available, including using different fonts across different parts of the UI.  ( https://bitbucket.org/IanSav/overlayhd, http://www.beyonwiz....php?f=48&t=9548 )

 

Regards,

Ian.

Edited by IanSav, 15 August 2018 - 10:20.

[Persian Prince]

First images with your virtual keyboard: https://forums.openp...ndpost&p=919415

 

bitbucket and gitlab are not accessible in my country so I imported your repo here: https://github.com/P.../overlayhd-skin (If you want we can adapt it for PLi too, first I need to test it myself)

 

PR for DejaVuSans.ttf: https://github.com/O...igma2/pull/1669

 

Regards,

Persian Prince

[IanSav]

Hi Persian Prince,

 

Could you please edit your copy of OverlayHD to remove the text that your copy is the master copy.    Please provide a pointer back to my repository for the latest and authoritative version.

 

Regards,

Ian.

[Persian Prince]

Done my friend.

 

Also DejaVuSans.ttf is now in PLi's enigma2 and we can use it: https://github.com/O...7a63f8082b45135

 

Now you can update your codes for DejaVuSans.ttf

 

Regards,

Persian Prince

[IanSav]

Hi Persian Prince,

 

Have you included DejaVu into the skin as yet?

 

If not add this to the test kit:

<fonts>
	<font name="DejaVuSansCondensed" filename="DejaVuSansCondensed.ttf" scale="100" />
	<alias name="VirtualKeyBoard" font="DejaVuSansCondensed" size="42" height="68" />
</fonts>

If you have included it into the skin then simply point the alias to the font definition.

 

Can you please test this and report back.

 

Regards,

Ian.

[Persian Prince]

It's not "DejaVuSansCondensed.ttf", it's "DejaVuSans.ttf" which covers almost all languages so it should be:

<fonts>
	<font name="DejaVuSans" filename="DejaVuSans.ttf" scale="100" />
	<alias name="VirtualKeyBoard" font="DejaVuSans" size="42" height="68" />
</fonts>

I will test this later.

 

Regards,

Persian Prince

Edited by Persian Prince, 15 August 2018 - 11:40.

[IanSav]

Hi Persian Prince,

 

Sorry for the assumption.  I like the condensed version better. 

 

Regards,

Ian.

[Persian Prince]

It's not "DejaVuSansCondensed.ttf", it's "DejaVuSans.ttf" which covers almost all languages so it should be:

<fonts>
	<font name="DejaVuSans" filename="DejaVuSans.ttf" scale="100" />
	<alias name="VirtualKeyBoard" font="DejaVuSans" size="42" height="68" />
</fonts>

I will test this later.

 

Regards,

Persian Prince

 

Tested and ok

[Persian Prince]

Just take a look at "PLi-FullNightHD" skin and Persian language with "LiberationSans-Regular.ttf" font which doesn't support Persian characters:

 

 

And now with "DejaVuSans.ttf" font which supports Persian:

 

 

[littlesat]

I cannot read that... so i cannot be that specific... But it can also be considered to add the missing characters to the font instead of using a complete new font.... I already modified the standard font we use with an font editor... (long time ago because I did not like the i and j).

Edited by littlesat, 15 August 2018 - 12:42.

[IanSav]

Hi Littlesat,

 

I cannot read that... so i cannot be that specific... 

 

You can't read that text?  Think about how hard it was for me to write the code to produce a keyboard with text like that! 

 

Regards,

Ian.

[littlesat]

[zeros]

My test results:

 

LOC - INS I would change the LOC key name to INS.
Some of the fonts were missing, which you already talked about (Persian for example).

For me now everything OK, I add the Screenshots.

Tested with YouTube plugin, PLi-HD skin.

 

Attached Files

•  VirtualKeyBoard.zip   35.48KB   6 downloads

[zeros]

Latvian-international characters are missing.. Probably as well as the lack of a font!?
Could also add Lithuanian language, maybe a few more, I don't know.
Should test also PLI-FullNightHD skin, what is the default skin.
Overall, very good in my opinion.

Edited by zeros, 15 August 2018 - 18:41.

[IanSav]

Hi Zeros,

 

LOC - INS I would change the LOC key name to INS.

 

Could you please explain this request.  LOC is the YELLOW button to bring up the Locale selection menu while INS is the screen display of the insert mode (INS) or overwrite mode (OVR) controlled by the INFO button.

 

Is there something wrong or is this a request for a change and/or enhancement?

 

Regards,

Ian.

[IanSav]

Hi Zeros,

 

Latvian-international characters are missing.. Probably as well as the lack of a font!?
Could also add Lithuanian language, maybe a few more, I don't know.
Should test also PLI-FullNightHD skin, what is the default skin.
Overall, very good in my opinion.

 

Missing characters will probably be due to the character set.  Please give me a screen capture of the offending screen and make notes on the image to show what characters are missing.  If you give me the unicode value of the character ( https://en.wikipedia...code_characters ) then I can check if the button is correctly assigned.  If it isn't I can apply the character correction you recommend.

 

If you believe that more languages should be supported then please give me a list of them.  If you can provide a series of 14 x 4 grids with the unicode values for each cell then that would make adding any requested keyboards much easier and faster for me to add.  If one locale is based on another then please highlight what is the same and what is different.  I am happy to add any keyboards that users will find helpful.

 

While I can easily add new keyboards at any time, should I hold up the release to wait for any of these new keyboards?  If not, I will submit the code and await your requests for updates that can be applied later.

 

Regards,

Ian.