998 replies to this topic

[ims]

Hi Ims,

 

It appears that I have misunderstood the intention of your post.  Sorry for the contextually inappropriate overreaction.

 

I still contend that the way OpenPLi handles image location management can be improved.  Also, I think it can be done to maintain backwards compatibility AND be useful for other images.

 

Regards,

Ian.

 

Sorry, my english is limited, I can not compose poems in Jambic pentameter... 

 

Understand, that this little change in path means change all skins (it is more than 5 PLi skins) working under PLi . And when will be finished "intergalactic" solution, then remove duplicities in this skins again.  Thats all... Due it , temporarily, could be there if then... =>no works on skins.

[IanSav]

Hi Ims,

 

I think I have a solution that will maintain compatibility with ALL existing OpenPLi skins.  I am still polishing off some text code for Zeros to test the new NumericalTextInput.  WHen that is done I will try coding up my proposal.

 

Regards,

Ian.

[zeros]

The Estonian character š now OK. It is also on the dreambox Test feed.
Also , the two pages are OK and quote enough.

Attached Files

•  7FC212BC-B1C8-4525-A769-E5EEAF09AC05.jpeg   101.98KB   3 downloads

[Rob van der Does]

 

Please be aware that AFAIK PLi is the only brand that uses a default skin folder within the skin folder (on top of the standard E2 default skin)..

what is wrong about it?

 

 

It's not about right or wrong (although it's quite a strange setup); it's something to take into consideration in this thread.

[IanSav]

Hi Zeros,

 

I think I have finished the prototype of the new NumericalTextInput.  The new version will now use the locale based characters for all text based input.  (Hex input is the same everywhere.)

 

The big visual difference from the version I posted previously is that the current locale is checked and if that locale has been defined to have alternate character definitions the locale based data is used instead.  The data is matched in such a way that all the mode selected display options are now ALL available.  That is, if you ask for a text string that only has upper case characters then all the characters from your locale will be used.  In the previous code all the formatting options were lost if a locale was specified.  The code is now fully symmetrical.

 

I will try and update the other languages and the post a copy of the code here for testing and review.

 

Regards,

Ian.

[zeros]

OK, it would be good if these letters would go exactly on these positions, as posted by Mr.blzr (on post #427)
I do not know whether it is standardized and I have no clue as to how other languages could be.

[ims]

Could be added: 

self.setTitle(_("Virtual KeyBoard")) 

For full screen skins (without title) it is needed for text on top screen.

[athoik]

Hi Athoik,
 

Are there any developers interested in making this happen?

Yes I am interesting adding the rendered!

 
That sounds great.  Please keep us informed of your progress.
 
Please try to make the code portable to other images.  This could be a valuable addition to Enigma2.
 
Regards,
Ian.

I created a new branch called svg that currently adds support for svg in picture player, using nanosvg library.

https://github.com/O...a8a9169e3c78945

Rendering the thumbnail needs more care... But picture player already works.

 screenshot.jpg   92.63KB   2 downloads

Any idea what should be implemented next?
 

@IanSav,
 
Of course a solution needs to be found for today skins to retrieve the proper graphics. So a "folder" based solution is needed.
 
I have created a feature in devtools to keep in mind the .svg idea.
 
https://devtools.ope....org/issues/353
 
Pr2

It's not an idea any more

[MCelliotG]

Why not animated gif too?

Στάλθηκε από το Redmi Note 5 μου χρησιμοποιώντας Tapatalk

[Pr2]

There are already lots of ideas on devtools (Features), if you have time for them...     

[IanSav]

Hi Zeros,

 

OK, it would be good if these letters would go exactly on these positions, as posted by Mr.blzr (on post #427)
I do not know whether it is standardized and I have no clue as to how other languages could be.

 

That is exactly what I used for the template.

 

Regards,

Ian.

[IanSav]

Hi Ims,

 

Could be added: 

self.setTitle(_("Virtual KeyBoard")) 

For full screen skins (without title) it is needed for text on top screen.

 

This should not be necessary.  Add a "title=" attribute to the "VirtualKeyBoard" screen in the skin.  (Hint, the "title=" attribute is fully translatable and allows the skin controller to tweak the title text without needing to tweak the code.)

 

I haven't tried this on OpenPLi but it should work.  Please tell me if it doesn't.

 

Regards,

Ian.

[IanSav]

Hi Athoik,

 

Any idea what should be implemented next? 

 

Does this mean that SVG images can now be used in the skin engine?

 

If you are asking about other graphical additions then I would support MCelliotG's suggestion for animated GIFs.  (As long as they aren't a performance killer in the UI.)

 

Regards,

Ian.

Edited by IanSav, 26 August 2018 - 23:40.

[Rob van der Does]

Hi Ims,

 

Could be added: 

self.setTitle(_("Virtual KeyBoard")) 

For full screen skins (without title) it is needed for text on top screen.

 

This should not be necessary.  Add a "title=" attribute to the "VirtualKeyBoard" screen in the skin.  (Hint, the "title=" attribute is fully translatable and allows the skin controller to tweak the title text without needing to tweak the code.)

 

I haven't tried this on OpenPLi but it should work.  Please tell me if it doesn't.

 

Regards,

Ian.

 

The preferred way is indeed to use the selftitle and hence no full title should be in the skin. Translations should be done via the E2-po, not via/by skinners.

Only a few screens for plugins that lack this will have to use the full title in the skin.
 

[IanSav]

Hi Rob,

 

 

 

Could be added: 

self.setTitle(_("Virtual KeyBoard")) 

For full screen skins (without title) it is needed for text on top screen.

This should not be necessary.  Add a "title=" attribute to the "VirtualKeyBoard" screen in the skin.  (Hint, the "title=" attribute is fully translatable and allows the skin controller to tweak the title text without needing to tweak the code.)

 

I haven't tried this on OpenPLi but it should work.  Please tell me if it doesn't.

 

The preferred way is indeed to use the selftitle and hence no full title should be in the skin. Translations should be done via the E2-po, not via/by skinners.

Only a few screens for plugins that lack this will have to use the full title in the skin.

 

The "title=" attribute in the skin is fully translated by the same translation system used in the code.  All the skin titles, and "text=" attributes should be in English and will be translated for you. 

 

Regards,

Ian.

Edited by IanSav, 27 August 2018 - 05:11.

[Rob van der Does]

Are you sure that applies to PLi as well?

Anyway the selftitle is the preferred way: it requires less skin code.

[IanSav]

Hi Rob,

 

I checked the OpenPLi sources and the code is there as well.

 

As you will discover when I present more of my code, I have a preference to allow as much user configurability as possible without adding bloat.  Hard coding titles in the Python does not follow that philosophy.  It adds unneeded code to the module when the skin engine already does the work for you.  With this style skin developers and users are able to easily change the titles for themselves (if the skin method is used).  I use this a lot in my code. 

 

The only place this doesn't work is where the title is programmatically changed while the code is running.

 

Regards,

Ian.

Edited by IanSav, 27 August 2018 - 06:20.

[littlesat]

I did abort two merge request from fairbird because I think we can make this smarter... I’m considering that skin_default stuff could be made a some kind of don’t care....

[ims]

Hi Ims,

 

Could be added: 

self.setTitle(_("Virtual KeyBoard")) 

For full screen skins (without title) it is needed for text on top screen.

 

This should not be necessary.  Add a "title=" attribute to the "VirtualKeyBoard" screen in the skin.  (Hint, the "title=" attribute is fully translatable and allows the skin controller to tweak the title text without needing to tweak the code.)

 

I haven't tried this on OpenPLi but it should work.  Please tell me if it doesn't.

 

Regards,

Ian.

It works for not full screen skins, where screen has own title... but for full screen skins is title=" "  for nothing...

[IanSav]

Hi Ims,

 

Yes, you need to have a space to create a blank title.  This is due to an issue in skin.py where the string is translated unconditionally.  This is wrong.  If the title is set to "" the system generates the language status screen.  This is a quick fix.

 

Some screens are uncontrollable because the title has been hard coded in Python. 

 

Regards,

Ian.