998 replies to this topic

[ims]

my title="" was example only ...  full screen skins do not using title="blabla" from skin screen, but using setTitle("blabla") from python. Thats all...

[IanSav]

Hi,

 

I have created Pull Request #1701 to fix not translating blank "titles=" and "text=" attributes in the skin.

 

Please check this code before merging the pull request as I threw this together without testing to point out where, in the code, this is processed.

 

Regards,

Ian.

[IanSav]

Hi Ims,

 

As I move through the code I have been fixing the title processing.  You will see this in the new Setup.pl where the titles are actually defined in "setup.xml" and used by the Setup code.  Most of the skin "title=" attributes don't work because the Python code is forcing an override.

 

Setting the title in the VirtualKeyBoard skin should be working.

 

Regards,

Ian.

Edited by IanSav, 27 August 2018 - 07:50.

[littlesat]

When value is an empty string value is also false so I think this does not really help

[IanSav]

Hi Littlesat,

 

You are right.  If you have a title="0" (zero) then the string will not be translated.  Well I have highlighted the two entries in skin.py that need protection.  By all means fix as appropriate.  I quickly filed the pull request and the warning here because I only just searched for the code a short while ago to answer Rob's question.  I am in the middle of something else and didn't have time to properly think out and test the code.

 

Perhaps "if value is not None and value !="":" would have been better. 

 

If someone doesn't fix this first I will resubmit the fix later (after proper testing). 

 

Regards,

Ian.

Edited by IanSav, 27 August 2018 - 08:02.

[ims]

Once again ... title="blabla" in skin's screen is translated.

But if not exist border (=> not exists TITLE) for screen = screen as "fill", this text is not used. In this time is used text as self.setTitle(_("blabla")). And this using all "full screen" skins

Edited by ims, 27 August 2018 - 08:04.

[IanSav]

Hi Ims,

 

Can you give me an example screen where you are seeing a "title=" issue so I can investigate.

 

Regards,

Ian.

[ims]

For this 

<widget source="Title" render="Label" p

(skin_templates.xml) under <screen name="TopTemplate"> there must be in .py setTitle(_(Virtual keyboard")) or it is not translated.

 

That's all... ...

Edited by ims, 27 August 2018 - 08:30.

[IanSav]

Hi,

 

This is a general question for anyone who can help.

 

I have the new NumericaTextInput.py code ready for people here to test before I raise a pull request.  There will need to a simple code change in any code that looks inside the NumericaTextInput.py code for certain values that no longer exist.  In all the OpenPLi main image source this only occurs once in "MovieSelection.py".  The change is easy to implement.  What I would like to know is if there is a way to easily scan ALL plugins to see if any of them use the same problematic code?

 

If searching is not possible how can I alert people for the need to fix their code?  As with VIRTUALKEYBOARD I will create a small instructional document to explain the removal of the "search=" parameter and the addition of the significantly more comprehensive "mode=" parameter.

 

Regards,

Ian.

[IanSav]

Hi Ims,

 

For this 

<widget source="Title" render="Label" p

(skin_templates.xml) under <screen name="TopTemplate"> there must be in .py setTitle(_(Virtual keyboard")) or it is not translated.

 

That's all... ...

 

I will have to check this out and fix it.  I probably never noticed the problem because all my work is usually in English.  OpenPLi has been expanding my horizons to introduce me to working with lots of different languages.

 

Regards,

Ian.

[Taapat]

@IanSav I think you miss a couple of things:

1. Title for skins who use sreen position = "fill", and therefore they do not have the title on top of the screen, but they use a separate widget. For example in skin PLi-FullHD: https://github.com/l.../skin.xml#L2032

2. Enigma generates translations only for the that, what is in the enigma sources. You can not call in skin screen how you think. You must use a name that is already in the enigma to be translated.

I saw this problem yesterday in zeros screenshots, so I changed the screen examples in your doc file: https://github.com/O...5aaefc57d348f1f

 

To fix this in skins with screen position = "fill" you need return back self.setTitle(_("Virtual keyboard")).

Not "Virtual KeyBoard"! We do not need another translation that duplicates.

Edited by Taapat, 27 August 2018 - 08:57.

[Pr2]

I second Taapat (as translator) I try to have OpenPLi fully in french so what I translate is Enigma2 and now also all the opensource plugins from the feeds are also in french because they have there own strings, but I cannot afford to translate skins and as Taapat remark is correct a skin is not there to translate or rename screens, it is just the look & feel that a skin change not the text. Since VirtualKeyboard is part of Enigma2 every strings added for its own need are also translated.

[IanSav]

Hi,

 

I don't understand why "fill" stops the translations.  I want to investigate this and provide a fix if possible.  I will update this thread with my findings.

 

Regards,

Ian.

[IanSav]

Hi Pr2,

 

Did I get the French correct in VirtualKeyBoard?  Please also check NumericalTextInput when I put it up in here.

 

Regards,

Ian.

[littlesat]

title = "0" is also not None and has content... so if title is not None and title != "" makes no sense... just if Title: is sufficient...

 

But I still think this no title empty string thing should be solved in a different way...

Edited by littlesat, 27 August 2018 - 10:30.

[IanSav]

Hi Littlesat,

 

But I still think this no title empty string thing should be solved in a different way...

 

What are you thinking?  Putting a space in an empty string to stop the version report is not a clean solution.

 

Regards,

Ian.

[Taapat]

I don't understand why "fill" stops the translations. 

 

Maybe I'm mistaken, but it seems to me that this is because the widget used on screen with fill use self ["Title"], which is assigned with setTitle.

It does not stop translation, it does not assign this variable.

This screen does not have a tile because it fills the entire screen without borders and without a screen tile from skin, and thefore you use aditional widget wich use source="Title".

Edited by Taapat, 27 August 2018 - 11:24.

[Taapat]

Sorry, after exploring the source, I see that I made a mistake before.

This should fix title translation if use title from skin attributes: https://github.com/O...igma2/pull/1702

 

Of course, in skin you need a phrase that is in enigma translations.

Therefore, it seems to me is better to use a fixed self.setTitle(_("Virtual keyboard")), as before, to the translated phrases be generated in translations of enigma.

In this case, the creator of the skin needs to check what phrase use for title.

Edited by Taapat, 27 August 2018 - 15:45.

[Rob van der Does]

If the selftitle is not being used, a generic screentemplate can't be used either; it will need it's own specific title widget.

A waste of code with no advantages; it's up to the coder to come up with a good title.

[athoik]

Does this mean that SVG images can now be used in the skin engine?

Not yet.

I guess LoadPixmap should be fixed to support svg and that seems different than picload.

Also picload svg thumbnail doesn't work right yet.

I seens that nanosvg can work with few svg's only (and it's expected). On the other hand, other solutions seem way more complicated!!!


Is there anybody able to explain how an ePtr<gPixmap> should be filed from an "RGBA image (non-premultiplied alpha)"?

        result = new gPixmap(width, height, bit_depth * channels, pixmapDisposed, accel);
        gUnmanagedSurface *surface = result->surface;
... 

It's just enough to put the rgba image to surface->data?