998 replies to this topic

[Pr2]

Hi,

 

I use one of the standard OpenPLi skin so I report it here to have it fixed for everybody. 

 

Pr2

[ims]

Which skin ? I finetuned it in PLiFullHD only. I "like", if anybody adding anything to PLi and do not then finetune basic skin (PLiFullNightHD), but I have not free time make work of others

Edited by ims, 20 August 2018 - 09:58.

[littlesat]

Indeed the SMS help window needs some 'relocation'....

 

I also think we for the VK we should to re-locate the graphs to the skin_default folder... As this supports the current logic.

Edited by littlesat, 20 August 2018 - 09:59.

[Dimitrij]

No handlers could be found for logger "AT"
Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 49, in action
  File "/usr/lib/enigma2/python/Screens/ChannelSelection.py", line 427, in okbuttonClick
  File "/usr/lib/enigma2/python/Screens/ChannelSelection.py", line 576, in renameEntry
  File "/usr/lib/enigma2/python/Screens/ChannelSelection.py", line 905, in renameEntry
  File "/usr/lib/enigma2/python/mytest.py", line 287, in openWithCallback
    dlg = self.open(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/mytest.py", line 297, in open
    dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/mytest.py", line 240, in instantiateDialog
    return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
  File "/usr/lib/enigma2/python/mytest.py", line 264, in doInstantiateDialog
    dlg.applySkin()
  File "/usr/lib/enigma2/python/Components/GUISkin.py", line 154, in applySkin
  File "/usr/lib/enigma2/python/Components/GUISkin.py", line 57, in createGUIScreen
  File "/usr/lib/enigma2/python/Screens/VirtualKeyBoard.py", line 581, in buildVirtualKeyBoard
  File "/usr/lib/enigma2/python/Screens/VirtualKeyBoard.py", line 612, in markSelectedKey
AttributeError: 'NoneType' object has no attribute 'size'

[IanSav]

Hi,

 

For image location this is what I think should happen in Directories.py when using SCOPE_CURRENT_SKIN:

 

Assume that the skin or the code wants to load am image "buttons/sample.png".

1. First look for the image "sample.png" in the folder "/usr/share/enigma2/<skinname>/buttons/" where <skinname> is the current skin.
2. Look for the image "sample.png" in the folder "/usr/share/enigma2/skin_default_<resolution>/buttons/" where <resolution> is the current screen resolution.
3. Look for the image "sample.png" in the folder "/usr/share/enigma2/skin_default/buttons/".
4. Look for the image "sample.png" in the folder "/usr/share/enigma2/skin_default/".
5. The image is not available, log a skin error.

This is a maximum effort to find an image to display in a skin.

 

Regards,

Ian.

[IanSav]

Hi Dimitrij,

 

The images are not in the correct location.  Have you read the documentation?

 

Regards,

Ian.

[IanSav]

Hi,

 

If my proposal in post #325 (two posts up) is acceptable then all of these library images could be stored and shared in the appropriate resolutions of skin_default.  If a skin writer wants to modify the standard look then simply put a replacement image within your own skin.  If you don't then a standard image will be found and used to make the screen display.

 

If the image is resolution irrelevant then put it in the non resolution specific skin_default.

 

If the image is super critical then it could be put in the top level of skin_default.  (I don't think we should let skins get this out of date or out of control.

 

Regards,

Ian.

Edited by IanSav, 20 August 2018 - 10:35.

[Persian Prince]

@IanSav

 

I just compiled new test images for you.

 

beyonwizt3: http://www.mediafire...t3_usb.zip/file

 

beyonwizt4: http://www.mediafire...t4_usb.zip/file

 

Regards,

Persian Prince

[littlesat]

Assume that the skin or the code wants to load am image "buttons/sample.png".

1. First look for the image "sample.png" in the folder "/usr/share/enigma2/<skinname>/buttons/" where <skinname> is the current skin.
2. Look for the image "sample.png" in the folder "/usr/share/enigma2/skin_default_<resolution>/buttons/" where <resolution> is the current screen resolution.
3. Look for the image "sample.png" in the folder "/usr/share/enigma2/skin_default/buttons/".
4. Look for the image "sample.png" in the folder "/usr/share/enigma2/skin_default/".
5. The image is not available, log a skin error.

Please first make the pictures PLi compatibla and then change this later....  And add to 1 the skin_default overrule and don't do 4

Edited by littlesat, 20 August 2018 - 12:11.

[IanSav]

Hi Littlesat,

 

There should be nothing to fix now.  VirtualKeyBoard should be fully functional without changing image paths.  When SCOPE_CURRENT_SKIN is fixed in OpenPLi then the images can be put into common areas.  VirtualKeyBoard will not need to be changed.

 

Regards,

Ian.

[littlesat]

AttributeError: 'NoneType' object has no attribute 'size'

Looks we like to need a sanity check...

 

There should be nothing to fix now.  VirtualKeyBoard should be fully functional without changing image paths.  When SCOPE_CURRENT_SKIN is fixed in OpenPLi then the images can be put into common areas.  VirtualKeyBoard will not need to be changed.

It is working indeed, but the location where the pictures are now located is not the OpenPLi standard... that should be changed (later).

[IanSav]

Hi Littlesat,

 

 

AttributeError: 'NoneType' object has no attribute 'size'

Looks we like to need a sanity check...

 

A sanity check is also required for loading fonts.  Enigma2 should not crash is a font file is not found.

 

Regards,

Ian.

[littlesat]

And what font should it choose then.... ?... I think missing a font is not VK related and out of scope here...

 

B.t.w. the skin decide where the pictures are... so that should be adjusted in the skins... So also not VK related...

 

Adding paths to find default pictures on resolution is a different feature... Also out of skope here

[IanSav]

Hi Littlesat,

 

And what font should it choose then.... ?... I think missing a font is not VK related and out of scope here...

 

B.t.w. the skin decide where the pictures are... so that should be adjusted in the skins... So also not VK related...

 

Adding paths to find default pictures on resolution is a different feature... Also out of skope here

 

Okay, so there is nothing more to do for VirtualKeyBoard except help people to get their skins correct. 

 

Regards,

Ian.

[littlesat]

As far I can see...

And of course consider to add some 'cursor navigation' via buttons on your remote...

Edited by littlesat, 20 August 2018 - 15:54.

[IanSav]

Hi Littlesat,

 

I intend to hold off on any changes to the key mappings until you can experience the new Setup / ConfigList / config.py.  This is what I am currently working upon.  Then I will clean up the navigation on the remaining screens and controls.  All those changes will be consistent with each other.  The changes should then make more sense.

 

Regards,

Ian.

[zeros]

PLi-HD still NOK, but the solition should be on the Post #157
https://forums.openp...e-8#entry918771
Probably the file skin.xml, what is there presented.
I'il be examining it in tomorrow morning. If I'm going to add it to the instructions on Post #157, it's okay. What's exactly going to change, i'il check in tomorrow.

Edited by zeros, 20 August 2018 - 20:01.

[ims]

PLi-HD still NOK, but the solition should be on the Post #157
https://forums.openp...e-8#entry918771
Probably the file skin.xml, what is there presented.
I'il be examining it in tomorrow morning. If I'm going to add it to the instructions on Post #157, it's okay. What's exactly going to change, i'il check in tomorrow.

will be patient ...

[IanSav]

Hi,

 

Please remember that my skin instructions are just a guide to what needs to be done.  All skin designers are free to display the VirtualKeyBoard in any way they want.  For example, in my OverlayHD skin the VirtualKeyBoard is shown in a full screen with headings and buttons like any other full screen display in that skin.  I believe that some of the OpenViX skins will also be using full screens as well.  OpenPLi skins do not have to be pop up windows if you don't want them that way.

 

The code should support displaying the VirtualKeyBoard any way the skin designer chooses.

 

Regards,

Ian.

[zeros]

Morning test results:
The absence of buttons leads to the result of GSOD (Post #302).
So after copying the files from '1080' to the folder
/usr/share/enigma2/PLi-HD/buttons/
the GSOD disappears.

However, it is also necessary to change the file skin.xml in the folder
/usr/share/enigma2/PLi-HD
Otherwise, the entire keyboard is not visible on the screen.

The same thing apllies to PLi-HD1 and PLi-HD2.

Attached Files

•  If-not-edit-the-skin.xml-NOK.png   982.72KB   0 downloads