998 replies to this topic

[zeros]

About Estonian language, I find a small bug: we're missing one character 'š' and 'Š'.

I would suggest to put it on the third page.

Attached Files

•  et_EE-šŠ.png   1.18MB   0 downloads

Edited by zeros, 25 August 2018 - 10:45.

[zeros]

T9 keyboard (SMS Type keyboard), it's more complicated than I thought.
I can't find the standard about Estonia. I'd have to try on some old type cell phone what I do not have at the moment because I would like to add this thing as it is elsewhere as well.

https://www.online.e...a1-bab232635ab4

[IanSav]

Hi Zeros,

 

About Estonian language, I find a small bug: we're missing one character 'š' and 'Š'.

I would suggest to put it on the third page.

 

I can move the "\" to the bottom row then I can add the 'š' and 'Š' just under the BACKSPACE button on shift level 0 and 1 respectively.  Is that okay.

 

Regards,

Ian.

[IanSav]

Hi Zeros,

 

T9 keyboard (SMS Type keyboard), it's more complicated than I thought.
I can't find the standard about Estonia. I'd have to try on some old type cell phone what I do not have at the moment because I would like to add this thing as it is elsewhere as well.

https://www.online.e...a1-bab232635ab4

 

I am sorry but I don't understand what all the images are meant to mean or what you want me to do.

 

Regards,

Ian.

[zeros]

On the question from your first post-
Yes, I think it would be OK. And you can then delete the third page because there are no Estonian letters and õ, ä, ö, ü - they already on the first page exists.
On an Estonian keyboard we would get š with AltGr+s.
And second- Estonia is just missing at the moment and I can see there English default setup. I'm investigating where the missing characters of Estonia are located on T9 keyboard (SMS Type keyboard)

[IanSav]

Hi Zeros,

 

The VirtualKeyBoard changes are done.  I will wait a little while to see if any other changes are requested before I commit this change.

 

Regards,

Ian.

[blzr]

And second- Estonia is just missing at the moment and I can see there English default setup. I'm investigating where the missing characters of Estonia are located on T9 keyboard (SMS Type keyboard)

 

This one from attached screen would be correct Estonian text input layout?

(I was not completely sure about Š and Ž if they should be included, and of the order of special O's...)

Attached Files

•  eesti_numtxtinput.jpg   43.85KB   0 downloads

Edited by blzr, 25 August 2018 - 16:17.

[zeros]

We have an old-type mobile with keyboard Sony Ericsson W715. I will try to rip in tomorrow how Estonian language has been presented there. The main characters are the letters õ,ä,ö,ü,š,ž, what are missing, If we are talking about Estonian SMS type keyboard.

Attached Files

•  179CFB87-9727-46C2-A8BF-117BC6FB9190.jpeg   85.94KB   0 downloads

[Taapat]

@IanSav are you offering these changes In VirtualKeyBoard thought also about compatibility?

 

1. Why do you change the location of buttons png from skin_default to buttons?

 

This makes mandatory create these buttons in skins and not allow use it from skin_default.

It create GSOD on all skins that miss this change and does not have own buttons for VirtualKeyBoard!

 

I think it's right to place these buttons png in skin_default as before, because in that case they are in enigma and they can be used by all skins without change.

If you want your buttons you can change them in skin_default in your skin.

 

2. Why did you change the "header" to the "prompt"?

I understand that the "prompt" is a more precise mark, but it also breaks the compatibility with skins without change.

I think it's better to leave a "header" as before.

Edited by Taapat, 25 August 2018 - 17:08.

[IanSav]

Hi Everyone,

 

After Zeros' request I have reviewed my plans for NumericalTextInput.  I have now rewritten it to be significantly more flexible.  All the various input modes, text entry, search entry and hex entry, can now be offered for ALL languages.  I believe that the hex modes are international and will be the same in all languages.  If I am wrong please tell me.

 

What this means, for example, is that the NumericalTextInput search option can now be in a local language and not forced to only be in English.

 

I will try to adapt the existing languages into the new system but I really need your help the check my work and offer improvements and corrections.  Remember I only know English so I will likely make mistakes for which I will welcome corrections.

 

Regards,

Ian.

[blzr]

We have an old-type mobile with keyboard Sony Ericsson W715. I will try to rip in tomorrow how Estonian language has been presented there. The main characters are the letters õ,ä,ö,ü,š,ž, what are missing, If we are talking about Estonian SMS type keyboard.

 

As you can see on the screenshot in my previous post, I've added ä,õ, ö, š, ü, ž letters in my version;
if you'd like to test on your stb, NumericalTextInput.py with Estonian layout added attached...

Attached Files

•  NumericalTextInput.py   7.76KB   3 downloads

[IanSav]

Hi Taapat,
 

@IanSav are you offering these changes In VirtualKeyBoard thought also about compatibility?
 
1. Why do you change the location of buttons png from skin_default to buttons?

This makes mandatory create these buttons in skins and not allow use it from skin_default.

It create GSOD on all skins that miss this change and does not have own buttons for VirtualKeyBoard!

 
I think it's right to place these buttons png in skin_default as before, because in that case they are in enigma and they can be used by all skins without change.
If you want your buttons you can change them in skin_default in your skin.

 

If you have been following this topic OpenPLi has a very strange way of locating images. It makes no allowance for finding images in standard locations and has no option to find images based on the current resolution of the skin.  I have proposed ways to fix this and I think some of the developers are seeing the issue and are also considering a change to make locating images easier and smarter.

 

Did you read my instruction manual ( /doc/VIRTUALKEYBOARD ) for implementing the new VirtualKeyBoard?  I have also provided XML samples and all the standard images that most developers can use to kick start their skin updates.

 

2. Why did you change the "header" to the "prompt"?

I understand that the "prompt" is a more precise mark, but it also breaks the compatibility with skins without change.
I think it's better to leave a "header" as before.

 

The old variable is misleading and needed to be changed.  Given the other changes in the new VirtualKeyBoard required changes to skins anyway I felt this was an appropriate time to make this correction.  Unless someone starts implementing fixes then these sorts of issues will never get fixed.

 

I am disappointed that not all developers and skin maintainers are reading the instruction I wrote to help with the update.  If my instructions are followed then there should not be any crashes or issues.  I have also been actively helping and supporting anyone who has asked for assistance with the change.

Regards,
Ian.

[IanSav]

Hi Bizr and Zeros,

 

 

We have an old-type mobile with keyboard Sony Ericsson W715. I will try to rip in tomorrow how Estonian language has been presented there. The main characters are the letters õ,ä,ö,ü,š,ž, what are missing, If we are talking about Estonian SMS type keyboard.

 

As you can see on the screenshot in my previous post, I've added ä,õ, ö, š, ü, ž letters in my version;
if you'd like to test on your stb, NumericalTextInput.py with Estonian layout added attached...

 

 

If this Estonian layout is okay with Zeros as well then I would like to use it in my new NumericalTextInput.  The code is quire different now and I am still checking to make sure it will be a drop in replacement for the existing code.

 

Regards,

Ian.

[Taapat]

@IanSav copying the same buttons in different skins is not an improvement.

It is unnecessary waste of resources.

 

I paid attention to your changes after a user complained that he did not run Virtual Keyboard in my plugin youtube.

 

And I see that the reason is not my plugin but his skin.

 

I myself before have changed the buttons in enigma screens and broke many skins, but I did not see another way to display the buttons correctly.

 

In this case, I see that can maintain compatibility, and also spend less resources, and it seems to me that your changes are not optimal.

[IanSav]

Hi Taapat,

 

I fully agree that the distribution of images is not optimal.  Unfortunately there is currently no mechanism within OpenPLi to properly address this problem.  If/When we can get consensus on how SCOPE_CURRENT_SKIN can be changed to resolve these issues then we can move to cleaning up the VirtualKeyBoard images and probably a lot more.

 

I would like to be able to improve and fix everything at once but unfortunately that is not possible. 

 

Please spread the word to all skin maintainers to have a read of the documentation and adjust their skins accordingly.  If anyone needs help then get them to come here and ask.  I will be happy to help.

 

Regards,

Ian.

Edited by IanSav, 25 August 2018 - 17:44.

[Taapat]

But why you want to use exactly resolveFilename(SCOPE_CURRENT_SKIN, "buttons/... ?

If you feel that the buttons are not correctly placed directly in skin_default, ok place them in skin_default/buttons and use resolveFilename(SCOPE_CURRENT_SKIN, "skin_default/buttons/..

 

But I think it's wrong specially create a GSOD for incompatible skins.

[IanSav]

Hi Taapat,
 

But why you want to use exactly resolveFilename(SCOPE_CURRENT_SKIN, "buttons/... ?

I do this because I don't want to create a complete and utter mess in the skin directory.  I believe that the images within a skin should be organised into some sort of meaningful structure.
 

If you feel that the buttons are not correctly placed directly in skin_default, ok place them in skin_default/buttons and use resolveFilename(SCOPE_CURRENT_SKIN, "skin_default/buttons/..
 
But I think it's wrong specially create a GSOD for incompatible skins.

 

Why hard code odd paths into the resolver.  The resolver should be able to use its own logic to find the required image files.  The OpenViX and Beyonwiz images have some logic in their resolver to do this for you.  I think this idea could and should be used and improved upon within OpenPLi's resolver.  See my and Littlesat's earlier comments for some of the ideas being considered.

 

Regards,
Ian.

Edited by IanSav, 25 August 2018 - 18:21.

[Taapat]

Why do you think it's odd paths?

In my opinion, SCOPE_CURRENT_SKIN means that the current skin is used first. But if there is no such image then it is used from skin_default.

skin_default means that there are already images by default and you can use them or replace them in your skin.

Folder buttons (without skin_default) means that these images are used only in this skin and nowhere else.

 

P.S.

I am writing so much here because I think it would be better to discuss this and find a solution for everyone, not just change it as it seems right to me.

[IanSav]

Hi Taapat,

 

Can you please provide a sample list of folders where you believe skin components should go.  Then describe how an image is to be found within that list of directories.  I would also like to see how you handle images that belong to skins of different resolutions.

 

Please excuse me if I don't make any more posts tonight.  It is a 04:00 in the morning here and I really need to get some sleep.  I will look at your post and respond when I awake.

 

Regards,

Ian.

[Taapat]

@IanSav no problem, answer when you will be comfortable.

 

I think that everything is right now in most cases.

In enigma, by default is HD skin support. Screens in skin_default.xml and the buttons used are for HD skins.

All the necessary images are located in the folder skin_default and its subfolders.

This allows screens to operate without the GSOD, even if such a screen is not in your skin.

 

If you want to change an image then replace it with your in the skin_default folder in your skin.

If you are using FullHD or UHD skin, you may need to replace all images.

But the skin_default folder in your skin specifies that you replace the existing images.

 

The next question.

What means "Title should only be used for screen titles!"? https://github.com/O...KeyBoard.py#L41

For example, I'm in my plugin youtube use the title to display the text there: https://github.com/T...beSearch.py#L21

In the header (or prompt after the changes) I am displaying suggestions.

Now it's no longer possible use the title because you have removed the self.setTitle .

 

It seems to me that you made this change only for your skins and your images, without considering that VirtualKeyBoard can be used differently.

 

Edited by Taapat, 25 August 2018 - 19:38.