Jump to content


Photo

Multituner: First commits - but they need a lot of improvements


  • Please log in to reply
318 replies to this topic

Re: Multituner: First commits - but they need a lot of improvements #261 MCelliotG

  • Senior Member
  • 443 posts

+35
Good

Posted 25 March 2019 - 13:56

I see the changes stick now after restarting E2 or rebooting. I love the Combined description as well.



Re: Multituner: First commits - but they need a lot of improvements #262 littlesat

  • PLi® Core member
  • 57,257 posts

+702
Excellent

Posted 25 March 2019 - 15:00

I takes a longer time before we found out combined for that...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Multituner: First commits - but they need a lot of improvements #263 Huevos

  • PLi® Contributor
  • 4,706 posts

+167
Excellent

Posted 25 March 2019 - 20:13

Attached File  1.jpg   82.69KB   1 downloads

 

That is the default config for a satellite tuner. Can it be changed so the default "Configuration mode" is "nothing". And so default "mode" is "single".



Re: Multituner: First commits - but they need a lot of improvements #264 Abu Baniaz

  • PLi® Contributor
  • 2,514 posts

+64
Good

Posted 25 March 2019 - 20:49

Can we also remove the "equal to"?

Re: Multituner: First commits - but they need a lot of improvements #265 littlesat

  • PLi® Core member
  • 57,257 posts

+702
Excellent

Posted 25 March 2019 - 20:51

Simple was always the default... and disable tuner is not something you defaultly should do (I think). When you have a tuner you wanna use it isn’t? And then most likely in a simple config.
Default mode single is indeed an option but in the Netherlands a dual lnb (19.2 + 23.5) is most standard... So should we do this change to single... the we also can consider quad. AutoDiseqc finds the most used satellites and when we have one, two, three or four sats they are always found...
Equal to has added value... and is different from connected to.

Edited by littlesat, 25 March 2019 - 20:58.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Multituner: First commits - but they need a lot of improvements #266 Abu Baniaz

  • PLi® Contributor
  • 2,514 posts

+64
Good

Posted 25 March 2019 - 23:03

Equal to has added value...

Any time I've seen "equal to" used over various forums, it has been used incorrectly. This is why the request was made.

Re: Multituner: First commits - but they need a lot of improvements #267 littlesat

  • PLi® Core member
  • 57,257 posts

+702
Excellent

Posted 25 March 2019 - 23:24

How is it used incorrectly?

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Multituner: First commits - but they need a lot of improvements #268 Abu Baniaz

  • PLi® Contributor
  • 2,514 posts

+64
Good

Posted 25 March 2019 - 23:33

People not knowing that it means exactly the same as the other tuner.

Oddly, you can select it for FBC tuners. It shouldn't be possible as FBC tuners must have different SCR specified.

Re: Multituner: First commits - but they need a lot of improvements #269 Abu Baniaz

  • PLi® Contributor
  • 2,514 posts

+64
Good

Posted 25 March 2019 - 23:41

People not knowing that it means exactly the same as the other tuner.

Oddly, you can select it for FBC tuners. It shouldn't be possible as FBC tuners must have different SCR specified.

Correction, it can be used provided it isn't SCR.

Re: Multituner: First commits - but they need a lot of improvements #270 littlesat

  • PLi® Core member
  • 57,257 posts

+702
Excellent

Posted 25 March 2019 - 23:55

You cannot only do scr here... for committed/uncommitted switches it is easy...
Then you mean when you select equal to you should not have scr available? Or still allow somehow to select the scr ‘channel/frequency separately? Maybe we should no get that far?
At this moment I have no idea how to ‘hide’ the equal to in this situation...
Fbc musn’t Have Jess/unicable... they may have ;)

Edited by littlesat, 25 March 2019 - 23:57.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Multituner: First commits - but they need a lot of improvements #271 Abu Baniaz

  • PLi® Contributor
  • 2,514 posts

+64
Good

Posted 26 March 2019 - 00:06

Don't worry, "equal to" works fine when used correctly. Was just trying to remove an item that is misunderstood by many people.

Incorrect approach.

Sent from my Moto G (5S) using Forum Fiend v1.3.3.

Re: Multituner: First commits - but they need a lot of improvements #272 littlesat

  • PLi® Core member
  • 57,257 posts

+702
Excellent

Posted 26 March 2019 - 07:49

Thanks... as I also prefer not to adapt any code for now just before we try to release 7.1.
What can be done is only add the option equal to only when there are tuners available without Jess/unicable. Might be not that difficult.

Edited by littlesat, 26 March 2019 - 07:53.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Multituner: First commits - but they need a lot of improvements #273 Abu Baniaz

  • PLi® Contributor
  • 2,514 posts

+64
Good

Posted 28 March 2019 - 22:32

There is a crash when pressing OK in tuner configuration when you do not have any tuners. I tested this on a Duo 4K with no tuners inserted.
 
Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 49, in action
  File "/usr/lib/enigma2/python/Screens/Satconfig.py", line 764, in okbuttonClick
AttributeError: 'NoneType' object has no attribute 'slot'

Attached Files



Re: Multituner: First commits - but they need a lot of improvements #274 littlesat

  • PLi® Core member
  • 57,257 posts

+702
Excellent

Posted 28 March 2019 - 23:59

Maddness... I also suggest not combined/hotswitchable related... but I guess it is configuered with nothing in slofs... maybe solved with sanity check in that line...
But how did you het there in the first place without having tuners insertted?
I suggest this is in the NIM selection screen where you do not see any tuners and then click ok... suggest sanity check should solve the gsod. Or even more better do not show the tuner list af all when there are no tuners... so add something in menu.xml or so with conditional or so that arrange the option is not shown... when there are no tuners there is no need to select one and config one...

Edited by littlesat, 29 March 2019 - 00:09.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Multituner: First commits - but they need a lot of improvements #275 Abu Baniaz

  • PLi® Contributor
  • 2,514 posts

+64
Good

Posted 29 March 2019 - 00:19

Someone's tuner went faulty and going in tuner configuration resulted in a crash. I checked and could reproduce it.

If you make tuner config conditional, I hope sundtek tuner config is still accessible.

Re: Multituner: First commits - but they need a lot of improvements #276 littlesat

  • PLi® Core member
  • 57,257 posts

+702
Excellent

Posted 29 March 2019 - 05:37

Someone's tuner went faulty and going in tuner configuration resulted in a crash. I checked and could reproduce it. -> sorry I do not understand
When sundtek reports as tuner that should not be an issue

Edited by littlesat, 29 March 2019 - 05:38.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Multituner: First commits - but they need a lot of improvements #277 zeros

  • PLi® Contributor
  • 1,635 posts

+61
Good

Posted 29 March 2019 - 05:39

Here all OK so far, thanks all involved!
I made a small video as well from current state.
dm920 Enigma version 2019-03-29 (develop)

DM920UHD DVB-S2X TRIPLE tuner + Triple M.S tuner DVB-S2X, DVB-T2/T, QboxHD, QboxHD Mini, Icecrypt T2300HD,
Qviart Lunix3 4K, Raspberry Pi 4 Model B 4GB & 8GB

Vertex 4K60 4:4:4 600MHz


Re: Multituner: First commits - but they need a lot of improvements #278 littlesat

  • PLi® Core member
  • 57,257 posts

+702
Excellent

Posted 29 March 2019 - 05:46

Sounds due to the changes chalanges are discovered...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Multituner: First commits - but they need a lot of improvements #279 Huevos

  • PLi® Contributor
  • 4,706 posts

+167
Excellent

Posted 29 March 2019 - 08:44

Someone's tuner went faulty and going in tuner configuration resulted in a crash. I checked and could reproduce it. -> sorry I do not understand
When sundtek reports as tuner that should not be an issue

@Littlesat, what he is saying is if you are in the NimSelection screen and there are no Nims to select, and you press OK to select a Nim, that will result in a BSoD. So there needs to be a sanity test to prevent that. No idea if that is related to the "HotSwitch" code. I doubt it.



Re: Multituner: First commits - but they need a lot of improvements #280 arn354

  • Senior Member
  • 146 posts

+12
Neutral

Posted 29 March 2019 - 10:45

https://github.com/t...ped_q=hasTuners

 

i simply removed the whole menu entries using SystemInfo["hasTuners"]




38 user(s) are reading this topic

0 members, 38 guests, 0 anonymous users