For people willing to improve translation the po files are updated for this plugin:
https://github.com/O...python3/imdb/po
154 replies to this topic
Re: IMDB plugin issues #141
-
- PLi® Contributor
- 6,179 posts
+261
Excellent
Posted 27 July 2023 - 11:32
NO SUPPORT by PM, it is a forum make your question public so everybody can benefit from the question/answer.
If you think that my answer helps you, you can press the up arrow in bottom right of the answer.
Wanna help with OpenPLi Translation? Please read our Wiki Information for translators
Sat: Hotbird 13.0E, Astra 19.2E, Eutelsat5A 5.0W
VU+ Solo 4K: 2*DVB-S2 + 2*DVB-C/T/T2 (used in DVB-C) & Duo 4K: 2*DVB-S2X + DVB-C (FBC)
AB-Com: PULSe 4K 1*DVB-S2X (+ DVB-C/T/T2)
Edision OS Mio 4K: 1*DVB-S2X + 1*DVB-C/T/T2
Re: IMDB plugin issues #143
-
- PLi® Core member
- 70,431 posts
+1,808
Excellent
Posted 13 November 2024 - 14:56
Brillant, thanks !
Can you provide a pull request on github, so your name is linked to the fix ?
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Re: IMDB plugin issues #144
-
- Senior Member
- 218 posts
+13
Neutral
Re: IMDB plugin issues #145
-
- PLi® Core member
- 70,431 posts
+1,808
Excellent
Posted 13 November 2024 - 16:53
Any particular reason why you replaced tabs by spaces? Makes the diff larger than it needs to be.
And also, I see you've introduced Python six, and added PY2 checks. Which this code is Python3 only, so those are not needed?
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Re: IMDB plugin issues #146
-
- Senior Member
- 218 posts
+13
Neutral
Posted 13 November 2024 - 16:58
Any particular reason why you replaced tabs by spaces? Makes the diff larger than it needs to be.
And also, I see you've introduced Python six, and added PY2 checks. Which this code is Python3 only, so those are not needed?
you can update to your version if you want, the tabs for python are not styled, it gives me an error
W191 indentation contains tabs [pycodestyle]
You can remove six if you want.
Edited by pzanone, 13 November 2024 - 17:04.
Re: IMDB plugin issues #147
-
- Senior Member
- 218 posts
+13
Neutral
Posted 13 November 2024 - 17:23
i revert change in commit and fixed
Re: IMDB plugin issues #148
-
- PLi® Core member
- 70,431 posts
+1,808
Excellent
Posted 13 November 2024 - 17:58
I don't understand your changes.
You've changed "six.PY2" to "PY2", but the check and the Python2 code is still there?
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Re: IMDB plugin issues #149
-
- Senior Member
- 218 posts
+13
Neutral
Posted 13 November 2024 - 20:32
WanWizard
I don't care if my name comes out, I don't care, do as you think, every time I make a fix, it seems like World War 3 is coming
Don't worry. Do as you decide.. Greetings
Re: IMDB plugin issues #150
-
- PLi® Core member
- 70,431 posts
+1,808
Excellent
Posted 13 November 2024 - 20:40
I'm just asking simple questions?
You add code to a python3 specific file, in a python3 branch, and your code is explicitly made compatible with python2. You also moved imports around without no appearent reason, and made other changes not related to the parsing issues, instead of sticking to the "one change per commit" rule.
Why can't I ask about the reasoning behind that, as it makes the diff very difficult to read, just adds unneeded bloat and will make future maintenance more complicated?
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Re: IMDB plugin issues #151
-
- PLi® Contributor
- 4,647 posts
+162
Excellent
Posted 14 November 2024 - 01:32
+1
Another person incapable of atomic commits.
Is this a copy and paste from elsewhere?
Edited by Huevos, 14 November 2024 - 01:33.
Re: IMDB plugin issues #152
-
- Senior Member
- 218 posts
+13
Neutral
Posted Yesterday, 18:59
+1
Another person incapable of atomic commits.
Is this a copy and paste from elsewhere?
Then why didn't you fix this problem?
Incapable.. bha.. regards
Re: IMDB plugin issues #153
-
- PLi® Core member
- 70,431 posts
+1,808
Excellent
Posted Yesterday, 21:28
Let's keep things friendly here, please? Both of you...
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Re: IMDB plugin issues #154
-
- PLi® Contributor
- 4,647 posts
+162
Excellent
Posted Yesterday, 21:31
+1
Another person incapable of atomic commits.
Is this a copy and paste from elsewhere?
Then why didn't you fix this problem?Incapable.. bha.. regards
Just make atomic commits so the commit is readable, not all the unnecessary changes. And if the code is copy and pasted from elsewhere say so.
Re: IMDB plugin issues #155
-
- PLi® Core member
- 70,431 posts
+1,808
Excellent
Posted Yesterday, 21:33
I have no issues with ordering imports or other code cleanups as such (on the contrary, cleanup is always good).
I do have an issue with including those in an otherwise unrelated commit.
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Also tagged with one or more of these keywords: imdb plugin, imdb, plugin
Missing Softcams PluginStarted by MifPT, 12 Jan 2024  softcams, Plugin and 1 more...
|
|
|
||
openpli 9 and Xtream pluginStarted by frossie, 10 Dec 2023 plugin
|
|
|
||
Advanced transcoding setupStarted by Dimitrij, 14 May 2022 plugin
|
|
|
||
Plugin - Power LNB/ToneBurst in standby for FBC tunersStarted by Dimitrij, 6 Apr 2022 plugin
|
|
|
||
Streamlink [-27] InstallerStarted by dreamboxco, 2 Apr 2021 IPTV, Streamlink, Plugin and 2 more...
|
|
|
25 user(s) are reading this topic
0 members, 25 guests, 0 anonymous users
