154 replies to this topic

[Pr2]

For people willing to improve translation the po files are updated for this plugin:

 

https://github.com/O...python3/imdb/po

[pzanone]

iMDb has been acting up for a long time.

I fixed a few things and it works now

tested on pli9.x

 

 

Attached Files

•  plugin.py   74.79KB   5 downloads

[WanWizard]

Brillant, thanks !

 

Can you provide a pull request on github, so your name is linked to the fix ?

[pzanone]

Major Fix · Belfagor2005/enigma2-plugins-1@5e39b3b

[WanWizard]

Any particular reason why you replaced tabs by spaces? Makes the diff larger than it needs to be.

 

And also, I see you've introduced Python six, and added PY2 checks. Which this code is Python3 only, so those are not needed?

[pzanone]

Any particular reason why you replaced tabs by spaces? Makes the diff larger than it needs to be.

 

And also, I see you've introduced Python six, and added PY2 checks. Which this code is Python3 only, so those are not needed?

you can update to your version if you want, the tabs for python are not styled, it gives me an error

 

 W191 indentation contains tabs [pycodestyle]

 

You can remove six if you want.

Edited by pzanone, 13 November 2024 - 17:04.

[pzanone]

i revert change in commit and fixed

[WanWizard]

I don't understand your changes.

 

You've changed "six.PY2" to "PY2", but the check and the Python2 code is still there?

[pzanone]

WanWizard

 

I don't care if my name comes out, I don't care, do as you think, every time I make a fix, it seems like World War 3 is coming

Don't worry. Do as you decide.. Greetings

[WanWizard]

I'm just asking simple questions?

 

You add code to a python3 specific file, in a python3 branch, and your code is explicitly made compatible with python2. You also moved imports around without no appearent reason, and made other changes not related to the parsing issues, instead of sticking to the "one change per commit" rule.

 

Why can't I ask about the reasoning behind that, as it makes the diff very difficult to read, just adds unneeded bloat and will make future maintenance more complicated?

[Huevos]

+1

 

Another person incapable of atomic commits.

 

Is this a copy and paste from elsewhere?

Edited by Huevos, 14 November 2024 - 01:33.

[pzanone]

+1

 

Another person incapable of atomic commits.

 

Is this a copy and paste from elsewhere?

Then why didn't you fix this problem?

Incapable.. bha.. regards

[WanWizard]

Let's keep things friendly here, please? Both of you...

[Huevos]

 

+1

 

Another person incapable of atomic commits.

 

Is this a copy and paste from elsewhere?

Then why didn't you fix this problem?

Incapable.. bha.. regards

 

Just make atomic commits so the commit is readable, not all the unnecessary changes. And if the code is copy and pasted from elsewhere say so.

[WanWizard]

I have no issues with ordering imports or other code cleanups as such (on the contrary, cleanup is always good).

 

I do have an issue with including those in an otherwise unrelated commit.