2041 replies to this topic

[kamaxx]

@DimitarCC;

 

There has been squeezing lines on Skin.xml file in Version0.9.3.

 

I changed some files of yours  including old skin.xml and .py file without error into v0.9.3.

 

Multiboot works but just squeezing like the followings. No matter how it is.

 

 

 

  

Attached Files

•  PLi-DarkOS Vx.x.x.rar   3.22MB   9 downloads
•  4.jpg   79.8KB   2 downloads

[DimitarCC]

@kamaxx
The problem is that you need the new skin.xml.

In the last zip that i attached here everything is working and should be no line squeeze.

[Abu Baniaz]

@littlesat,

I have pushed the files here: https://github.com/A...11f08f4a455b2f1

Would be better to get them from DimitarCC's repository. https://github.com/D...OpenPLi-enigma2

 

@DimitarCC. quite a few of those files were in windows file system. Can you please convert to unix for next upload please? 

[kamaxx]

@DimitarCC;

 

You are right for last skin.xml.  So many files corrupted

 

Could you please look at permanent clock in last skin.xml?

 

I extracted within 3 lines. Now No permanent clock.

Under this line

 <screen name="ClockScreen" position="center,30" size="235,55" zPosition="-1" backgroundColor="transparent" title="Clock" flags="wfNoBorder">

   <widget render="Label" position="1,1" size="180,55" backgroundColor="transparent" transparent="1" zPosition="0" foregroundColor="orange" font="Bold;50" valign="center" halign="right" borderWidth="2" borderColor="black" source="global.CurrentTime">
      <convert type="ClockToText">%H:%M</convert>
    </widget>

Edited by kamaxx, 3 October 2023 - 22:29.

[littlesat]

That is a hell of a diff…. Not easy to merge and see the real differences. And it also reverts some stuff… and it makes stuff more complicated with hardcoded colors in a quickview.

for permanent clock we have a plug-in why not using that one? Then you have a real option to turn it on/off and set the location etc….

keeping this renderer out of the skin it what I strongly recommmend.

Edited by littlesat, 4 October 2023 - 07:05.

[DimitarCC]

@littlesat,

I have pushed the files here: https://github.com/A...11f08f4a455b2f1

Would be better to get them from DimitarCC's repository. https://github.com/D...OpenPLi-enigma2

 

@DimitarCC. quite a few of those files were in windows file system. Can you please convert to unix for next upload please? 

 

OK. i made it easier for you if you ever consider merging that in the PLi code.

I made a PR https://github.com/O...igma2/pull/3785

[littlesat]

Changing 1500+ lines of code for just a skin is what we should not do…. Also with relative high risk breaking other stuff and the code has also in my quickview not a real good quality. Then better not support this skin or adapt the skin. Better look for features what are really needed and adapt for those (one by one). I do not feel good to merge this sorry.

Edited by littlesat, 4 October 2023 - 07:16.

[DimitarCC]

I have expected this answer. Its up to you ofcource. I dont push anyone to support my skin. In my opinion PLi stays archaic regarding skin designs. But that is my opinion ofcource.

Different people different ideals.

 

I have not intended ever to request that to be merged in PLi, but because @Abu Baniaz requested it and i made the PR. So guys do what you want

 

@littlesat Well i dont want to argue about the quality of the code since i have made it step by step and probably need a lot of optimisations. But if you was wanted to ever consider this to be merged then ofcource the code can be looked deeper and optimised. We all know you are too picky about any kind of changes

Edited by DimitarCC, 4 October 2023 - 07:29.

[DimitarCC]

New version of the skin for anyone willing to download and use.

 

- [Fixed] Problem with multiboot menu entry

 

 

Attached Files

•  PLi-DarkOS v0.9.4.zip   3.49MB   26 downloads

[DimitarCC]

 

@DimitarCC;

 

You are right for last skin.xml.  So many files corrupted

 

Could you please look at permanent clock in last skin.xml?

 

I extracted within 3 lines. Now No permanent clock.

Under this line

 <screen name="ClockScreen" position="center,30" size="235,55" zPosition="-1" backgroundColor="transparent" title="Clock" flags="wfNoBorder">

   <widget render="Label" position="1,1" size="180,55" backgroundColor="transparent" transparent="1" zPosition="0" foregroundColor="orange" font="Bold;50" valign="center" halign="right" borderWidth="2" borderColor="black" source="global.CurrentTime">
      <convert type="ClockToText">%H:%M</convert>
    </widget>

 

yes. That's the right thing to do if you want to remove the clock. I had a plan that to be configurable but is pointless since as you can see the skin and extensions will mainly stay for enthusiasts that know what they are doing 

Edited by DimitarCC, 4 October 2023 - 08:04.

[DimitarCC]

Changing 1500+ lines of code for just a skin is what we should not do…. Also with relative high risk breaking other stuff and the code has also in my quickview not a real good quality. Then better not support this skin or adapt the skin. Better look for features what are really needed and adapt for those (one by one). I do not feel good to merge this sorry.

 

OK. well i am also have a feeling everything suggested have been rejected here....But OK because i really like to help all users out there let me break the code function by function and will write a thread in the relevant forums

[WanWizard]

I agree a blanket merge is probably a bad idea, but that doesn't mean it is an all or nothing.

 

There are quite a few things in there that don't collide (for example additional renderers) and maybe only need a code check.

 

Other changes need to be checked for their impact, and whether they are really needed or not. I see for example that enum values are replaced by hardcoded values, that's a no-no. Is that deliberate or because the diff was based on old code or code from another image?

[DimitarCC]

Additional renderers are very very small part of the whole modifications. Most of the modifications are in the UI (skinning engine). And ofcource the change for IPTV track selection from the other thread.

About the enum even in the lates OpenPLi code there are not variables for all the values in that enum and it was meant to be a extended enum with additional service type that can support dynamic m3u lists directly in the bouquets.

Anyway that part of the code is not here and is not relevant to the skin.

 

I will be glad if at least some of the stuff are merged but lets be blunt Renderesrs can not work alone to make the skin looks like it is now. There is need of UI changes if you want OpenPLi to be on track with latest design recommendations.

 

Nowdays users want a modern look, but OpenPLi has stuck in last century seems.

[WanWizard]

Nowdays users want a modern look, but OpenPLi has stuck in last century seems.

 

I can only agree with that.

[luisteraar]

Nowdays stb's with userinterface is out of time.

In time of smart tv's the tv does the work.

In my enviroment the master stb is always in standby.

Mij tv's are working directly with the master stb via stream.

[DimitarCC]

Well many people use TVs but the users of STBs now days want UI to look modern. Actually that demand of the users for modern look is not only for STBs but for TVs as well.

However for TV is almost not possible to change the look. What comes from manufacturer that's it.

Here there is a chance to get modern look and i think we have to take advantage of it.

[Abu Baniaz]

Just for info, the pager stuff has been added to Vix.

It is always catch 22 when it comes to new features in skins. Don't add python files to skin/don't change system files vs we won't add the feature/function because we don't use it.

Edited by Abu Baniaz, 4 October 2023 - 15:56.

[DimitarCC]

Yes ofcource i know about ViX. They are more open for that kind of stuff.

[DimitarCC]

As i promised all needed for my skin is in that 2 PRs

 

https://github.com/O...igma2/pull/3787

 

https://github.com/O...igma2/pull/3788

 

I think there are not drastic changes nor slowdowns by the code added or changed.

Will be good to consider it. Thanks.

[DimitarCC]

Just for info, the pager stuff has been added to Vix.

It is always catch 22 when it comes to new features in skins. Don't add python files to skin/don't change system files vs we won't add the feature/function because we don't use it.

By the way pager stuff are in PLi as well

Edited by DimitarCC, 4 October 2023 - 17:13.