2041 replies to this topic

[WanWizard]

No, And my point is that that is inherently wrong, and a result of bad design.

 

If skins need code to achieve specific functionality, that code should be an integral part of the skin, and not global to the image. For the same reason that if a plugin needs code, it is part of the plugin, and not added to the image.

 

The only reason for this discussion is that CURRENTLY the skin system is poorly designed and doesn't support that, other than through the very bad XML hack, and nobody can be bothered to improve the bad design.

 

And to make matters worse, the design is made on top of a lot more bad design, making stuff global instead of nicely encapsulated in for example an instantiation of a skin-type class.

 

There is so much skill in "the enigma scene", and it is all wasted on building junk on top of junk, instead of really coming together and improve what we have.

 

The only one who understood that was IanSav, and he has burned himself in about every team he offered his services to...

Edited by WanWizard, 21 December 2023 - 19:51.

[littlesat]

From the other side what the skin solution design ever is or was or will become having the same features in different skins duplicating code is also not preferable. Then they could better be included in kind of ‘libraries’.
Iansav tried to make it better, but while doing this with good intentions it also breaks the spaghetti and then a lot of efforts were needed to get things fixed. And also he did never change the situation how skins rely on python code and also cpp code… while for user interfaces there are much better solutions.

Edited by littlesat, 21 December 2023 - 20:25.

[Huevos]

Well but for brand is used MACHINE_BRAND which output the same value. Actually that is used in the code and now we will have difference and/or ambigous code.
Unfortunately there is no other suitable value that can be used to determine the brand...

 
This was all discussed before OE-A went ahead without bothering with any of it.
 
I tried (but obviously failed in some cases) to duplicate OE-A's values, but they are really all over the place, the person defining all those must have been absolutely shitfaced!
 
Brand in general is all over the place, sometimes it is the OEM brand, sometimes the Retail brand, sometimes the MACHINE is defined in an OEM brand meta layer, sometimes it is scattered over different onces (for example nextv, an OEM supplier, can be found in at least 5 different places. Sometimes it is lower case, sometimes uppercase, sometimes mixed case.
 
It was an absolutely nightmare to get to this point...
 
I'll wait until a full build run has finished so I can review all values at once, I've already seen some others that are off too...

neo I am not what you mean. The display names in OE-A metas are not invented. They were supplied by the manufactures to OE-A more than 10 years ago.

[neo]

I think you've missed the essense of what I wrote, if that is what you take away from it .

 

Anyway, the develop builds are back on track, now comes the arduous task of dubblechecking all values.

Edited by neo, 22 December 2023 - 11:59.

[littlesat]

I'm busy with the parser.... So I scan as usual on exceptions...

 

I see the part of code in openvix. Is this done for foreign images who did not follow the rules by adding ' or " before these values in enigma.info? I hope we both at least but these values in the enigma.info file between ' or "?

# Temporary fix: some items that look like floats are not floats and should be handled as strings, e.g. python "3.10" should not be processed as "3.1".
if not (value.startswith("\"") or value.startswith("'")) and item in ("python", "imageversion", "imgversion"):
value = '"' + value + '"'  # wrap it so it is treated as a string

Edited by littlesat, 22 December 2023 - 12:57.

[WanWizard]

Maybe helpful for test purposes, the enigma.info files for all boxes we build an image for.

Attached Files

•  enigma-info.zip   81KB   3 downloads

[WanWizard]

Does anyone know how to contact someone from ATV with access to their build environment?

 

OE-A creates a copy of the enigma.info file for every box in the build/tmp/deploy directory, it would be a lot easier to verify our results if we could have a copy of those files so we can do a diff...

[Huevos]

@neo, I am working on getting you a copy of the text files from openvix (60 boxes). Not a simple task.

[40H3X]

Why is the marked section twice in the About?

Attached Files

•  About-Page 1.jpg   87KB   1 downloads
•  About-Page 2.jpg   89.97KB   1 downloads

[Tech]

It is not displayed twice but shows the next page with info, probably not applicable to you, but for me it scrolls to the next lines of information.

 Scherm­afbeelding 2023-12-22 om 14.27.38.png   315.49KB   1 downloads  Scherm­afbeelding 2023-12-22 om 14.27.56.png   290.32KB   1 downloads

[littlesat]

It indeed scrolls to the bottom and you still see the 'top' part.... this was always the case as far I know but it is not anywhere in enigma2 that way... You suggest show a next page with only new information and then on the second page leave the bottom empty.

[40H3X]

Aha to me not the most logical interpretation of the two bullets below. IMHO the 2 bullets below suggest there are 2 pages.

[littlesat]

Yep... welcome in the world of E2...

 

For me it can be changed to two pages... if possible...

[40H3X]

[Pr2]

It is may be the opportunity to reorganised a little bit the order of the information in this screen.

 

According to me the IP address is an information that should always be displayed on the 1st page, I mostly use this screen to quickly find the IP address assigned to a DHCP configured box.

And on top there are information that I think most of us don't really care about, the second info block:

 

kernel version

...

Skin & Resolution

 

Can be moved below (or on the second page).

 

So keep the Hardware and image version on top

Followed by the Tuner information and disk information

Then the Network info block

The HDMi-CEC

And finally the current second block of information

[Huevos]

Aha to me not the most logical interpretation of the two bullets below. IMHO the 2 bullets below suggest there are 2 pages.

Well that is scrollable so 2 bullet means > 1 page and <= 2 pages.

[WanWizard]

I think the assumption is that if there is a page shows 20 lines, and their are 30 lines of output, page 2 shows the remaining 10, not the last 20 (of which the first 10 where also on the previous page).

 

Not a show stopper, but I can see it may be confusing for users.

[Pr2]

Other points about this skin the WAF (Woman Acceptance Factor) is not very high mainly due to the Graphical Multi EPG  (GMEPG)

 

1) The colors in the GMEPG are confusing, the current cursor is grey while the currently playing channels are green. So the highlighted current cursor is less visible than the other info in the screen.  When we browse the EPG this greyed area is hard to find, It would be better to have in blue to really saw it immediately (especially when it is on very small program). The current cursor position should always be clearly visible, and it's not the case with the current choosed colors.

The OpenPLi default skin GMEPG looks far better and cleared than this version.

 

2) I use a lot the menu button in the channel list, especially to open up PiP channels and set the Zap focus on PiP (or move the PiP windows).  In the contextual menu the color button respect the graphical chart of the skin, so the shortcut for the color buttons are displayed as a colored thin vertical line, I think that keeping a big color button in the contextual menu is better than displaying this thin vertical color line. It can be hard to see and understand for end-user because it's not really visible and its not aligned with the numerical possible shortcut.

[40H3X]

I think the assumption is that if there is a page shows 20 lines, and their are 30 lines of output, page 2 shows the remaining 10, not the last 20 (of which the first 10 where also on the previous page).

 

Not a show stopper, but I can see it may be confusing for users.

That was point I wanted to make

[Huevos]

Does anyone know how to contact someone from ATV with access to their build environment?

 

OE-A creates a copy of the enigma.info file for every box in the build/tmp/deploy directory, it would be a lot easier to verify our results if we could have a copy of those files so we can do a diff...

See the attached zip.

Attached Files

•  openatv-7.3-enigma-info.zip   271.78KB   9 downloads