2041 replies to this topic

[littlesat]

Likely we only to made changes to one class in InfoBarGenerics...

 

class InfoBarStreamRelay

 

Arrange that in the whitelist we only compare the 'pure' reference without the renaming and also store it without the renaming and arrange that to navigator the reference is correctly manipulated.

[littlesat]

Solution will be pushed soon... Thanks for mentioning it... but is is not skin related....

[littlesat]

FYI https://github.com/O...1786240494c4bc9

 

And you're right.... (unless it was not skin related).... And weird that other images did not report this yet... Sounds like renaming is not used that much....

Edited by littlesat, 26 March 2024 - 16:46.

[DimitarCC]

So tuners string added to the dynamic service info bar (+ small visual extension for rendering MultiTextContent).

 

https://github.com/O...igma2/pull/3932

[littlesat]

Merged....

 

I did check for the CI 'reporting' but as far I can see on a VU+ it seems not to work.... But the commit was from the 15th and I merged it later... so maybe it was not in yet.

[DimitarCC]

I did check for the CI 'reporting' but as far I can see on a VU+ it seems not to work.... But the commit was from the 15th and I merged it later... so maybe it was not in yet.

 

It was not really working in that commit. It was fixed with that PR (add more stuff though). But not merged yet.

 

https://github.com/O...nigma2/pull/999

 

Keep in mind ViX have CI stuff integrated and i think PLi doesnt have that....

Edited by DimitarCC, 26 March 2024 - 17:37.

[DimitarCC]

P.S. can you fix the last PR? It doesnt build due to unused parameter (it too time consuming to prepare a new PR )

 

error is 

gui/elistboxcontent.cpp:1040:6: error: variable ‘border_size’ set but not used [-Werror=unused-but-set-variable]

Edited by DimitarCC, 26 March 2024 - 17:40.

[littlesat]

These commits are on the openvix's github... Sorry when it is in cpp I have to pass at this moment.

Edited by littlesat, 26 March 2024 - 17:42.

[DimitarCC]

These commits are on the openvix's github... Sorry when it is in cpp I have to pass at this moment.

 

Are you talking about the CI reporting stuff? If you like then i can prepare a equivalent pull in PLi...Or at least i can try....

Or you mean something else?

[DimitarCC]

P.S. i see you have merged most of the things....Only one thing is missing.. let me add it in a PR....

[littlesat]

Thanks!

[DimitarCC]

Here it is https://github.com/O...igma2/pull/3933

Edited by DimitarCC, 26 March 2024 - 17:58.

[fariden]

great

[fariden]

great thanks

[littlesat]

Thanks great... the job did complete... we have back a green V

 

https://github.com/O...job/23115581794

[DimitarCC]

Thanks great... the job did complete... we have back a green V

https://github.com/O...job/23115581794

[40H3X]

In noticed that in the Mountpoints management, there are no buttons there, so there should be Red=Close and Yellow=Delete mount

I bring this to mind again.

[DimitarCC]

In noticed that in the Mountpoints management, there are no buttons there, so there should be Red=Close and Yellow=Delete mount

I bring this to mind again.

Can you post a screenshot how it looks like? Its weird that buttons are not there...

[mrvica]

I remeber that one, which way does it work?

 

<ePixmap pixmap="buttons/button_blue.png" .....

 

<widget source="key_blue" render="Label".......

[DimitarCC]

I remeber that one, which way does it work?

<ePixmap pixmap="buttons/button_blue.png" .....

<widget source="key_blue" render="Label".......

E2-DarkOS have different way to render the buttons. So it must be something missing...