2018 replies to this topic

[WanWizard]

Just noticed that SNR is always displayed as a percentage, even if you have it configured in the settings to display dB's (which is the default).

[Huevos]

Just noticed that SNR is always displayed as a percentage, even if you have it configured in the settings to display dB's (which is the default).

E2-DarkOS uses converter argument "SNR" in the infobar screen. "SNR" shows % by default and dB if swapped. "SNRdB" shows dB by default and % if swapped. That works fine in ViX using E2-DarkOS (displays % by default and dB when swapped). If it is doing something different in PLi something is wrong in the converter... or you are expecting the skin to be using "SNRdB" as the converter argument.

Edited by Huevos, 17 July 2024 - 16:38.

[WanWizard]

I don't know, I didn't make it .

 

I just noticed the diffence in behavior between the default skin and DarkOS.

[Huevos]

I don't know, I didn't make it .

 

I just noticed the diffence in behavior between the default skin and DarkOS.

Which uses the other argument.

https://github.com/l...plates.xml#L389

[WanWizard]

It gets weirder.

 

I was just playing with long-OK. This moves the detailed info from the 2nd infobar to a seperate window top left when the infobar is shown. And that showed dB's. Pressed long OK a few more times to return to the standard 2nd infobar, and now it shows dB's there too.

 

/me puzzled.

[DimitarCC]

Well that seems to be some kind of issue with the converter itself...Not issue with the skin

[40H3X]

This setting is the wrong way around, meaning off it should show db, but in fact it shows SNR.

Attached Files

•  UI.jpg   74.81KB   1 downloads

[WanWizard]

I can confirm this, it is what threw me off earlier. The reason I now see dB's is because I've set the setting to show SNR % on this box,

[littlesat]

Then the wrong field is shown indeed or the 'other images' did swap this option.

[DimitarCC]

The option is to actually swap the %/dB.
The description is odd imho.
So if you use SNRdB in skin it will change it to % if you enable the option.
If you use in skin SNR if you turn that option on it will change it to dB.
So the option is actually "swap" and not in particular dB to %

[Huevos]

This setting is the wrong way around, meaning off it should show db, but in fact it shows SNR.

It is doing exactly what the argument in the skin requires, how is it "wrong"? The config option is to swap the values, yes or no. There is not a default that should be displayed. The skinner decides what the default is in their skin. Only time there is a problem is if the skinner chooses to mix the arguments throughout the skin.

[littlesat]

The option indeed swaps what the standard should be.... So when the skin describes % on a place and dB on a different location and it is OFF it does what the skin defined... when enabled it swaps both.... When the tuner itself does not support dB you see the value always in %. This was made this way >15 years ago or something like that... So do not shoot me (unless I likely made it that way at that time). Somehow during these ages someone did made the description incorrectly..... 

 

You also have a second infobar and a simple second infobar... you can toggle lower in that menu and (instantly) by holding the OK long when the infobar is shown

You can also show (if the skin supports it) an additional information 'box' on the normal infobar. This can be toggled in the menu but also (instantly) by holding the OK button when no infobar is visible at all.

Edited by littlesat, 18 July 2024 - 15:34.

[Huevos]

Yes, seems to be labelled wrong in PLi.

 

BTW, some screens even display both at the same time (and swappable).

Attached Files

•  1.jpg   81.8KB   1 downloads
•  2.jpg   81.76KB   1 downloads

[littlesat]

Sounds indeed that somebody did re-lable it not properly by not understanding what it was doing or testing it with a skin that only had one option.

[WanWizard]

It is not labeled wrong. It was added to Enigma by Pieterg over 12 years ago, and unchanged since.

 

The setting is clear, when off/no/red, dB's should be shown (and this is the Enigma default), and when on/green/yes, percentages should be shown. Afaik it has always been like this, and it works fine in FullNight-HD.

[littlesat]

The setting is clear, when off/no/red, dB's should be shown (and this is the Enigma default), and when on/green/yes, percentages should be shown. Afaik it has always been like this, and it works fine in FullNight-HD.

 

That is exactly what it is not doing.... when it is red it does dB (if the tuner supports) it where the skin wants to show dB and % where the skin want to show %... and when green it swaps those...

 

When a skin only show %... or where the skin shows % then indeed it is a %/dB switch...

 

Sorry it is a >15 year old monster... migrated from the Enigma1 time...

Edited by littlesat, 18 July 2024 - 16:31.

[WanWizard]

Yes, that is what I wrote, it doesn't do what it says it does .

 

It was added by tmbinc in 2007: https://github.com/O...53172f913a8084a and never changed in OpenVIX. So we are to blame.

 

My guess: this one? https://github.com/O...a6446ddd78cb841

[littlesat]

It is not that one... It is just the text that is wrong... This is changed later than that one.

Edited by littlesat, 18 July 2024 - 16:45.

[littlesat]

You have to search for changes made here:

https://github.com/O.../setup.xml#L103

The text/description there is wrong....

Edited by littlesat, 18 July 2024 - 16:46.

[WanWizard]

And you didn't think I did that?

The only change to the xml was made when Pieterg added it, 12 years ago. The problem isn't in the text.

 

If you look at OpenVIX, https://github.com/O...a/setup.xml#L86, you see it does exactly the same as ours: false = dB, true = %.

 

So it is definitely not the description of the setting.

 

And it is indeed also not Dima's commit, that code is in OpenVIX too.