Taapat

Looking at enigma startup log I see two errors.

The first is the same as I have already asked a pull request in skin-PLiHD.
I am using the latest libpng 1.6.12 in my SH4 receiver. I have error:

[SKIN] parsing embedded skin <embedded-in-'Screensaver'>
libpng warning: ICCP: Incorrect known sRGB profile. 

Looking at the changes in the libpng code I see that in libpng 1.6.2 has added the warnin. The error is also in earlier versions, but there's no warnin in the console.
I found that the error is due to anniversaryOpenPLi.png. I am using:

pngquant --ext .png --force 256 anniversaryOpenPLi.png
optipng -o7 anniversaryOpenPLi.png 

That so anniversaryOpenPLi.png have the correct sRGB profile and optimized.

The second error is:

[Skin] Error: {} dTV-HD-Reloaded/skin.xml: color 'secondBG' must be # Aarrggbb or valid named color. Please contact the skin's author! 

Color secondBG used in ScreenSaver and AudioSelection but not defined in my skin.
I think the colors used in the enigma, it is necessary to define in skin_default.xml. Ask to specify it in all skins in my opinion is wrong. As I understand, if it defined in the basic skin, then skin_default.xml will not be used, and will not conflict.

I attach two patch that corrects these small errors.

I also do not know C +, and therefore probably wrong, but I think in scan.cpp in isValidONIDTSID: https://sourceforge....vb/scan.cpp#l48

need to add:

case 0x0070: // Eutelsat W7 36.0E 12174L and 2174L
    ret = orbital_position != 360 || tsid != 0x0008;
    break; 

In the near future I will examine it, and if it will work then add the patch.
But as I wrote, I may be wrong.

I can confirm that the eesatfan patch works for Latvian Teletext subtitles. Thank you very much.
Only when compiling for my SH4 receiver I got error:

service/servicedvb.cpp: In member function ‘virtual RESULT eDVBServicePlay::enableSubtitles(iSubtitleUser*, iSubtitleOutput::SubtitleTrack&)’:
service/servicedvb.cpp:3055:8: error: name lookup of ‘ii’ changed for ISO ‘for’ scoping [-fpermissive]
service/servicedvb.cpp:3055:8: note: (if you use ‘-fpermissive’ G++ will accept your code) 

That's I correct with as follows:

--- a/lib/service/servicedvb.cpp
+++ b/lib/service/servicedvb.cpp
@@ -3049,7 +3049,8 @@ RESULT eDVBServicePlay::enableSubtitles(iSubtitleUser *user, SubtitleTrack &trac
   m_teletext_parser->setPageAndMagazine(page, magazine, lang.c_str());
   if (m_dvb_service)
   {
-   for (int ii=0; ii < m_teletext_parser->max_id; ii++){
+   int ii;
+   for (ii=0; ii < m_teletext_parser->max_id; ii++){
     if (!memcmp(m_teletext_parser->my_country_codes[ii], lang.c_str(), 3)) break;
    }
    if (ii > m_teletext_parser->max_id-2) ii = 0; 

It would be good to correct original patch.