80 replies to this topic

[libolibo]

I agree with pieterg. I have never seen so far stuff like this:

<i>Go and get it</i>
<b>yes sir</b>

It won't make sense
the italics used for voices that are not in the picture or voice-over

[libolibo]

Not the best code I wrote in my life but this should quick fix the </i><i> and anyway it's better than text = text.substr(3, text.length()-7);

https://github.com/l...5ca3ec669daa65c

[libolibo]

And if we have Regex I would suggest this, instead of the above:

text = Regex.Replace(text, @"(<[^>]+>) ", "");

[libolibo]

Regarding a font to be used for Italic I would suggest to look into Ubuntu Italic font:

http://font.ubuntu.com/

[libolibo]

Actually I have found that there is already an italic font in the /usr/share/fonts folder: hdi.ttf

So what about to modify /usr/share/enigma2/skin_subtitles.xml in this way

<skin>
	<fonts>
		<font filename="valis_enigma.ttf" name="Subs" scale="100" />
			 <font filename="hdi.ttf" name="Subsi" scale="100" />
	</fonts>
	<subtitles>
		<sub name="Subtitle_TTX" font="Subs;34" borderColor="#000000" borderWidth="3" />
		<sub name="Subtitle_Regular" font="Subs;34" foregroundColor="#ffffff" borderColor="#000000" borderWidth="3" />
		<sub name="Subtitle_Bold" font="Subs;34" foregroundColor="#ffffff" borderColor="#000000" borderWidth="3" />
		<sub name="Subtitle_Italic" font="Subsi;34" foregroundColor="#ffffff" borderColor="#000000" borderWidth="3" />
	</subtitles>
</skin>

[pieterg]

hdi.ttf problably belongs to some skin you installed, it's not there by default yet, most likely

[VU+NL]

hdi.ttf is being installed by the Magic-HD skins (and maybe others as well).

[littlesat]

I would go for color codes... make italic yellow and bold (light) green... I know it is a work-a-round but with help of the color escape codes we could simply make some replacements. (replace <i> by escape code for yellow, replace </i> by escape code for white etc..).

In addition the subtitle fonts could be stripped down to just one... the sub font.

Please note this is just a suggestion... And I think even better then loading different fonts.

Pieterg, I still do not understand 100% how the color excape codes are working. Was it \cXXXXXXXX were XXXXXXXX is the color in hex code?

[libolibo]

Let's go with yellow!
ok for me

[pieterg]

Pieterg, I still do not understand 100% how the color excape codes are working. Was it \cXXXXXXXX were XXXXXXXX is the color in hex code?

I added an eString cast operator in gRGB I believe, to do the job. (or the other way around, a + gRGB operator in eString, don't remember exactly)

[littlesat]

Probably next weekend I'll take a look for this.. I suggest to make make Italic cyan and bold yellow.

[littlesat]

I only have to convert the gRGB color with (std::string)color simple...

[littlesat]

FYI: http://openpli.git.s...cd98c68d97866c2

[libolibo]

Splendid!

I am looking forward to update tomorrow
Thank you!

[pieterg]

nice clean and simple patch

[littlesat]

;-) Thanks...

For me it was a complicated patch if we really want to do italic an bold in the correct way... -or- this simple one.

I want to remove the faces here en select the Sub font on also a nice simple way. But I'm scared that some skins may not work... so a bit of it I have to keep in there.

[libolibo]

Hi!

I am wondering if it's just me who has these problem
I have update yesterday evening (GMT+1) and I have these symptoms:
1) Italic is rendered this way

FIRST LINE
			  SECOND LINE
							   LAST LINE

2) Many segments are not displayed at all.

Could anyone give it a try with a .srt file in the media player?

[littlesat]

I tested it here with even italic and bold within a line and it was working fine... Please give me the part of the srt that is doing strange... you should see not italic, but cyan colored letters.

[libolibo]

Sure I see cyan, but the text in the segment gets somehow disaligned.
I try to get a screen dump tonight.

talk later

have a nice day

[TheMystery]

I have the same behaviour.