125 replies to this topic

[athoik]

Dear All,

Since it is possible to use dtsdownmix with dreambox dvbmediasink i created the project gst-plugin-dtsdownmix (https://github.com/a...ugin-dtsdownmix) based on OpenPLi dvbmediasink (http://sourceforge.n...ci/master/tree/).

It uses only the gstdtsdownmix.c and gstdtsdownmix.h and creates the required gstreamer plugin. The only change made on gstdtsdownmix is to increase the GST_RANK_PRIMARY because dreambox dvbmediasink uses static caps. More info http://openpli.org/f...e-9#entry358307

The following patch adds dtsdownmix on Openpli Oe Core.

 

 0001-DTS-downmix-of-audio-streams-for-dreambox.patch.txt   1.65KB   62 downloads

Also we need to enable gst-plugin-dtsdownmix and libdca on feeds, but i have never done this before.

Edited by athoik, 27 June 2013 - 16:35.

[pieterg]

BTW, the reason our dvbaudiosink does not use static caps, is because it should be possible to switch the downmix on/off.

By increasing the dtsdownmix element rank, as soon as people install the plugin, they won't be able to use dts passthrough anymore.

[Persian Prince]

if you did change PLi's sources so you did wrong because we can't take a look at the changes

 

first fork or merge on a new repo then apply your changes so we can see the changes

 

[Persian Prince]

i mean like this : https://github.com/p...in-dvbmediasink

[Persian Prince]

correct bitbake file based on my URL

[athoik]

BTW, the reason our dvbaudiosink does not use static caps, is because it should be possible to switch the downmix on/off.

By increasing the dtsdownmix element rank, as soon as people install the plugin, they won't be able to use dts passthrough anymore.

 

@pieterg, should we create a patch against dreambox dvbmediasink with dynamic caps in order to be able to switch downmix on/off in order to solve the problem? 

 

@persianpros, do you know how to add dtsdownmix and libdca on feeds too?

[Persian Prince]

i'm Persian Prince not persianpros

 

persianpros is our team account

 

yes you can add "libdca0" and "gst-plugin-dtsdownmix" in "OPTIONAL_PACKAGES" : https://sourceforge....penpli-image.bb

 

like :

OPTIONAL_PACKAGES += " \
	libdca0 \
	gst-plugin-dtsdownmix \
	"

Edited by Persian Prince, 27 June 2013 - 18:06.

[pieterg]

@pieterg, should we create a patch against dreambox dvbmediasink with dynamic caps in order to be able to switch downmix on/off in order to solve the problem?

Yes, I think that would be best.
Or users should accept that once they installed this plugin, they cannot use DTS passthroug anymore.

@persianpros, do you know how to add dtsdownmix and libdca on feeds too?

You do not need to add them, because they are dependencies of the plugin. Bitbake should take care of installing them.

[athoik]

@pieterg, should we create a patch against dreambox dvbmediasink with dynamic caps in order to be able to switch downmix on/off in order to solve the problem?

Yes, I think that would be best.
Or users should accept that once they installed this plugin, they cannot use DTS passthroug anymore.

>@persianpros, do you know how to add dtsdownmix and libdca on feeds too?

You do not need to add them, because they are dependencies of the plugin. Bitbake should take care of installing them.

 

 

Please accept  the .bb (Persian Prince or mine) and i will try to create patch for dreambox dvbmediasink on my spare time.

 

 

I know for sure that (free) dtsdownmix is a must have! Users with amplifier they never have to install this...

 

 

PS. I really appreciate your job, thanks.

[athoik]

Dear pieterg,

 

If we change the plugin_init of dtsdownmix to return GST_RANK_PRIMARY when downmix is off and GST_RANK_PRIMARY + 2 when downmix is on would work? (the idea is to have passthrough without patching the dreambox dvbmediasink caps)

[pieterg]

The ranks are stored in the cache, so runtime changes won't work I'm afraid.

[athoik]

Dear All,

 

 

A new patch was created.

 

 0001-Add-DTS-support-on-dreambox-dvbmediasink.patch.txt   5.08KB   34 downloads

 

Dreambox dvbmediasink now is patched to support dtsdownmix. Also dtsdownmix now uses GST_RANK_PRIMARY instead of GST_RANK_PRIMARY + 2.

 

Finally gst-plugin-dtsdownmix was added as depend on dreambox dvbmediasink.

 

 

 

 

[littlesat]

And can you switch off the downmix that way???

[athoik]

And can you switch off the downmix that way???

 

Yes on my tests it works. When the setting is downmix i can hear the sound. When the setting is passthrough i cannot hear the sound (i don't have amplifier).

 

It's the same behaviour like on openpli dvbmediasink, on opepli dvbmediasink you are not adding dts caps when downmix is enabled. On my patch i remove the already added caps when downmix is enabled.

[Persian Prince]

would you please provide your files in a normal zip file with "bb" and "patch" extensions not like this so i can take a look easily ?

[athoik]

Why don't you apply patch?

 

git apply 0001-Add-DTS-support-on-dreambox-dvbmediasink.patch

 

http://ariejan.net/2...patch-with-git/

[Persian Prince]

i'm not using PLi's OE so i can't apply your patch

 

i just need

 

0001-Handle-DTS-Passthrough-and-Downmix.patch

gst-plugin-dtsdownmix.bb

gst-plugin-dreambox-dvbmediasink_0.10.bb

 

files , that's all

 

thanks in advance

[athoik]

here you go:  dtsdownmix-for-dreamboxes.zip   2.33KB   84 downloads

 

 

PS. pieterg did you take a look on the patch? Are we ok now?

Edited by athoik, 29 June 2013 - 10:35.

[pieterg]

I think vu+ is using the dream dvbmediasink, so if we apply this, we would probably render (hardware) DTS downmixing unused on vu+ stb's?

[athoik]

vu+ (include/vuxxo.inc and include/vuxxo2.inc) are using gst-plugin-dvbmediasink.

 

MACHINE_EXTRA_RRECOMMENDS = " \
        vuplus-shutdown \
        gst-plugin-dvbmediasink \
        ntfs-3g \
        "

 

So there is no conflict on vu+ boxes. gst-plugin-dreambox-dvbmediasink is used only by dreamboxes.