2520 replies to this topic

[christophecvr]

@christophecvr

 

I was looking into 0001-0002-eos-vuplus-dreambox-3.patch, and I think you should separate my patch from it, there is no reason to bundle everything into one big patch.

Also is this neccessary?

diff --git a/gstdvbaudiosink.c b/gstdvbaudiosink.c
index 2725def..9cd12e0 100644
--- a/gstdvbaudiosink.c
+++ b/gstdvbaudiosink.c
@@ -74,9 +74,15 @@
#include <poll.h>
#include <stdio.h>

+#if GST_VERSION_MAJOR < 1
#include <gst/gst.h>
#include <gst/audio/audio.h>
#include <gst/base/gstbasesink.h>
+#else
+#include <gstreamer-1.0/gst/gst.h>
+#include <gstreamer-1.0/gst/audio/audio.h>
+#include <gstreamer-1.0/gst/base/gstbasesink.h>
+#endif

Other then that I think patch looks fine, maybe you could add more info to commit message about where did you get DREAMBOX and VUPLUS specifics (dreambox/vu+ dvbmediasink I assume)

 

@littlesat

1. recommended - http://forums.openpl...ndpost&p=480012

2. important - http://forums.openpl...ndpost&p=481794

Yes You must use the correct headers for gstreamer 1.

 

Now we are just lucky that the concerned elements and or functions used are same in both. headers. But it could be an issue using wrong headers.

 

Splitings out is to late now . they should have set You're patch in git from start. It was good Very well documented  You really could not have done it better. And it was not machine related.

About DREAMBOX AND VUPLUS is very good documented and explained. On top off it it's very basic. It will not interfere in any way with the ET boxes (which seems the  the only in the world who can work with  ioctl(self->fd, VIDEO_SET_CODEC_DATA, &videocodecdata)

 

It's only adapted bypass (audio) and streamtype (video) in function of boxtype.

And the pes-headers in function off boxtype.

 

That's really all.

 

But yes pli does not support vuplus we now that. Also not dreambox for the only infantil  reason you close You're source na na na I do the same. After all dreambox is only shootings in there own feeds. And no I will never buy a dreambox anymore. Point is I still have one.  Like a tremendous amount off users.

 

If I had known that pli4 team again would act like this I would have start this from the begining.

 

https://github.com/c...ox-dvbmediasink

 

Then we would have everything step by step.

[christophecvr]

And here again with more info

 

 

Attached Files

•  0001-0002-eos-vuplus-dreambox-3.patch   11.37KB   11 downloads

[littlesat]

I just read a communication that VU did create new drivers for an upgraded mediasink....

[christophecvr]

Note the was even a small typo in previous patch

 

See

 

https://github.com/c.../commits/master

[christophecvr]

For those who test and like to progress. Here the pacth 4 which is just a correction from small typo in patch 3

Now all wmv plays on dreambox ok also wmv3

Attached Files

•  0001-0002-eos-vuplus-dreambox-4.patch   11.44KB   11 downloads

Edited by christophecvr, 17 March 2015 - 13:55.

[salimda]

hi

am new in this topic 

how to add this patch dreambox 800se

[malakudi]

I have downloaded and installed OpenATV 4.3 experimental (which if I understand well uses christophecvr patches) for my VU+ Duo2 and as a first impression, it works well.

[athoik]

In attachment same preroll patch as before but with more detailed explanation

Hello,

Maybe like this is better? It requires no extra variable.

diff --git a/gstdvbaudiosink.c b/gstdvbaudiosink.c
index 2725def..da46f51 100644
--- a/gstdvbaudiosink.c
+++ b/gstdvbaudiosink.c
@@ -828,7 +828,6 @@ static gboolean gst_dvbaudiosink_event(GstBaseSink *sink, GstEvent *event)
                        if (pfd[1].revents & POLLIN)
                        {
                                GST_DEBUG_OBJECT(self, "got buffer empty from driver!\n");
-                               ret = GST_BASE_SINK_CLASS(parent_class)->event(sink, event);
                                break;
                        }

@@ -844,7 +843,7 @@ static gboolean gst_dvbaudiosink_event(GstBaseSink *sink, GstEvent *event)
 #else
                GST_BASE_SINK_PREROLL_LOCK(sink);
 #endif
-
+               if (ret) ret = GST_BASE_SINK_CLASS(parent_class)->event(sink, event);
                break;
        }
 #if GST_VERSION_MAJOR < 1
diff --git a/gstdvbvideosink.c b/gstdvbvideosink.c
index a6b0a10..fbebd11 100644
--- a/gstdvbvideosink.c
+++ b/gstdvbvideosink.c
@@ -449,7 +449,6 @@ static gboolean gst_dvbvideosink_event(GstBaseSink *sink, GstEvent *event)
                        if (pfd[1].revents & POLLIN)
                        {
                                GST_DEBUG_OBJECT (self, "got buffer empty from driver!\n");
-                               ret = GST_BASE_SINK_CLASS(parent_class)->event(sink, event);
                                break;
                        }

@@ -465,7 +464,7 @@ static gboolean gst_dvbvideosink_event(GstBaseSink *sink, GstEvent *event)
 #else
                GST_BASE_SINK_PREROLL_LOCK(sink);
 #endif
-
+               if (ret) ret = GST_BASE_SINK_CLASS(parent_class)->event(sink, event);
                break;
        }
 #if GST_VERSION_MAJOR < 1

[christophecvr]

Here again renewed base git patch from openpli-oe-core. If You fetch the standard git gst-1 branch. Just apply this patch to it.

 

And build for dm8000 and dm800se ok. With gst-1 . All media plays. at least.

 

video formats tested avi,mpeg,mp4,wmv3,wmv (HD) hiqh quality wvc1, those I tested all perfect ok on dreambox and vuplus.

audio formats wma (hardware codecs on dreambox software codecs on vuplus),mp3,wav,flac,ogg those I al tested no any hickup all ok.

 

The machine config is now using my gstreamer-plugin-multibox-dvbmediasink .

 

info see : https://github.com/c...ox-dvbmediasink

 

Included the patch for open openpli-oe-core gst-1 branch

Include patch for meta-vuplus (which is unstaged) apply this patch from out openpli-oe-core/meta-vuplus git.

 

 

 

 

Attached Files

•  GST-1-VUPLUS-DREAMBOX-GITPATCH-20150317.patch   37.12KB   5 downloads
•  META-VUPLUS-UNSTAGES-GIT-PATCH-20150317.patch   3.06KB   6 downloads

[athoik]

@christophecvr

Why you are using an runtime depend on libav?

RDEPENDS_${PN} = "gstreamer1.0-libav"

Most boxes do not require libav for normal playback (eg dm800se/dm500hd).

Also adding libav on machines with low flash memory (eg dm800se/dm500hd) will consume almost all flash!

[christophecvr]

@christophecvr

Why you are using an runtime depend on libav?
 

RDEPENDS_${PN} = "gstreamer1.0-libav"

Most boxes do not require libav for normal playback (eg dm800se/dm500hd).

Also adding libav on machines with low flash memory (eg dm800se/dm500hd) will consume almost all flash!

 

That was always there it's not from me . but vuplus requires it.

[Erik Slagter]

@christophecvr: Can you perhaps write which patch should be applied to which branch and then hopefully everything is clarified.

It would also help if christophevcr would add a PROPER description with each patch.

- what problem does it tackle
- how does it do so

Preferrably in a bit less words/lines.

[Erik Slagter]

I can see how maintainers would have a problem with a patch like this. There is zero information about why the patch is needed (i.e the problem that is being solved), what it does (i.e how it solves the problem) and how to test that it works as intended.

You read my mind!

[Erik Slagter]

vu update drivers for new subsink
 
update proxy drivers and utils
20150317
- Support new Gstreamer sink interface(OE update will follow)
- Fix blurred graphic problem

Still not in the OpenPLi VU+ BSP.

[christophecvr]

 

@christophecvr: Can you perhaps write which patch should be applied to which branch and then hopefully everything is clarified.

It would also help if christophevcr would add a PROPER description with each patch.

- what problem does it tackle
- how does it do so

Preferrably in a bit less words/lines.

 

The gst-1.0 patch was abolutely not made to add to the master branch. I'm even do not ask that as it's usseless but I ges You can read

From 801f1b1479eaca216b5ef00fbb8200d638b82c16 Mon Sep 17 00:00:00 2001
From: christophecvr <stefansat@telenet.be>
Date: Tue, 17 Mar 2015 18:46:01 +0100
Subject: [PATCH] Branch gst-1 openpli-oe-core git patch This patch sets the
 gst-1 branch ready with all required packages and enigma2 corrections. To
 work with gstreamer1.0 on vuplus and dreamboxes dm8000 and dm800se. Voor Vu
 plus You still will have to apply an extra patch to the meta-vuplus git.
 That's cause the meta-vuplus is unstaged. Also the meta-dreambox is adapted
 to use gstreamer1.0-plugin-multibox-dvbmediasink. The metavuplus will also be
 right if You apply the extra patch from out meta-vuplus git.

[christophecvr]

@athoik.

 

It was standard with libav in to the gst-1 's gstreamer1.0-plugin-dvbmediasink.

 

I'll see to make a parameter in by machine config and then a ${themachineconfigrdepend} by rdepends such as done for dvb-mediaconfig.

[athoik]

@athoik.
 
It was standard with libav in to the gst-1 's gstreamer1.0-plugin-dvbmediasink.

I'll see to make a parameter in by machine config and then a ${themachineconfigrdepend} by rdepends such as done for dvb-mediaconfig.

If only some machines require the libav then it is better to use MACHINE_ESSENTIAL_EXTRA_RDEPENDS or MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS.

Eg. If VU+ use software codecs it can use the following:

MACHINE_ESSENTIAL_EXTRA_RDEPENDS = " \
        ... \
        gstreamer1.0-libav \
"

or

MACHINE_EXTRA_RRECOMMENDS = " \
        ... \
        gstreamer1.0-libav \
"

[betacentauri]

Regarding (partly) not shown language for audio streams and subtitles I filed a bug: https://bugzilla.gno...g.cgi?id=746363
It seems it's an old bug

[babsy98]

info new vu drivers with gst 1.4.5 works good better as before my not working dts files works now and spinner playback mkv with dts was gone

 

new atv 4,3 coming in 1-2 h

[christophecvr]

@athoik

 

here the latest patch for gst-1 branch gstreamer1.0-libav removed and set by machine configs.

 

For vuplus users don't forget to apply the meta-vuplus patch . (Note the gstreamer1.0-libav required for vuplus is now by machine rrecommends)

 

 

Attached Files

•  GST-1-VUPLUS-DREAMBOX-GITPATCH-20150317-2.patch   13.28KB   9 downloads
•  META-VUPLUS-UNSTAGES-GIT-PATCH-20150317-2.patch   2.13KB   5 downloads