92 replies to this topic

[WanWizard]

Like yesterday?

 

It already caught me out, had a phone call, turned the sound of, came back, saw the mute icon, pressed the mute button, still no sound. Took me a while to realize the volume was set to zero, and the stupid change from this topic was to blame...

[littlesat]

Volume to zero != mute.. that is not changed at all...

Edited by littlesat, 9 December 2016 - 15:52.

[WanWizard]

Exactly. So why do I now see a mute icon in the skin when the volume is set to zero?

[littlesat]

That should not be the fact... as far I see my last changes...

Edited by littlesat, 9 December 2016 - 15:53.

[littlesat]

But note the original code by itself is extreme too much complicated

[WanWizard]

Just reporting what I saw. It shows when you open the info bar, and stays on screen even after the infobar has timed out, and disappears later (so it seems to have a seperate timeout too).

[littlesat]

And I can see it incorrect... so please give me Some sequense how to verify the wierdness you observes. For Some boxes zero volume needs to set mute
Probably with volume 0 I should show the volume bar instead

Edited by littlesat, 9 December 2016 - 15:59.

[WanWizard]

ET10000, FullNightHD skin. with the OpenPLi 4 from Wednesday.

 

Set the volume to 0, press Ok to open the infobar. You will see a mute icon appear at the top.

 

In the meantime I have updated, but not checked again, I will do that in a minute.

[littlesat]

Set the volume to 0, press Ok to open the infobar. You will see a mute icon appear at the top. -> OMG that was not intended...

[WanWizard]

Thought so.

[littlesat]

Try this in /usr/lib/enigma2/python/Components/VolumeControl.py from line 74... (replace complete function..). When volume cntrl = 0 it shows the volume bar...

 

But I'm considering to find a better solution... As long as volume bar is shown remember as it was and make from volume = 0 a mute.... so with unmute it also restored to what it was...

  def showMute(self):
    if not self.volctrl.getVolume():
      self.volumeDialog.show()
      self.hideVolTimer.start(3000, True)
    elif self.volctrl.isMuted():
      self.muteDialog.show()
      self.hideVolTimer.start(3000, True)

Edited by littlesat, 9 December 2016 - 16:40.

[littlesat]

A real solution might be to make volume 0 == mute...

Edited by littlesat, 9 December 2016 - 16:49.

[WanWizard]

NOOOOO..... Revert all this shit! Problem solved.

[rocco99]

I hope that mute icon gets on the brand stack forever.

[Erik Slagter]

Which brand actually?   

[littlesat]

Revert is also not a solution...

Who does ever had in mind to think about volume zero != mute.... (I'm not sure but as far I memember it was vu)

At least I far I remember there exist a brand that does not have a mute proc (at least in the past)...

Edited by littlesat, 9 December 2016 - 19:54.

[mrvica]

>>>  volume zero != mute....

 

if you hear digital sound over toslink (without downmix) the mute icon could be disturbing, meaning no sound, though you hear some sound over your amplifier and you can there change volume

[littlesat]

I did just revert the complete changes... and from now on those who want to mute without seeing the mute button simply press long-mute while muting....

Edited by littlesat, 10 December 2016 - 12:15.

[WanWizard]

Thank you.

 

mute !== volume 0. If the box is muted, you press the mute button to return to the volume set. If the box is set to volume 0, you press volume-up to get sound again. Two different actions.

 

And you don't want to mix the two, as unmute doesn't mean you want the volume up or down 1 (which happens if you have to unmute with the volume keys) and it gets worse if you have forwarded the keys using HDMI-CEC. In which case the box stays in mute, but the volume of your TV will go up or down.

 

I am happy it is reverted to it's original and logical behaviour.

[littlesat]

Everything is orriginal as it was for 13 years or longer.... ... So the "feeling" is back as it was ago...

To do it really right it needs a lot of decoding and I verified more equipment around me and more stuff has mute != voluime zero...

 

Now only one function is added... long mute is hide mute icon... so when you want to mute without an icon you can press long mute while muting.

Edited by littlesat, 10 December 2016 - 12:49.