998 replies to this topic

[IanSav]

Hi Zeros,

 

Thanks and good luck.

 

Regards,

Ian.

[zeros]

Just in case:
—
a) Add the font line to the section of the skin.
b ) Add the parameter lines to the section of the file.
—
Did you do that for me in the file you added?

[IanSav]

Hi Zeros,

 

Just in case:
—
a) Add the font line to the section of the skin.
b ) Add the parameter lines to the section of the file.
—
Did you do that for me in the file you added?

 

The skin.xml and keymap.xml files have been edited with the changes so you, and others, can compare the files and see how the changes look in practice.

 

Regards,

Ian.

[zeros]

Thanks for the confirmation! I wanted to make sure that Gsod is not caused by an undone changes. Then it's clear, thanks!
P.S. last time I didn't change anything In this regard.

Edited by zeros, 12 August 2018 - 11:01.

[zeros]

I was comparing files with the original and bringing out changes in font and parameters.

My test is prepared and I will do it in tomorrow morning.

Attached Files

•  font.png   259.01KB   1 downloads
•  parameter.png   260.2KB   1 downloads
•  keymap.xml.png   306.79KB   1 downloads

[zeros]

I got the following text in GSOD:

--

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 49, in action
  File "/usr/lib/enigma2/python/Plugins/Extensions/YouTube/YouTubeSearch.py", line 244, in openKeyboard
  File "/usr/lib/enigma2/python/mytest.py", line 287, in openWithCallback
    dlg = self.open(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/mytest.py", line 297, in open
    dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/mytest.py", line 240, in instantiateDialog
    return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
  File "/usr/lib/enigma2/python/mytest.py", line 264, in doInstantiateDialog
    dlg.applySkin()
  File "/usr/lib/enigma2/python/Components/GUISkin.py", line 154, in applySkin
  File "/usr/lib/enigma2/python/Components/GUISkin.py", line 57, in createGUIScreen
  File "/usr/lib/enigma2/python/Screens/VirtualKeyBoard.py", line 682, in buildVirtualKeyBoard
    self.markSelectedKey()
  File "/usr/lib/enigma2/python/Screens/VirtualKeyBoard.py", line 713, in markSelectedKey
    self.list[self.selectedKey / self.keyboardWidth].append(MultiContentEntryPixmapAlphaBlend(pos=(x, 0), size=(self.key_sel.size().width(), self.height), png=self.key_sel))
AttributeError: 'NoneType' object has no attribute 'size'
 

[zeros]

I add my original files, before editing them (just in case).

Attached Files

•  -keymap.xml   34.97KB   1 downloads
•  -skin.xml   138.68KB   0 downloads

[zeros]

Strange that the exact same mistake as in previous time!?

[zeros]

I add the place of the error.

 

In original file the same line and self:

https://github.com/O...tualKeyBoard.py

In original file it is as:

 

 

def markSelectedKey(self):

  w, h = skin.parameters.get("VirtualKeyboard",(45, 45))

  if self.previousSelectedKey is not None:

   self.list[self.previousSelectedKey /12] = self.list[self.previousSelectedKey /12][:-1]

  width = self.key_sel.size().width()

  try:

   x = self.list[self.selectedKey/12][self.selectedKey % 12 + 1][1]

  except IndexError:

   self.selectedKey = self.max_key

   x = self.list[self.selectedKey/12][self.selectedKey % 12 + 1][1]

  self.list[self.selectedKey / 12].append(MultiContentEntryPixmapAlphaTest(pos=(x, 0), size=(width, h), png=self.key_sel))

  self.previousSelectedKey = self.selectedKey

  self["list"].setList(self.list)

 

 

Attached Files

•  NoneType-object-has-no-attribute-size.png   222.07KB   1 downloads

[IanSav]

Hi Zeros,

 

Are you sure that you are using *my* "VirtualKeyBoard.py"?  The source code you posted above is *not* my code.

 

The width of the keyboard grid is now 14 cells and not 12 and I don't use a hard coded width I use a variable.

 

Can you please check what code you are actually using.

 

Regards,

Ian.

[zeros]

Nb! This code was the original file, how it was there. And Your code is on the screenshot image that I am using. Look there in the line 713, where is the error.

[IanSav]

Hi Zeros,

 

Can you please confirm the name of the skin you are using.  I am trying to duplicate your setup on my T3.

 

Regards,

Ian.

[zeros]

Default Skin is PLi-FullNightHD,
but I use PLi-HD.
Why, because I can not configure my Sony TV as recommended. Adjusting the sound bar is left out the screen etc.
So my skin is PLi-HD.

[IanSav]

Hi Zeros,

 

Okay, I have made a mistake in my suggestions for you.  I set the file up for a standard 1280x720 skin.  I will need to make adjustments for a 1920x1080 skin.

 

Regards,

Ian.

[IanSav]

Hi Zeros,

 

The OpenPLi skins have a different layout than I expected.  The "Directories.py" doesn't have the location rescue code of OpenViX and Beyonwiz.  The images not being found is causing the crash.

 

I will update the installation kit, the instructions and the sample skin for you.  That should address all the issues.

 

Regards,

Ian.

[zeros]

Thanks, I think it's even good that we found this skins specificity. Yes, both skins should be tested.

[IanSav]

Hi Zeros,

 

Attached are the corrected files.  You will need to install the keyboard images files into the correct location.  Follow the updated instructions and the crash should go away.

 

Please note that I am unable and unwilling to change all the skins out there to match the new VirtualKeyBoard code.  This should be  done by the appropriate skin maintainers.  The shin changes in the test kit are simply a guide on what could / should be done.

 

Regards,

Ian.

 

Attached Files

•  VirtualKeyBoard.zip   35.48KB   4 downloads
•  skin.xml   139.28KB   5 downloads
•  README.txt   2.19KB   8 downloads

[zeros]

Thank you, I'm testing it in tomorrow.
No more Today PLI skins, there are UHD Skins, but In my knowledge PLi does not own them. For example Ultra HD Glass 18 ver. 1.42
I believe they manage their own skin They themselves.
So if these two are okay, it's good.

[Pr2]

Official OpenPLi Skin are maintained here:

 

https://github.com/l...esat/skin-PLiHD

 

Won't it be better for testing to create your keyboard with an alternate name and screen name that won't try to reuse the existing one, and find a way to be able to select the keyboard that we want to use. I guess this will ease life of people willing to test your new keyboard layout.

 

Pr2

[IanSav]

Hi Pr2,

 

Official OpenPLi Skin are maintained here:

 

https://github.com/l...esat/skin-PLiHD

 

Won't it be better for testing to create your keyboard with an alternate name and screen name that won't try to reuse the existing one, and find a way to be able to select the keyboard that we want to use. I guess this will ease life of people willing to test your new keyboard layout.

 

The idea is that the new VirtualKeyBoard is to be a drop in replacement for the old code.  Modifying the code to support the co-existence of both versions would modify the conditions and defeat the purpose of these tests.

 

Once I get some more test results I will either address any remaining issues and retest or I will submit the code with a view to it totally replacing the old version.

 

Regards,

Ian.