998 replies to this topic

[ims]

may be - set focus to Exit or Enter key on start VK ?

[zeros]

PLi-FullHD - OK
PLiFullNightHD - OK
PLi-HD  - NOK
PLi-HD1  - NOK
PLi-HD2  - NOK

With fresh build these three last skins still provide the GSOD:

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 49, in action
  File "/usr/lib/enigma2/python/Plugins/Extensions/YouTube/YouTubeSearch.py", line 244, in openKeyboard
  File "/usr/lib/enigma2/python/mytest.py", line 287, in openWithCallback
    dlg = self.open(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/mytest.py", line 297, in open
    dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/mytest.py", line 240, in instantiateDialog
    return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
  File "/usr/lib/enigma2/python/mytest.py", line 264, in doInstantiateDialog
    dlg.applySkin()
  File "/usr/lib/enigma2/python/Components/GUISkin.py", line 154, in applySkin
  File "/usr/lib/enigma2/python/Components/GUISkin.py", line 57, in createGUIScreen
  File "/usr/lib/enigma2/python/Screens/VirtualKeyBoard.py", line 583, in buildVirtualKeyBoard
  File "/usr/lib/enigma2/python/Screens/VirtualKeyBoard.py", line 614, in markSelectedKey
AttributeError: 'NoneType' object has no attribute 'size'

Can we eliminate this error? The first two are OK. So that when I change the skin, it would be OK. Manually I can fix it, but we need it to be fine from the start.

Attached Files

•  PLi-FullNightHD.png   486.32KB   1 downloads

[littlesat]

Merged

[ims]

I have not time solve this bugs, but I had to see on it:

 

old virtual keybord had all .png files in root of default skin and not under "buttons". Under buttons are RC's buttons only!  =>

 

1 ) there in VirtualKeyboard.py replace paths from "buttons/...." to "skin_default/..."

Example: self.key_bg = LoadPixmap(path=resolveFilename(SCOPE_CURRENT_SKIN, "skin_default/vkey_bg.png"))

2) for SD skins add new .png pictures into enigma2's repo under skin_default/ onky => for all SD skins once!

 

3) in PLi-Full**** skins add new png under skin_default/ too

 

In skin's screen replace path <ePixmap pixmap="buttons/vkey_text.png" to <ePixmap pixmap="skin_default/vkey_text.png"

 

Then will works all PLi skins ...

 

 

=> Ian, change paths in VirtuakKeyBoard.py, I will change then all about skins ... ok ?

Edited by ims, 20 August 2018 - 07:01.

[littlesat]

Indeed...!

[IanSav]

Hi Ims,

 

may be - set focus to Exit or Enter key on start VK ?

 

I don't want to do that as the active cell cursor will hide the colour button hint.

 

Regards,

Ian.

[ims]

Hi Ims,

 

may be - set focus to Exit or Enter key on start VK ?

 

I don't want to do that as the active cell cursor will hide the colour button hint.

 

Regards,

Ian.

Then to some empty or "<<-" button ? Time to time user made mistake (me too) and then instinctive press OK => is added f.eg. for me ";" into name

[IanSav]

Hi Ims,

 

I have not time solve this bugs, but I had to see on it:

 

old virtual keybord had all .png files in root of default skin and not under "buttons". Under buttons are RC's buttons only!  =>

 

1 ) there in VirtualKeyboard.py replace paths from "buttons/...." to "skin_default/..."

Example: self.key_bg = LoadPixmap(path=resolveFilename(SCOPE_CURRENT_SKIN, "skin_default/vkey_bg.png"))

2) for SD skins add new .png pictures into enigma2's repo under skin_default/ onky => for all SD skins once!

 

3) in PLi-Full**** skins add new png under skin_default/ too

 

In skin's screen replace path <ePixmap pixmap="buttons/vkey_text.png" to <ePixmap pixmap="skin_default/vkey_text.png"

 

Then will works all PLi skins ...

 

 

=> Ian, change paths in VirtuakKeyBoard.py, I will change then all about skins ... ok ?

 

I can't change the VirtualKeyBoard image path within the plugin as that will break the other images.

 

OpenPLi has the strangest image paths that really should be fixed.  If you adopt the code I suggested in Directories.py and above to allow images to be found in standard locations then this should not have been an issue.

 

Changing the default path in VirtualKeyBoard to skin_default will prohibit and skin developers from reskinning this screen!  This ability MUST be retained.

 

In the originals locations of the vkey_* images should NOT be changed.  Simply copy/add the newest versions supplied with VirtualKeyBoard into the locations I specified in the documentation.  When OpenPLi fixes its Directories.py code then we can look at alternative image locations.

 

Regards,

Ian.

Edited by IanSav, 20 August 2018 - 07:15.

[IanSav]

Hi Ims,

 

Then to some empty or "<<-" button ? Time to time user made mistake (me too) and then instinctive press OK => is added f.eg. for me ";" into name

 

For all the people who have looked at or reviewed the code you are the only one to raise this as an issue.

 

If I was going to shift the initial location of the grid cursor then I would locate it in the middle of the grid.  Doing that doesn't address your concern.

 

Is this an issue because you are new to this screen or do you see this as a problem that will cause real issues for users?

 

Regards,

Ian.

[ims]

Hi Ims,

 

Then to some empty or "<<-" button ? Time to time user made mistake (me too) and then instinctive press OK => is added f.eg. for me ";" into name

 

For all the people who have looked at or reviewed the code you are the only one to raise this as an issue.

 

If I was going to shift the initial location of the grid cursor then I would locate it in the middle of the grid.  Doing that doesn't address your concern.

 

Is this an issue because you are new to this screen or do you see this as a problem that will cause real issues for users?

 

Regards,

Ian.

It is not bug, it is cosmetics... old keyboard focused on left-top "Exit" => due it was not problem ... when was opened VK by mistake, then was with OK button on RC pressed Exit and VK was closed, thats all...

[IanSav]

Hi Ims,

 

Okay, I can accept that logic.  Would you prefer the initial location to be "<<-" or "->>"?

 

If you select "<<-" then pressing OK will cause the grid cursor to jump from the end of the string to the start of the string.  If you select "->>" then pressing OK will do nothing.  The first is a harmless action but it does show the user that something happened.  The latter is also harmless but may leave the user wondering if the screen is working.

 

Which would you like me to implement?

 

Regards,

Ian.

[ims]

"<<-"  ... user can see, something hapends

 

 

About paths ... I do not agree ... btw - <Default skin> is not solved at all.

I do not think, that other company have better using in Directory... only diferent "strange" way f.eg. then must be all pictures in each skin!

For PLi is all only once in skin_default for all skins and if somebody wants, easy can change picture adding to own skin...

Ok, VK will be for SD skins out ...

[IanSav]

Hi Ims.

 

Okay I will change the default location to "<<-".  Pull request will arrive in a few minutes.

 

Perhaps to can open a new thread and explain how the image resolution system works in OpenPLi.  Also explain how it works for skins in different resolutions.

 

Regards,

ian.

[ims]

It must be Littlesat with his english.

 

"SCOPE_CURRENT_SKIN"

FullHD skins, if need picture with different size, take it from his own /usr/share/enigma2/AnyFullHD/skin_default/. If not exist, is taked picture from default skin /usr/share/enigma2/skin_default/

But still same path in code.

 

There is not problem, that pictures for VK are added under "buttons", it is cosmetic, problem is, that "buttons" means in this case "/usr/share/enigma2/buttons" for all SD skins and it not exist. Exist /usr/share/enigma2/skin_default/buttons"

Due it must be "skin_default/" on start. Then it can be "skin_default/vkey_bg.png" or "skin_default/vk/vkey_bg.png" or "skin_default/buttons/vkey_bg.png" ...

Edited by ims, 20 August 2018 - 08:05.

[Pr2]

Is it possible to have the space bar bigger on VK like on real keyboard?

 

The SMS style keyboard location is over the Picture-In-Graphic windows which is quite annoying, can we move it elsewhere?

[zeros]

and I can check it out quickly if you add it in code. 

I believe that this logic remains even if the user chooses several times to change the skin.

Such as for example

PLi-FullHD -> PLi-HD -> PLiFullNightHD -> PLi-HD1

Edited by zeros, 20 August 2018 - 08:21.

[littlesat]

I think the SMS style should stay in... as this is the quickest way to navigate...

 

I also thing we should make it possible to navigate the --> and <-- via the CH/B +/- keys and also the <> keys next to the 0... and the >> << keys (can we 'tripple' this?)... and use the |>> and <<| keys also to get to the end/begin.

 

The pictures need indeed to be moved to the skin_default directory within the skin as it should be...

 

(than even later we can consider to remove the pictures from the skin and add a skin_default_720 and skin_default_1080 to the /usr/share/enigma2 folder and let the SCOPE_CURRENT_SKIN search first for the specific folder in a different 'project')

Edited by littlesat, 20 August 2018 - 09:11.

[IanSav]

Hi Pr2,
 

Is it possible to have the space bar bigger on VK like on real keyboard?

This is not easy to do. The simplicity of the code lies in the easy calculations required to calculate the cursor position. Making any keys an irregular size would complicate the code for little return.  This is not a change I would like to tackle at this late stage.

 

The other issue is that some of the keyboard designs take advantage of every grid location available per screen.  Removing available cells would require a rework of all the keyboards.

 

The SMS style keyboard location is over the Picture-In-Graphic windows which is quite annoying, can we move it elsewhere?

 

This is mostly a skin issue but there are also positioning errors in the config.py code. Those issues are already fixed in my refactored Setup.py / ConfigList.py / config.py code.

Regards,
Ian.

[IanSav]

Hi,

 

Pull Request #1676 has been raised to reset the initial cursor location.

 

Regards,

Ian.

[ims]

 

The SMS style keyboard location is over the Picture-In-Graphic windows which is quite annoying, can we move it elsewhere?

 

SMS mode you can move adding line to screens in skin - f.eg:

<widget name="HelpWindow" position="center,300" size="60,0"/>