998 replies to this topic

[IanSav]

Hi Zeros,

 

Are you making headway in the changes or do you need help?  It sounds like you are getting the hang of the image locations and skin changes required.  There should be nothing extra over what I put in the documentation.

 

By the way, just to annoy everyone some more I am nearly finished rewriting NumericalTextInput.py to implement some improvements and corrections.  Skin changes will not be necessary but can offer some improvements. 

 

Regards,

Ian.

Edited by IanSav, 21 August 2018 - 05:43.

[zeros]

I'll just explain that these skins need to be helped, because when you make software construction/build, then without being helped you get GSOD. And the normal user will not start to change these files. So I hope these skins will be helped as well by PLi team.

[IanSav]

Hi Zeros,

 

I would have hoped that the people who created all the skins would have jumped in to help maintain them.  Oh well.

 

I have been helping OpenViX to make their skin changes for the new VirtualKeyBoard and I have no objection to help OpenPLi to make similar skin changes.  If you want my help please give me the skin files with which you need help and I will see what I can do to help.

 

Regards,

Ian.

Edited by IanSav, 21 August 2018 - 06:05.

[littlesat]

Help is appreciated of course... but please put the pictures in an appropriate folder... for now on skin_defaults within the skin itself...

[IanSav]

Hi Littlesat,

 

I can't move the images as that will break OpenViX and Beyonwiz.  At the moment this issue results in a small duplication of about two or three small image files.  All the rest of the old VirtualKeyBoard images are no longer used by my code.  If no-one else is using them then they can all be deleted.

 

We will sort the image location out when we address the OpenPLi SCOPE_CURRENT_SKIN deficiencies.  OpenViX and Beyonwiz will also benefit from some of the corrections I mentioned.  This best way forward is to design an optimal solution in OpenPLi and then let the others pull the improvements into their images.

 

Regards,

Ian.

[littlesat]

What does it exactly break on VIX and Beyonwiz? I think it is not bad that they get a skin_default overrule directory within their own skin stuff added... 

[IanSav]

Hi Littlesat,

 

I thought image paths like "buttons/vkey_sel.png" looked reasonable to me.  What do you believe is an appropriate folder within which to locate the images?

 

I believe that OpenViX and Beyonwiz they use SCOPE_ACTIVE_SKIN.  That code looks in the current skin to find the image.  If that fails it uses the same relative path to look in skin_default.  At no time does "skin_default" ever become a relative part of the image name.  That is, in OverlayHD look for the image in "/usr/share/enigma2/OverlayHD/buttons/vkey_sel.png" if the image isn't found then look at "/usr/share/enigma2/skin_default/buttons/vkey_sel.png".

 

In the proposal I previously put forward this would change such that, in OverlayHD, look for the image in "/usr/share/enigma2/OverlayHD/buttons/vkey_sel.png" if the image isn't found then look at "/usr/share/enigma2/skin_default_720/buttons/vkey_sel.png" and then finally "/usr/share/enigma2/skin_default/buttons/vkey_sel.png".

 

For VirtualKeyBoard I have chosen to use SCOPE_CURRENT_SKIN so as to keep the code common to all images.  That means that I need to keep the images in a known location within the current skin.  When SCOPE_CURRENT_SKIN gets enhanced then SCOPE_ACTIVE_SKIN can be deprecated and all images can look forward to a more sensible image search facility.

 

Regards,

Ian.

[littlesat]

As far I can see these kind of pictures should be in skin_default... not in the 'root'.... and we can have an 'overrule' of skin_default pictures in our skin. Does VIX not have that? 

 

I was considering to add a skin_default_720 and skin_default_1080 to reduce some default pictures in the skin itself.

Edited by littlesat, 21 August 2018 - 09:50.

[mjray]

If we adhere to that thought nothing will ever change....
E2 is meant for hobbyists, not for people who want a working-out-of-the-box experience; they should stick to decoders provided by their providers.
And hobbyists only want one thing: improvement(s)!

The other decoders don't work properly and can't be fixed/improved by us ourselves! Why can't we have both? Working out of the box, plus be able to improve it?

I hope the above sentiment isn't widespread here, or I wish I had known about it before I bought an E2 box to replace a buggy box from another provider.

Other than that, I'm late to the party and I was going to suggest Quebec (fr_CA) keyboard as a good addition because I use that a lot on my tablet and phone but that's mainly because it has dead keys for a lot of accents for a lot of languages I use and I think you've ruled out implementing dead keys. Switching between too many keyboard layouts is rather confusing but at least the characters will be there somewhere, which I think is an improvement.

[IanSav]

Hi Littlesat,
 

As far I can see these kind of pictures should be in skin_default... not in the 'root'.... and we can have an 'overrule' of skin_default pictures in our skin. Does VIX not have that?

If I understand what you are saying: No.  There is no "skin_default" sub directory in any OpenViX or Beyonwiz skin.  There is only one "skin_default" in "/usr/share/enigma2/".
 

I was considering to add a skin_default_720 and skin_default_1080 to reduce some default pictures in the skin itself.

That is more or less what I suggested many posts above.

 

Regards,

Ian.

[IanSav]

Hi Mjray,
 

Other than that, I'm late to the party and I was going to suggest Quebec (fr_CA) keyboard as a good addition because I use that a lot on my tablet and phone but that's mainly because it has dead keys for a lot of accents for a lot of languages I use and I think you've ruled out implementing dead keys. Switching between too many keyboard layouts is rather confusing but at least the characters will be there somewhere, which I think is an improvement.

It is not too late to ask for improvements or extra languages.

 

Is there a current keyboard layout that comes close to what you want?  If so, what is it and what do you need changed?  If there is not a close match then please provide me a link to a detailed picture or details of the keyboard layout you want.

 

Regards,

Ian.

[littlesat]

Can someone please help me to get the old vkey stuff out of the skin...

[Persian Prince]

Can someone please help me to get the old vkey stuff out of the skin...

Sure tell me what to do

[littlesat]

Remove then with git remove...

[mjray]

Is there a current keyboard layout that comes close to what you want? If so, what is it and what do you need changed?

I think the listed layouts cover them pretty well so far as long as we can switch between them. Maybe just think of fr_CA if you ever do add dead keys. Thanks.

[IanSav]

Hi Littlesat,

 

Do you still need any assistance cleaning up old images?  (Have you checked that nothing else is using any of the old images?)

 

Regards,

Ian.

[IanSav]

Hi Mjray,

 

I think the listed layouts cover them pretty well so far as long as we can switch between them. Maybe just think of fr_CA if you ever do add dead keys. Thanks.

 

Would you like me to define a default or starting keyboard for fr_CA?  You don't have to start on en_EN if you don't want it that way.

 

I am happy to make any customisations to a keyboard if you want any.

 

Regards,

Ian.

[IanSav]

Hi,

 

If people want to retire the old vkey_* images that VirtualKeyBoard no longer uses then these images can go:

• vkey_all.png
• vkey_clr.png
• vkey_esc.png
• vkey_ok.png
• vkey_shift.png
• vkey_shift_sel.png

These images are replaced by an updated image:

• vkey_backspace.png
• vkey_space.png
• vkey_text.png

Please ensure that these images are NOT used by any other code or screens before removing them completely.

 

Regards,

Ian.

[zeros]

If it plays a role, present 'PLi-HD' Skin it has buttons for size 45x45, what found in the IanSav folder '720'.
However, there are not all the necessary icons in this folder. You can find them in folder '1080'.

I was comparing what files are missing from the folder '720'.
Looking at the Python code:
-vkey_bg.png
vkey_red.png
vkey_green.png
vkey_yellow.png
vkey_blue.png
-vkey_sel.png
vkey_backspace.png
vkey_enter.png
vkey_first.png
vkey_last.png
-vkey_left.png
-vkey_right.png
vkey_shift0.png
vkey_shift1.png
vkey_shift2.png
vkey_shift3.png
vkey_space.png
vkey_space_alt.png

- == png file is missing on folder '720'
Just if these png files all exists on buttons file folder, you will not get GSOD

It was pretty hard to figure it out for me.

On the other hand, perhaps I need to use the files from folder '1080'?
In this case things are in place but buttons are smaller.

So I think at the moment is needed to add missing png buttons files to PLi-HD; PLi-HD1 and PLi-HD2:
vkey_bg.png
vkey_sel.png
vkey_left.png
vkey_right.png
and change the file skin.xml on their folder PLi-HD; PLi-HD1 and PLi-HD2.
Then it would be fine. Or would you like to place these buttons in a shared folder so there is no duplication? I understand that littlesat wants to do that if I get it right?

Edited by zeros, 22 August 2018 - 05:14.

[Rob van der Does]

There is no "skin_default" sub directory in any OpenViX or Beyonwiz skin.  There is only one "skin_default" in "/usr/share/enigma2/".

Indeed; there are quite a lot of differences between the PLi & ViX skin-engines.