998 replies to this topic

[zeros]

I confirm that the Estonian keyboard is still OK (2018-09-09 (develop))

[IanSav]

Hi Zeros,

 

Thank you for the confirmation.

 

Regards,

Ian.

[IanSav]

Hi Ims,

 

The new skin.py "parseParameter" code has been questioned by PeterU in the Beyonwiz repository.  He is concerned that existing code that currently uses parameters only knows about processing numbers.  All the code in the new "parseParameter" returnes numbers except for the string result.  This may cause issues or crashes in the downstream receiving code.

 

PeterU suggests abandoning the string return and changing

elif s.lstrip('-+ ').isdigit():
    return int(s)
else:
    return s

to

else:
    return int(s)

I would like to keep the option of having string parameters and prefer that all code do their own validation of any parameter data but at the moment this is not the case.  All existing code simply assumes that the data coming from parameters will be numeric.

 

What do you think?

 

Regards,

Ian.

[athoik]

No problem just send a PR that will change to else: int(s).

To be honest it was like this, but then Huevos request to support strings as well.

So go ahead, when string parameter arive's we will find a way.

[IanSav]

Hi Athoik,

 

I think it was me who asked about strings.    I would still like to have them but I don't want to put other code at risk.  To be able to accept string parameters all code that accepts parameters would need to be updated to validate any incoming data.

 

I would like to get Ims's input before submitting changes.

 

Regards,

Ian.

Edited by IanSav, 13 September 2018 - 14:51.

[ims]

I have not idea ... all this pars there in whole e2 code was for using decimal numbers, VK has hex and string now...

[IanSav]

Hi Ims,

 

Okay, to protect legacy code I will submit the change.  I didn't want to make any changes without alerting you and discussing the matter first.

 

In the future we can protect the legacy code by checking that parameters are numeric if that is what is required and then we can restore string parameters.

 

Regards,

Ian.

[IanSav]

Hi Ims and Athoik,

 

It was Athoik and not Ims who created the "parseParameter" change.  I apologise for the confusing posts above where I addressed the incorrect person in regard to that change. 

 

Regards,

Ian.

[athoik]

No problem.

[IanSav]

Hi Athoik,

 

The Travis CI build appears to have failed. Is this something I need to address?

 

Regards,

Ian.

[athoik]

We do not check for python errors on Travis CI build (although I did prepare it on my repo).

So most probably it's an Travis CI error (eg timeout downloading a package or so).

[Taapat]

@IanSav

1) You are requesting all discussion here about all changes in VirtualKeyBoard.
Sorry if I miss something, but where is the question about this change: https://github.com/O...926462b1fed0987

Your added function okClicked did not fix anything for my plugin.
If you would have looked into my plugin code (and there are only a few lines), you would see that I need for this function call from action map instead of an empty extra function with the same name.

Ok I added an additional function in my plugin to fix this.

You can remove okClicked from VirtualKeyBoard.

2) You are writing here that your changes are used on OpenViX and beyonwiz and thefore nothing can not be changed in openplit git.
Unfortunately I do not see any of your changes in any of the branch not in OpenViX: https://github.com/O...tualKeyBoard.py

not in beyonwiz: https://bitbucket.or...le-view-default
Where your changes in VirtualKeyBoard applied without openpli?

[Huevos]

@IanSav

1) You are requesting all discussion here about all changes in VirtualKeyBoard.
Sorry if I miss something, but where is the question about this change: https://github.com/O...926462b1fed0987

Your added function okClicked did not fix anything for my plugin.
If you would have looked into my plugin code (and there are only a few lines), you would see that I need for this function call from action map instead of an empty extra function with the same name.

Ok I added an additional function in my plugin to fix this.

You can remove okClicked from VirtualKeyBoard.

2) You are writing here that your changes are used on OpenViX and beyonwiz and thefore nothing can not be changed in openplit git.
Unfortunately I do not see any of your changes in any of the branch not in OpenViX: https://github.com/O...tualKeyBoard.py

not in beyonwiz: https://bitbucket.or...le-view-default
Where your changes in VirtualKeyBoard applied without openpli?

Ian is trying to accommodate PLi first.

 

All the new VKeyboard stuff is currently committed in my OpenViX fork.

 

https://github.com/H...ma2/commits/Dev

[IanSav]

Hi Taapat,

 

1) I forecast the change in Post #583.

 

2) The code has been with OpenViX for a while.  The delay has been in updating skins for OpenViX before the change launches.

 

There is a story behind the Beyonwiz changes that I am unable to elaborate on at this time.  The code is actually developed on the Beyonwiz platform so the changes are fully developed for that platform as well.

 

It makes sense to start with OpenPLi first as it is the upstream source for OpenViX and Beyonwiz.  Implementing on OpenPLi first reduces merge considerations downstream.

 

Regards,

Ian.

[littlesat]

Now it get’s interesting...

[Taapat]

If this changes is only used on openpli, then where is the problem with the normal developing process with offering changes to git instead of changing files in the forum?

[IanSav]

Hi Littlesat,

 

Now it get’s interesting...

 

More than you could ever guess.  Unfortunately I am not permitted to speak publically.

 

Regards,

Ian.

[IanSav]

Hi Taapat,

 

If this changes is only used on openpli, then where is the problem with the normal developing process with offering changes to git instead of changing files in the forum?

 

That is not what Huevos or I said.  OpenViX has exactly the same code as OpenPLi.  The delay has come about because a number of skins are being updated, in the background, before the new code is made public.  I believe that this skin update effort is now almost complete.

 

Regards,

Ian.

[littlesat]

And here they have another design of a keyboard... With wider buttons on the left and a longer spacebar and they are busy with youtube siggestions (which works until youtube brakes it )

https://forums.openp...gin-10/page-125

 

Personally I like the wider spacebar + the wider buttons on the left... 

 

This also means this topic is getting even more interesting... And I'm happy to read that it is pioneered at the 'source' of all the open code....

[Huevos]

If this changes is only used on openpli, then where is the problem with the normal developing process with offering changes to git instead of changing files in the forum?

Because you don't post code to the git until it is ready for beta testing. Ian is sharing his code here so all involved can try changes before they are pushed. That way it doesn't make a big mess of the git history where code/ideas are immediately rejected.