322 replies to this topic

[A.A.]

I am about sending a PR for kodi.

I will add this.

 

Thanks for the test

A.A.

[Pr2]

 

put the patch into /openpli-oe-core/meta-openpli/recipes-mediacenter/kodi/kodi-18 folder
then:

git add <path_to_the_file>

or

git add -A

 

No the solution was to place the file into:  the kodi-18 sub-folder and not at the same level as the kodi-18.inc, so I just place the patch file at the wrong place (git add seems not to be needed, at least for testing build).

[A.A.]

The patch did apply with fuzz.

I have sent PR#988

 

Cheers

A.A.

[WanWizard]

Merged.

[A.A.]

Thanks!

 

Now please try to push Vu+ about pending PR's then merge #989.

Things are finally clean

 

Cheers

A.A.

[WanWizard]

For some reason the current develop has a build error now:

| /openpli/oe/release-8.1/build/tmp/work/vuultimo4k-oe-linux-gnueabi/kodi-addon-pvr-dvblink/4.7.3+gitAUTOINC+add73616c2-r0/pvr.dvblink/src/DVBLinkClient.cpp:28:10: fatal error: libKODI_guilib.h: No such file or directory
|    28 | #include "libKODI_guilib.h"
|       |          ^~~~~~~~~~~~~~~~~~
| compilation terminated.
| CMakeFiles/pvr.dvblink.dir/build.make:88: recipe for target 'CMakeFiles/pvr.dvblink.dir/src/DVBLinkClient.cpp.o' failed
| make[2]: *** [CMakeFiles/pvr.dvblink.dir/src/DVBLinkClient.cpp.o] Error 1
| make[2]: *** Waiting for unfinished jobs....
| make[2]: Leaving directory '/openpli/oe/release-8.1/build/tmp/work/vuultimo4k-oe-linux-gnueabi/kodi-addon-pvr-dvblink/4.7.3+gitAUTOINC+add73616c2-r0/build'
| CMakeFiles/Makefile2:105: recipe for target 'CMakeFiles/pvr.dvblink.dir/all' failed
| make[1]: *** [CMakeFiles/pvr.dvblink.dir/all] Error 2
| make[1]: Leaving directory '/openpli/oe/release-8.1/build/tmp/work/vuultimo4k-oe-linux-gnueabi/kodi-addon-pvr-dvblink/4.7.3+gitAUTOINC+add73616c2-r0/build'
| Makefile:151: recipe for target 'all' failed
| make: *** [all] Error 2
| WARNING: exit code 2 from a shell command.
| 

Any idea?

[WanWizard]

Root cause seems to be:

make[2]: *** No rule to make target '/openpli/oe/release-8.1/build/tmp/work/vuultimo4k-oe-linux-gnueabi/kodi-platform/18.9+gitrAUTOINC+809c5e9d71-r0/recipe-sysroot/usr/lib/libtinyxml.so', needed by 'pvr.dvbviewer.so.3.7.13'.  Stop.

 

[A.A.]

Never seen here, kodi depends on libtinyxml.

 

Please check in do_configure, I see:

 

-- Found TinyXML: /tmp/build/tmp/work/vuduo2-oe-linux/kodi/1_18.9+gitrAUTOINC+0655c2c718-r0/recipe-sysroot/usr/lib/libtinyxml.so

 

Edit:

I'll check now the addons

Edited by A.A., 25 May 2021 - 08:23.

[A.A.]

I confess I have never built kodi-addons-meta before.

Maybe it makes sense to build this as well together with the inputstream plugins.

 

I am debugging it.

Cheers

A.A.

[A.A.]

@WanWizard

 

kodi is ok but these kodi-addons do really need more time to understand and clean the hacks.

I am building reverting the p8platform and kodi-platform updates.

 

This should fix it for the moment but is ugly.

[foxbob]

I added to the recipe

SUMMARY = "Kodi Media Center PVR plugins"

PV = "4.7.3+git${SRCPV}"
PKGV = "4.7.3+git${GITPKGV}"

RDEPENDS_${PN} = "libtinyxml2"

KODIADDONPLUGIN = "dvblink"

require kodi-addon-pvr.inc

[A.A.]

@foxbob

thanks, does all build ok now?

I'll have to ask you about the remaining differences with the OE-A kodi-stb patchset.

I have split the imported parts in different patches, now there are still to see the Gstplayer changes, the ffmpeg customization, the new skin, optimizations for arm, the input devices changes (outdated with udev in 18.x ?).

 

@WanWizard

reverting both kodi-platform and p8platform does indeed solve (last resort)

 

I think it is p8platform and I am testing just this revert now.

BTW the recipe is already in OE and has a patch for CMAKE so next I'll test this.

 

Please wait a bit more with the reverts, thx

Cheers

A.A.

 

P.S.

every change does trigger a kodi rebuild, it takes long

Edited by A.A., 25 May 2021 - 12:26.

[A.A.]

@WanWizard

 

it is p8platform

 

 

Now if we use the OE recipe I fear PV regression and chaos.

 

http://cgit.openembe...git.bb?h=master

PV = "2.1.0.1"
SRC_URI = "git://github.com/Pulse-Eight/platform.git \
  file://0001-Make-resulting-cmake-config-relocatable.patch"
SRCREV = "2d90f98620e25f47702c9e848380c0d93f29462b"

in CMakeLists.txt

set(p8-platform_VERSION_MINOR 1)

set(p8-platform_VERSION_PATCH 0)

set(p8-platform_VERSION_MAJOR 2)

 

Now about the version we use, master,

see   https://github.com/P.../CMakeLists.txt

set(p8-platform_VERSION_MINOR 1)

 set(p8-platform_VERSION_PATCH 1)

set(p8-platform_VERSION_MAJOR 2)

 

# real version is 2.1.1

# we keep this to avoid PE

PV = "2.2.0+gitr${SRCPV}"

 

What would you do? Just fix the version and add PE?

 

Sorry for the mess

A.A.

 

[WanWizard]

I don't have the knowledge to give advice.

 

But something needs to happen, as it is now blocking the release of 8.1, which really needs to happen this week, as our buildfarm goes offline on Saturday due to maintenance.

[A.A.]

I don't know how you would fix the feeds (manually ?) but what if we just remove the p8platform_git.bb?

I have rebuilt now with the meta-oe one and build seems good, if you agree I send PR.

 

 

A.A.

 

If needed  we can just create a .bbappend and increase PV (bogus but would work).

Maybe even go to master if we have the .bbappend.

Edited by A.A., 25 May 2021 - 13:59.

[WanWizard]

If it fixes it, yes please.

[A.A.]

I am sending the revert, it will take too long atherwise.

[A.A.]

somehow if fails on second rebuild, even after revert.

 

but after doing -c cleansstate kodi-platform and p8platform it did succeed

 

Definitely something wrong in these recipes, just looking at CMake warnings of addon-pvr-dvblink:

 

CMake Warning:
  Manually-specified variables were not used by the project:

    ADDONS_TO_BUILD
    ADDON_SRC_PREFIX
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DATAROOTDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_LOCALSTATEDIR
    CMAKE_INSTALL_SBINDIR
    CMAKE_INSTALL_SHAREDSTATEDIR
    CMAKE_INSTALL_SYSCONFDIR
    JSONCPP_INCLUDE_DIRS
    PARANOIA
    VMTRACE
    XLOCALE_NOT_USED

 

I'll spend some hours on it now :/

 

A.A.

Edited by A.A., 25 May 2021 - 17:48.

[WanWizard]

It might need a clean, if the version goes backwards.

[A.A.]

BTW I have added PE = "1" to both because kodi_18 already has it.