125 replies to this topic

[athoik]

The only change in the dtsdownmix is the friendly name Downmixed DTS.

 

It doen't affect other components, only DTS and only when you have downmix enabled.

 

Look how it was looking before with some media files:

 hd_thx_monster_and_thx_lossless.jpg   41.01KB   64 downloads

[littlesat]

It does have an impact... Only the text downmixed by itself does use a big amounr of space... And that is not practicle... (There are more then one skins)...

[athoik]

It does have an impact... Only the text downmixed by itself does use a big amounr of space... And that is not practicle... (There are more then one skins)...

 

But problem already existed, nobody complain till today.

 

Other components return MPEG-4 AAC audio (16 characters) , MPEG 1 Audio, Layer X (21 characters), audio/x-private1-lpcm (21 characters) and so on...

[littlesat]

I agree that sometimes the box was too short... But sorry i do not like to add unrequired text... Later we should also ads left right and stereo to it.... (Lol)...
Now the list gives you simply the available streams and not what you do with it...

From a user interface perspective it is not smart to give a functionality in two differrent places on one screen...

I suggest it is even better to reduce the longer names.... So that it will fit as is.

Edited by littlesat, 14 July 2013 - 11:20.

[pieterg]

Yes, this is a good solution.
And indeed, you don't have to bump PR for AUTOREV packages.

[athoik]

I suggest it is even better to reduce the longer names.... So that it will fit as is.

 

So we need to remove comments from getTrackInfo and put audio description according to the stream type (as it was before).

 

And indeed, you don't have to bump PR for AUTOREV packages.

 

Ok, Good to know that, thanks.

Edited by athoik, 14 July 2013 - 11:33.

[littlesat]

I would wait for Pieterg's suggestions before furhter actions. At least the skin is already committed...

 

But at least if we change it we should do the same for AC3 Downmix... and not only for DTS.

Edited by littlesat, 14 July 2013 - 12:09.

[athoik]

I would wait for Pieterg's suggestions before furhter actions. At least the skin is already committed...

 

But at least if we change it we should do the same for AC3 Downmix... and not only for DTS.

 

Thanks for pushing the skin part.

 

Now regarding the AC3 Downmix i think it is done by the hardware, so we do not have a sink to change the coded description (like we do with dtsdowmix).

[pieterg]

pushed

[athoik]

pushed

 

Thanks.

 

Regarding @littlesat suggestion getting codec descriptions shortened whats your opinion and how it should be implemented?

Edited by athoik, 14 July 2013 - 13:04.

[littlesat]

possibly via a human python converter...?

[Persian Prince]

you should remove 0003-Fix-ac3-audio-playback-if-aac-track-is-present.patch from http://sourceforge.n...diasink_0.10.bb

 

because of https://schwerkraft....75aab15ece7cefc

 

otherwise tonight there will be no images for dreambox e2 models

 

[athoik]

you should remove 0003-Fix-ac3-audio-playback-if-aac-track-is-present.patch from http://sourceforge.n...diasink_0.10.bb

 

because of https://schwerkraft....75aab15ece7cefc

 

otherwise tonight there will be no images for dreambox e2 models

 

 

Thanks! http://openpli.org/f...-11#entry361191

Edited by athoik, 15 July 2013 - 16:52.

[kowal176]

works on dm800se 

[athoik]

Hello,

 

Andreas Monzner from DMM commit a change on dvbmediasink (about an hour ago) in order to add support for ac3plus (they listening...).

 

This commit makes DTS downmix patch to fail. So i rewrote it again (but haven't tested yet). I also simplify the check of ac3plus, using cheap access call, since they only look if file /proc/stb/audio/ac3plus exists.

 

Please review the changes and apply or next build will fail.

 0001-Handle-DTS-Passthrough-and-Downmix.patch.txt   2.2KB   32 downloads

Edited by athoik, 27 September 2013 - 21:01.

[gjstroom]

New build do fail now on the 0001-Handle-DTS-Passthrough-and-Downmix.patch

[gjstroom]

The patch supplied by athoik looks fine, the build is ok again !

[Persian Prince]

dreambox kernel update : http://git.opendream...dc5983b5f35a6e1

 

dreambox new drivers : http://git.opendream...b8c249830ab674e

 

you must use these new things

[athoik]

Patch against Openpli Oe Core. Applies both on master and upstream.

 0001-Handle-DTS-Passthrough-and-Downmix.patch.txt   4.53KB   9 downloads

[athoik]

Hello,

Using my previous patch we were getting the following error

(gst-launch-0.10:811): GStreamer-CRITICAL **: gst_caps_remove_structure: assertion `IS_WRITABLE (caps)' failed
(gst-launch-0.10:811): GStreamer-CRITICAL **: gst_caps_remove_structure: assertion `IS_WRITABLE (caps)' failed

Because we forget to make caps writable.

 

> -             caps = gst_static_caps_get(&hwtemplate->static_caps);

> +             caps = gst_caps_copy(&hwtemplate->static_caps.caps);

 

This patch fixes that.

 0001-Add-a-proper-fix-for-DTS-Passthrough.patch.txt   3.17KB   40 downloads