125 replies to this topic

[goodsat]

Hello I'm looking compiled OpenPLi-gst-plugin-dvbmediasink to run the AC3 +
if user gstdvbaudiosink.c patched and compiled ipk

and also an explanatory compilation

 

gstdvbaudiosink.c:

 

#define AC3CAPS \
        "audio/x-ac3, " \
        "framed =(boolean) true; " \

+      "audio/x-eac3, " \

+      "framed = (boolean) true; " \

        "audio/x-private1-ac3, " \
        "framed =(boolean) true; "

 

-       else if (!strcmp(type, "audio/x-ac3"))

+      else if (!strcmp(type, "audio/x-ac3") || !strcmp(type, "audio/x-eac3"))

 

 

thanx for patch and compil ipk for dm800se

Edited by goodsat, 13 July 2013 - 10:13.

[athoik]

Hello I'm looking compiled OpenPLi-gst-plugin-dvbmediasink to run the AC3 +
if user gstdvbaudiosink.c patched and compiled ipk

and also an explanatory compilation

 

gstdvbaudiosink.c:

 

#define AC3CAPS \
        "audio/x-ac3, " \
        "framed =(boolean) true; " \

+      "audio/x-eac3, " \

+      "framed = (boolean) true; " \

        "audio/x-private1-ac3, " \
        "framed =(boolean) true; "

 

-       else if (!strcmp(type, "audio/x-ac3"))

+      else if (!strcmp(type, "audio/x-ac3") || !strcmp(type, "audio/x-eac3"))

 

 

thanx for patch and compil ipk for dm800se

 

Do you have a sample with AC3+?

 

I am not so sure that AC3+ is backward compatible with AC3. Probably AC3+ must downmixed (like we do with the DTS).

[goodsat]

hi athoik i am send link (my private ftp ) ts files private message  and ( audio/x-ac3 = dolby digital ) (audio/x-eac3 = dolby digital plus or E-AC3)

 

patch based :

http://dev.duckbox.i...61ce35954152e16

 

Audio #1
ID                                       : 2002 (0x7D2)
Menu ID                                  : 3000 (0xBB8)
Format                                   : E-AC-3
Format/Info                              : Audio Coding 3
Format settings, Endianness              : Big
Codec ID                                 : 6
Duration                                 : 42s 80ms
Bit rate mode                            : Constant
Bit rate                                 : 128 Kbps
Channel(s)                               : 2 channels
Channel positions                        : Front: L R
Sampling rate                            : 48.0 KHz
Compression mode                         : Lossy
Delay relative to video                  : -792ms
Stream size                              : 658 KiB (1%)
Language                                 : French

[pieterg]

hi athoik i am send link (my private ftp ) ts files private message  and ( audio/x-ac3 = dolby digital ) (audio/x-eac3 = dolby digital plus or E-AC3)

ts files will not be played back using the dvbaudiosink, so AC3+ in ts files should already work (if your stb supports the codec).

patch based :
http://dev.duckbox.i...61ce35954152e16

That won't work, you need to select a different codec for AC3+.
If you have a sample media file (no ts), I can try to make it work.

[athoik]

ts files will not be played back using the dvbaudiosink, so AC3+ in ts files should already work (if your stb supports the codec).That won't work, you need to select a different codec for AC3+.
If you have a sample media file (no ts), I can try to make it work.

 

Changing .ts extension to .mkv will force to use the dvbaudiosink.

[pieterg]

yes, or using gst-launch would do the same.

But my point is, if the ts does not work, it cannot be fixed with a gstreamer patch.
It probably means the box does not support AC3+.

[athoik]

In that case something like 'Downmixed DTS' might be more informative

 

gst_tag_list_add on dtsdownmix is not working... (https://github.com/a...b60a30088a0bfb2)

 

Probably the codec name description  is handled from the demuxer (eg matroskademux).

 

We can handle this inside getTrackInfo:

 

Also the gstCheckAudioPad is returning atUnknown for audio/x-private1-lpcm? We need to add atLPCM on enum and handle it?

 

 

...
        else if ( gst_structure_has_name (structure, "audio/x-raw-int") )
                return atPCM;
        else if ( gst_structure_has_name (structure, "audio/x-private1-lpcm") )
                return atLPCM;
....

[goodsat]

hi xtreand , vu+ etc... use internal driver for decoding AC3 ans AC3+ , dreambox not decoding AC3 and ac3+   gstreamer patch for use ac3 and not patch for use ac3+

 

please patch for support ac3+ in dreambox

 

 

gstdvbaudiosink.c:

 

#define AC3CAPS \
        "audio/x-ac3, " \
        "framed =(boolean) true; " \

+      "audio/x-eac3, " \

+      "framed = (boolean) true; " \

        "audio/x-private1-ac3, " \
        "framed =(boolean) true; "

 

-       else if (!strcmp(type, "audio/x-ac3"))

+      else if (!strcmp(type, "audio/x-ac3") || !strcmp(type, "audio/x-eac3"))

 

else if (!strcmp(type, "audio/x-ac3")) if ac3 detected decoding (gst get audio format) not detected ac3+ = not suport

else if (!strcmp(type, "audio/x-ac3") || !strcmp(type, "audio/x-eac3")) =   if ac3 or ac3+ detected decoding (gst get audio format)

[athoik]

please patch for support ac3+ in dreambox

 

DDM must release new drivers with AC3+ support.

 

...

as soon as dolby finally issues the ac3+ license to dream multimedia, broadcom will supply us with that microcode so that dreamboxes can play those streams

...

 

http://www.dream-mul...ad&postID=79753

http://www.dream-mul...&threadID=11341

http://www.dream-mul...ad&postID=90863

 

Possible Solutions (live channels):

 

1. Get an STB that supports AC3+

2. IF passthrough is working, hear sound from TV/Amplifier capable receiving AC3+

 

Possible Solutions (media):

 

1. There are some libraries out there that support AC3+ (eac3to, libav, aften). But i think its really hard to create eac3downmix GStreamer sink can downmix to lpcm or to AC3.

2. Convert AC3+ to AC3/MP3/AAC and remux container.

 

 

Conclusion: Probably forget AC3+ on dreambox for live channels. 

 

PS. It's really sad that DDM not releasing new drivers with AC+ all those years, probably this is happening because of small adaption of Dolby Digital Plus.

Edited by athoik, 13 July 2013 - 17:03.

[athoik]

We can handle this inside getTrackInfo:

 

Dear @pieterg

 

I created a patch here changing getTrackInfo. The informative message "Downmixed DTS" is displayed almost correctly now.

 

 downmixed_dts.jpg   43.21KB   55 downloads

 

Probably we need to reduce the space between the number and codec informaton (_ is space), is there any skinner watching?

1____Downmixed [ English
1_Downmixed DTS  English

 

Do you think patch is ok?

 

Do you want me to submit the patch using Sourceforge Merge or attach the patch here?

 

PS. Skin is the OpenPLi default one.

Edited by athoik, 13 July 2013 - 19:25.

[pieterg]

no, not all lpcm is downmixed dts (in fact, most of the time it will just be lpcm)

[pieterg]

hi xtreand , vu+ etc... use internal driver for decoding AC3 ans AC3+ , dreambox not decoding AC3 and ac3+   gstreamer patch for use ac3 and not patch for use ac3+
 
please patch for support ac3+ in dreambox

no, again, gstreamer is not used to playback ts.
So even if the patch were correct (which it isn't for the various reasons I've given above and in PM), it would not help you to playback ts files.

[athoik]

no, not all lpcm is downmixed dts (in fact, most of the time it will just be lpcm)

 

You are right, there is a better way, using gst_tag_list_add.

 

Spoiler

diff --git a/gstdtsdownmix.c b/gstdtsdownmix.c
index 5fb83bd..8af2963 100644
--- a/gstdtsdownmix.c
+++ b/gstdtsdownmix.c
@@ -194,6 +194,9 @@ static void gst_dtsdownmix_update_streaminfo(GstDtsDownmix *dts)
        gst_tag_list_add(taglist, GST_TAG_MERGE_APPEND,
                        GST_TAG_BITRATE, (guint) dts->bit_rate, NULL);
 
+       gst_tag_list_add(taglist, GST_TAG_MERGE_APPEND,
+                       GST_TAG_AUDIO_CODEC, "Downmixed DTS", NULL);
+
        gst_element_found_tags_for_pad(GST_ELEMENT(dts), dts->srcpad, taglist);
 }

 

Now "Downmixed DTS" information will shown only if dtsdownmix is plugged.

 

Do you think now its ok?

[athoik]

Here are the patches also:

 

1. Update OpenPLi dvbmediank

 

 0001-Set-Codec-Information-to-Downmixed-DTS.patch.txt   855bytes   30 downloads

 

2. Update Dreambox dtsdownmix (same patch applies, i just need to push it)

 

https://github.com/a...evelop?expand=1

 

3. Bump PR to dvbmediasink and dtsdownmix

 

 0001-dtsdownmix-bump-PR.patch.txt   1.35KB   13 downloads

 

 

Regarding the skin issue i must create another post under Skins?

[betacentauri]

You don't need to bump PR on normal dvbmediasink. You only need it, if you are changing the bb file or if another package has changed and this is used but not included in the dependencies.
@pieterg: Correct me please when I'm wrong.

[littlesat]

Why do you need that downmixed dts in the audio selection?

[athoik]

Why do you need that downmixed dts in the audio selection?

 

It;s more user friendly, and you know that the audio you are listening is downmixed.

 

If you switch to passthrough the (DTS audio) will have the original name returned by the demuxer (eg matroskademux returns DTS audio).

[littlesat]

But you can do the switch with the red button???

[betacentauri]

There's no change in functionality. You only see a user friendly track info ("Downmixed DTS" instead of "audio/x-private1-lpcm").

 

And for the other skin issue athoik has openend another thread: http://openpli.org/f...audioselection/

Edited by betacentauri, 14 July 2013 - 09:47.

[littlesat]

But why?... And is it then also added for ac3?... You see downmix on on or off... I suggest this should be enough