2520 replies to this topic

[Erik Slagter]

 

Looks like there is another issue:

 

gst-1.4.4 on et4000: When I try to play xvid/divx4,5 packed unpacked from http(s) source, there is either no picture or only some frames will show up. When I play these exact same files from local source there are no issues

gst-0.10 on et4000: remote/local source - no issues

 

Test files are in post #289:

gst-launch-1.0 playbin uri='https://dl.dropboxusercontent.com/u/38760017/xvid_packed_AS.avi'
...

Interesting, this is principally impossible. Packing of mpeg4 only occurs in avi and avi can't be streamed over http...

[betacentauri]

I have a strange problem. After installing merlin music player mp3 playback don't work any longer. I mean playback out of normal play list and not with merlin music player. With merlin music player playback works. After deinstalling the plugin it works again.

[Erik Slagter]

Yes, we have heard this complain more often. It seems like merlin player overwrites some system python file.

[pieterg]

it probably introduces a replacement for servicemp3, which claims all media playback

[blzr]

sort of, it seems...
some custom library is provided with this plugin for playing mp3's, but only /?/ for boxes without hardware mp3 decoding (i.e. dm 7025)
and why it affects embedded openpli player, no idea... /?!/

http://sourceforge.n...r/src/plugin.py

# merlin mp3 player
import merlinmp3player
ENIGMA_MERLINPLAYER_ID = 0x1014

if not config.plugins.merlinmusicplayer.hardwaredecoder.value and self.currentFilename.lower().endswith(".mp3") and self.songList[self.currentIndex][0].PTS is None:
                         sref = eServiceReference(ENIGMA_MERLINPLAYER_ID, 0, self.currentFilename) # play mp3 file with merlinmp3player lib
                         self.session.nav.playService(sref)

if HardwareInfo().get_device_name() != "dm7025":
                         self.list.append(getConfigListEntry(_("Use hardware-decoder for MP3"), config.plugins.merlinmusicplayer.hardwaredecoder))

config.plugins.merlinmusicplayer.hardwaredecoder = ConfigYesNo(default = True)

[mx3L]

 

 

Looks like there is another issue:

 

gst-1.4.4 on et4000: When I try to play xvid/divx4,5 packed unpacked from http(s) source, there is either no picture or only some frames will show up. When I play these exact same files from local source there are no issues

gst-0.10 on et4000: remote/local source - no issues

 

Test files are in post #289:

gst-launch-1.0 playbin uri='https://dl.dropboxusercontent.com/u/38760017/xvid_packed_AS.avi'
...

Interesting, this is principally impossible. Packing of mpeg4 only occurs in avi and avi can't be streamed over http...

 

 

Problem is in avidemux which doesn't set PTS on keyframes when sink pads are operating in PUSH mode(when streaming). This patch shows how was added PTS/DTS handling to avidemux http://cgit.freedesk...20e33c972f94a76. When operating in PUSH mode gst_avi_demux_stream_data is used meaning only DTS is set. So this looks like a gstreamer issue.

 

For now to fix this we could check in dvbvideosink if buffer's flag is keyframe in case PTS is not available and we are dealing with mpeg4 part2 while DTS is available. If that's the case then we use DTS:

diff --git a/gstdvbvideosink.c b/gstdvbvideosink.c
index 8ce68cd..d623f40 100755
--- a/gstdvbvideosink.c
+++ b/gstdvbvideosink.c
@@ -850,7 +850,7 @@ static GstFlowReturn gst_dvbvideosink_render(GstBaseSink *sink, GstBuffer *buffe
 #if GST_VERSION_MAJOR < 1
        if (GST_BUFFER_TIMESTAMP(buffer) != GST_CLOCK_TIME_NONE)
 #else
-       if (GST_BUFFER_PTS_IS_VALID(buffer) || (self->codec_type == CT_DIVX311 && GST_BUFFER_DTS_IS_VALID(buffer)))
+       if (GST_BUFFER_PTS_IS_VALID(buffer) || ((self->codec_type == CT_DIVX311 || (self->codec_type == CT_MPEG4_PART2 && !GST_BUFFER_FLAG_IS_SET(buffer, GST_BUFFER_FLAG_DELTA_UNIT))) && GST_BUFFER_DTS_IS_VALID(buffer)))
 #endif
        {
                pes_header[7] = 0x80; /* pts */

Attached Files

•  0001-dvbvideosink-use-DTS-on-keyframes-for-mpeg4-part2-wh.patch   1.63KB   5 downloads

[Erik Slagter]

Ehhmmmm, did I mention before that avi doesn't have a concept of DTS? I am seeing "significant" problems ahead... Either the avi demuxer will have to split the "packed" frames and calculate (!) the proper DTS, or "we" (enigma2) will have to do it.

[mx3L]

I'm seeing opposite in http://cgit.freedesk...20e33c972f94a76

 

 

avidemux: avi only knows about DTS

Only set DTS on outgoing buffers unless we have a keyframe and then we can set the PTS to DTS as well.

Edited by mx3L, 28 November 2014 - 19:06.

[Erik Slagter]

That is weird because DTS is a concept you only encounter on B frames... On other frames DTS = PTS.

[mx3L]

updated patch (pts_written flag was not set):

diff --git a/gstdvbvideosink.c b/gstdvbvideosink.c
index 8ce68cd..ccc4497 100755
--- a/gstdvbvideosink.c
+++ b/gstdvbvideosink.c
@@ -850,7 +850,7 @@ static GstFlowReturn gst_dvbvideosink_render(GstBaseSink *sink, GstBuffer *buffe
 #if GST_VERSION_MAJOR < 1
        if (GST_BUFFER_TIMESTAMP(buffer) != GST_CLOCK_TIME_NONE)
 #else
-       if (GST_BUFFER_PTS_IS_VALID(buffer) || (self->codec_type == CT_DIVX311 && GST_BUFFER_DTS_IS_VALID(buffer)))
+       if (GST_BUFFER_PTS_IS_VALID(buffer) || ((self->codec_type == CT_DIVX311 || (self->codec_type == CT_MPEG4_PART2 && !GST_BUFFER_FLAG_IS_SET(buffer, GST_BUFFER_FLAG_DELTA_UNIT))) && GST_BUFFER_DTS_IS_VALID(buffer)))
 #endif
        {
                pes_header[7] = 0x80; /* pts */
@@ -1233,7 +1233,7 @@ static GstFlowReturn gst_dvbvideosink_render(GstBaseSink *sink, GstBuffer *buffe
 #if GST_VERSION_MAJOR < 1
        if (GST_BUFFER_TIMESTAMP(buffer) != GST_CLOCK_TIME_NONE)
 #else
-       if (GST_BUFFER_PTS_IS_VALID(buffer) || (self->codec_type == CT_DIVX311 && GST_BUFFER_DTS_IS_VALID(buffer)))
+       if (GST_BUFFER_PTS_IS_VALID(buffer) || ((self->codec_type == CT_DIVX311 || (self->codec_type == CT_MPEG4_PART2 && !GST_BUFFER_FLAG_IS_SET(buffer, GST_BUFFER_FLAG_DELTA_UNIT))) && GST_BUFFER_DTS_IS_VALID(buffer)))
 #endif
        {
                self->pts_written = TRUE;

Every test file in post #289 now works also directly from HTTPS source.

Attached Files

•  0001-dvbvideosink-use-DTS-on-keyframes-for-mpeg4-part2-wh_2.patch   2.19KB   4 downloads

[Fischreiher]

Betacentauri and Captain have now build the first openATV images using GStreamer 1.4.4. Thanks for all your great work enabling this!

 

I think so far you have been focused on (and successful with) packed/unpacked divx/xvid avi's and streaming. With mkv files the situation is unfortunately still quite similar to the gst 0.1 version:

 

https://www.dropbox.......2024fps).mkv
https://www.dropbox.......2025fps).mkv

 

- fast rewinding not possible (stops like paused)

- slow motion backwards not possible (remains paused)

- fast forward 2x and 4x OK, but 8x is using coarse jumps

 

Do you think you could have a look at mkv playback as well?

Edited by Fischreiher, 30 November 2014 - 14:25.

[littlesat]

So these MKVs do made the same issue with 0.1?

Possibly the MKVs itself are wrong?

 

I think we're almost there with gstreamer >1.0.... What do the devs of this project think about it?

[Fischreiher]

Yes, it was quite the same with gst 0.1, but it is a general problem with all mkv files i have, not only these 2 files.

 

I have posted the links to these examples (made by me) as they show on-screen time codes combined with soft scrolling text, making it very easy to verify the correct behaviour of the player. Pure playback is perfectly smooth (on the box, not when using the Dropbox preview feature).

Edited by Fischreiher, 30 November 2014 - 16:24.

[littlesat]

We do usually not recommend fast rewinding as this is made very tricky in enigma2...

use stepskip instead... This is even more easy to find the point you need... does stepskip work for these MKVs?

[Fischreiher]

Yes, stepskip is working fine, I use it most of the time, but for some contents (re)winding would be much better.

 

It's a pity that any 30£ media player is so much better at trick modes ((re)winding, slow motion, frame by frame stepping) than enigma2.

 

Can you explain the difficulty with that?

[littlesat]

I suggest it can better be considered to 'rewrite' this tricky trickmode code a bit in E2....

But note it might be difficult with gestreamer and the hardware buffer in between.....

Edited by littlesat, 30 November 2014 - 17:21.

[Erik Slagter]

It can very well be a driver issue instead.

[Fischreiher]

I don't think it is driver related. The situation is the same on boxes from different vendors.

 

Still it could be an openATV specific issue. Is rewinding mkv files possible with openPLI images?

[theparasol]

Is rewinding mkv files possible with openPLI images?

 

I would say: The proof is in tasting the pudding!

[Erik Slagter]

The proof of the pudding is in the eating.