2520 replies to this topic

[Fischreiher]

I found the pudding tasty in general, though not the trick mode part: I could not rewind mkv files. In some avi files rewinding seemed to be emulated by jumps.

 

Of course stepskip is an alternative, but I was hoping that the new GStreamer was making a good implementaion of (re)winding and slow motion modes easier. Maybe I still don't understand the challege. Could someone brief me?

[pieterg]

gstreamer expects to have full control over decode and play timelines.

This works great with software decoders, and software playback.

 

However, with a combined hardware decoder and playback hardware like we're using, with a big hardware buffer, gstreamer cannot keep track of time, nor control the decoder and playback timestamps and speed.

 

0.1-->1.x is not going to change that.

 

I believe I made a similar post about this before, possibly even in this thread.

[mx3L]

 

So it looks like there is some problem when queue2 and mpeg4videoparse are in pipeline.

I think you should report this to core GStreamer developers! You might hit just another issue

 

reported but no response yet - https://bugzilla.gno...g.cgi?id=740961

[athoik]

Here are the latest missing patches from master branch of dvbmediasink for gst-1.0 branch.

Attached Files

•  0001-configure-Add-missing-m4-macro-dir.patch   584bytes   10 downloads
•  0002-Make-stream-type-a-member-variable-and-use-an-enum-t.patch   8.12KB   7 downloads
•  0003-Convert-audio-bypass-constants-magic-numbers-to-an-A.patch   7.05KB   8 downloads
•  0004-Print-caps-to-aid-in-troubleshooting.patch   756bytes   7 downloads
•  0005-Ensure-that-stream-type-is-initialised-correctly.patch   751bytes   9 downloads
•  0006-Ensure-that-codec_type-is-set-correctly-in-all-cases.patch   2.62KB   10 downloads

Edited by athoik, 4 December 2014 - 20:31.

[Erik Slagter]

Did I miss all of these?

[littlesat]

Possibly it is also close time to 'master' it.... What do 'we' think?

[MastaG]

Congratulations on porting Gstreamer 1.x to everyone involved.

It's awesome to see HLS is supported now!

[Erik Slagter]

@athoik, these are the Peter Urbanec patches ported to gstreamer-1, nice work

 

Applied of course.

Edited by Erik Slagter, 5 December 2014 - 20:29.

[DoeEensGek]

Just a little thumbs up form my side! Nice work .

[peteru]

@athoik - thanks for porting those to gstreamer-1. I've been flat out with a lot of other stuff and still don't have a gstreamer 1.x system setup. :-( That's why I haven't done it myself.

[athoik]

Here are two more missing patches from master branch of dvbmediasink for gst-1.0 branch.

 

I think there is also a missing patch from @betacentauri for flac audio.

 

Attached Files

•  0001-configure.ac-Compatibility-with-newer-autotools-add-.patch   796bytes   6 downloads
•  0002-Fixup-for-previous-commit.patch   543bytes   10 downloads

[Erik Slagter]

Hmmm I just had a look at the commits logs and it seems up I screwed up mildly. I will aplpy these patches and then can you check if everything is in like it should?

[mx3L]

Another issue

I'm experiencing frame drops in some xvid files, it doesn't matter if it's packed or unpacked.
It works correctly without mpeg4videoparse and STREAMTYPE_XVID set (as in gstreamer 0.10).

 

xvid_as packed - https://dl.dropboxus...packed_AS_4.avi
xvid_as unpacked (unpacked with avidemux) - https://dl.dropboxus...packed_AS_4.avi

[mx3L]

I think it's still relevant to remind you, that there exist another solution to fix playback of xvid/divx456 which we declined because it's not following mpeg4 part2 standard.  posts #298,#300,#301 are explaining this.

 

1. solution(current):

1. demux

2. parse

3. decode - set STREAMTYPE_MPEG4_Part2, use PTS on keyframes.

 

issues:

demux - when avidemux is in use and is operating in push mode(http/s streams) it doens't set PTS on keyframes - workaround in our sink(not merged yet), gstreamer devs notified

parse - mpeg4videoparse has issues with correctly unpacking packed mpeg4part2 stream, it leaves N frames - workaround in our sink, gstreamer devs notified

decode - some xvid files as in previous post don't play correctlly even when they're already unpacked, this looks like that this could be issue in decoder which cannot handle some xvid "specials" when STREAMTYPE_MPEG4_Part2 is set? - not fixed yet

 

2. solution (similar to gst0.10):

1. demux

2. decode - set STREAMTYPE_(XVID,DIVX5) for xvid/divx5, set STREAMTYPE_MPEG4_Part2 for divx4, use DTS for xvid/divx5, use PTS on keyframes for divx4

 

issues:

demux - when avidemux is in use and is operating in push mode(http/s streams) it doens't set PTS on keyframes - workaround in our sink(not merged yet), gstreamer devs notified

demux - when avidemux or matroskademux is in use it doesn't set mimetype for xvid - patched in gstreamer base plugin, gstreamer devs notified but rejected

decode - no issues yet, it works exactly as in gstreamer 0.10, (excluding divx4)

 

Best solution would be the first one(current) as we already agreed, but it still has some flaws(not resolved xvid frame drops). Second solution is well tested since we feed decoder with same input as in gstreamer 0.10.

Maybe create new branch also for this solution? Anyway if somebody want's to try, here it is.

 

 

Attached Files

•  0001-riff-media-added-fourcc-to-all-mpeg4-video-caps.patch   979bytes   11 downloads
•  gst10_as_gst010_base.patch   6.3KB   10 downloads
•  gst10_as_gst010_divx4_fix.patch   1.25KB   13 downloads

[littlesat]

I suggest we should choose at this time for the best of the worst.... And then I prefer that it is working... So when I have to make a choice I would in this case choose for option 2....

 

Then in a later state we could go for making thinks perfect.

I would like to see Gstreamer >1.0 as master when we can say it performs at least the same for the most as 0.1...

But this is my meaning.... 

WIthout 'pushing' it will be a somehow never ending story.... As it is somehow now...

[Erik Slagter]

Everything as long as it does not break anything else! Notably play back of any mpeg4 codec material contained in a proper container like mp4 or mkv or mpegts, which don't need the silly workarounds!

[mx3L]

Every test file which I posted here works with second solution.

 

Little more about patches:

0001-riff-media-added-fourcc-to-all-mpeg4-video-caps.patch - this has to be applied on gstreamer1.0-plugins-base, it adds "fourcc" field to mpeg4 caps with fourcc value as string not like previous one which used gint32 value

gst10_as_gst010_base.patch - this has to be applied on currently latest commit in gst-1.0 branch of gst-plugin-dvbmediasink, dvbvideosink treats every mpeg4 part2 video as it was treated in 0.10

gst10_as_gst010_divx4_fix.patch - this has to be applied on top of previous patch, divx4 simple profile didn't work with STREAMTYPE_DIVX4, but works with STREAMTYPE_MPEG4_Part2

 

gst10_as_gst010_base.patch, gst10_as_gst010_divx4_fix.patch - these patches are just for demonstration, base patch should be divided to more patches since it reverts some already commited patches

[littlesat]

Erik... please commit these...

And in addition we should discuss how to make this "master"

[Erik Slagter]

Erik... please commit these...

Only if my condition is met, I have no conclusive answer. Test with mpeg4 using b frames in mkv and mp4. I can't accept a workaround for a broken system if it breaks a correct system.

[mx3L]

 

tested on xtrend et4000, xvid and divx5 has b-frames

test files: https://dl.dropboxus...com/u/38760017/ + Filename