154 replies to this topic

[scriptmelvin †]

Github seems to compare it with the default branch, in which case the observation is correct: python3 is many commits again of master.

 

But when creating a PR, it should create it against the upstream python3 branch (which you forked), not the master branch.

That is what I would expect. I guess I'll switch to cmdline git on a local clone...

[Huevos]

And it doesn't compare against the default branch. It compares your feature branch against the branch you are sending a pull request to.

Edited by Huevos, 26 September 2022 - 15:10.

[mrvica]

By the way, have a look at this commit. Works really well.

https://github.com/o...9fd1f5781db39d0

I adapted OE-A IMDb for OpenPLi, it is really faster with json, you can launch it from Plugins, in eventview (long press Info/EPG) and in movielist (hihlight file in movie selection and press menu)

[mrvica]

starsbars were not displayed well in fhd skins, corrected

 

[scriptmelvin †]

Thanks @adoxa (author), @Huevos and @mrvica. I tested a bit and it works great. It is faster, has more features, and avoids the error-proneness of regex scraping.

 

One thing I don't like is the exit confirmation dialog, so I removed it on my box. Maybe it should be a yes/no/yes-and-don't-ask-again dialog.

 

Maybe OpenPLi should adopt this version?

[Huevos]

"In eventview (long press Info/EPG) and in movielist (hihlight file in movie selection and press menu)"

 

Is this a new change? If so where in the code?

[mrvica]

not in the code, it is in PLi hotkey by default, Info/EPG long -> show eventinfo plugins

[scriptmelvin †]

Maybe OpenPLi should adopt this version?

No opinions on this?

[Huevos]

 

Maybe OpenPLi should adopt this version?

No opinions on this?

 

Well, of course they should, but if no one pushes it to the repo it will never get out testing by the masses and the work will just get forgotten.

[WanWizard]

No opinions on this?

 

Been not very well lately. Let me know if I need to do something.

[Huevos]

Not much point. Yet again more changes.

[40H3X]

Crash log on 8.3, apart from the log every search gives a "No IMDb match"

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
  File "/usr/lib/enigma2/python/Screens/PluginBrowser.py", line 145, in save
  File "/usr/lib/enigma2/python/Screens/PluginBrowser.py", line 149, in run
  File "/usr/lib/enigma2/python/Plugins/Extensions/IMDb/plugin.py", line 1147, in main
  File "/usr/lib/enigma2/python/StartEnigma.py", line 312, in open
    dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/StartEnigma.py", line 255, in instantiateDialog
    return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
  File "/usr/lib/enigma2/python/StartEnigma.py", line 272, in doInstantiateDialog
    dlg = screen(self, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/Plugins/Extensions/IMDb/plugin.py", line 278, in __init__
  File "/usr/lib/enigma2/python/Plugins/Extensions/IMDb/plugin.py", line 655, in getIMDB
AttributeError: 'NoneType' object has no attribute 'toString'
[ePyObject] (CallObject(<bound method ActionMap.action of <Components.ActionMap.ActionMap instance at 0xb21d1f08>>,('WizardActions', 'ok')) failed)

[Dimitrij]

https://github.com/O.../plugin.py#L655

need this

			else:
				self.eventName = self.session.nav.getCurrentlyPlayingServiceReference() and self.session.nav.getCurrentlyPlayingServiceReference().toString() or ""
                                if self.eventName:
				    self.eventName = self.eventName.split('/')
				    self.eventName = self.eventName[-1]
				    self.eventName = self.eventName.replace('.', ' ')
				    self.eventName = self.eventName.split('-')
				    self.eventName = self.eventName[0]
				    if self.eventName.endswith(' '):
					self.eventName = self.eventName[:-1]

Edited by Dimitrij, 13 October 2022 - 10:52.

[scriptmelvin †]

every search gives a "No IMDb match"

It is being worked on. See here.

[40H3X]

 

every search gives a "No IMDb match"

It is being worked on. See here.

 

 

[Dimitrij]

[IMDB] fix not play service

[mrvica]

thanks @adoxa, IMDb now working again, please delete attachments #83, #84, in order to avoid any misunderstanding I adapted this OE-Alliance version for PLi

enigma2-plugins/imdb at master · oe-alliance/enigma2-plugins · GitHub

 

Attached Files

•  IMDb.zip   45.66KB   8 downloads

[40H3X]

Removed.

[relaxibus]

Hi, tested on OpenVix 5.4 but it shows "No Results Found". How could I help you to fix this?

 

Thanks,

-Relaxi

[Huevos]

Hi, tested on OpenVix 5.4 but it shows "No Results Found". How could I help you to fix this?

 

Thanks,

-Relaxi

Why are you asking an OpenViX question on the PLi forum? You should ask on OpenViX forum. Version 5.4 is years old. There have been changes to IMDB sources so you need an up to date image. 6.2 series is the most recent.