2041 replies to this topic

[WanWizard]

Also a good description.... Especially because it is short it might even be better. But there is one remark... when the tuner does not allow show SNR in dB -and/or- the code cannot recalculate it in SNR (this is also happening, long live enigma2)... then it is always anywhere in percentage. I would prefer to hide this option in those cases, but it is tuner driven and not box driven...

That is my point from the beginning: this setting was never designed as a toggle, and never implemented as a toggle. Up to today, de setting name and description indicate a switch from dB to Percentage.

[WanWizard]

Really % should be the default because that works on all boxes.

 

But it isn't, and it hasn't been for 20+ years, since the inception of Enigma2. As it is impossible to retrospectively change all skins, it is better to change the one skin that exposes this problem, which is E2-DarkOS.

 

Since it already has an OpenPLi specific skin section, perhaps swap it only for us, so you can continue to do what you want, while we keep dB's as default.

[Huevos]

 

How did you get that? What is the root image?

 

There is no root image, it is an SF8008.
 

My guess is OpenVIX has issues detecting the define image, which isn't (really) a traditional Enigma2 image.

 

slot 3 is the slot I flashed online with the latest OpenVIX yesterday:

 

I can't reproduce that.

 

SF8008 Supreme.

 

In ViX, boot to PLi, no crash.

Attached Files

•  1.jpg   87.24KB   2 downloads

[WanWizard]

I've booted OpenVIX again. I have 6.6.003 installed.

 

I don't even get to this screen, it crashes while enumerating the slots... The Image Manager crashes on the same thing, with the same error.

 

And now the (wifi) network refuses to start, no matter what I do, and I see no option in the image to view logs or dmesg output. Had to disable the interface, reboot, and reconfigure it, to get it back working.

 

I did some debugging for you, it crashes on

                              print("[multiboot] [GetImagelist] using BoxInfo")
                              x = open(f"{imagedir}/etc/issue").readlines()
                              print ("Reading /etc/issue on %s" % slot )
                              print (x)
                              Creator = x[-2].capitalize().strip()[:-6]

the error is that -2 is out of range (I split the Creator line and added the two print statements):

<   669.991440> 14:04:01.6689 [multiboot] [GetImagelist] using BoxInfo
<   669.992070> 14:04:01.6695 Reading /etc/issue on 2
<   669.992148> 14:04:01.6696 ['define 6.4 \\n \\l']
<   669.992360> 14:04:01.6698 Traceback (most recent call last):
<   669.992416> 14:04:01.6698   File "/usr/lib/enigma2/python/Screens/MultiBootSelector.py", line 62, in getImagelist
<   669.993049> 14:04:01.6705     self.imagedict = GetImagelist(Recovery=SystemInfo["RecoveryMode"])
<   669.993640> 14:04:01.6711                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
<   669.993709> 14:04:01.6711   File "/usr/lib/enigma2/python/Tools/Multiboot.py", line 163, in GetImagelist
<   669.994421> 14:04:01.6718     Creator = x[-2].capitalize().strip()[:-6]
<   669.994771> 14:04:01.6722               ~^^^^
<   669.994882> 14:04:01.6723 IndexError: list index out of range

which is because there aren't that many lines in /etc/issue.

 

I have fixed this in OpenPLi a few weeks ago: https://github.com/O...6cceccfa8dc93c5
 

After this fix:

 1_0_19_22C5_80D_2_11A0000_0_0_0_20240719141140.jpg   255.29KB   2 downloads

Edited by WanWizard, 19 July 2024 - 14:12.

[DimitarCC]

Really % should be the default because that works on all boxes.

But it isn't, and it hasn't been for 20+ years, since the inception of Enigma2. As it is impossible to retrospectively change all skins, it is better to change the one skin that exposes this problem, which is E2-DarkOS.

Since it already has an OpenPLi specific skin section, perhaps swap it only for us, so you can continue to do what you want, while we keep dB's as default.

Or maybe equaluze SNRdB and SNR args and use the option to just switch from dB to %
But @Huevos is right the default should be the % since is supported by all boxes.
Maybe set default of that option to On. In that way users that already choose different will preserve their choice....
The only screen than normally requires both is Satfinder.... On other places display both has no meaning... To be honest i dont see meaning to be displayed both in satfinder too...

Edited by DimitarCC, 19 July 2024 - 14:02.

[Huevos]

I don't even get to this screen, it crashes while enumerating the slots...

Can you do a test please?

 

1. Boot into vix.
2. Set up debug logs on a device USB/HDD not flash. It is in Menu > Setup > System > Logs > Settings
3. Send attached file to the box. Goes in /usr/lib/enigma2/python/Tools
4. Restart enigma.
5. Provoke the crash.
6. Retrieve the log.

 

Should show whatever that image is outputting.

Attached Files

•  Multiboot.py   13.12KB   2 downloads

[WanWizard]

See https://forums.openp...99#entry1632793

[Huevos]

 

Also a good description.... Especially because it is short it might even be better. But there is one remark... when the tuner does not allow show SNR in dB -and/or- the code cannot recalculate it in SNR (this is also happening, long live enigma2)... then it is always anywhere in percentage. I would prefer to hide this option in those cases, but it is tuner driven and not box driven...

 

The only gripe I still have with it all, is that the config value has no clear and defined state, but depends on the whim of the skin designer.

 

As an example: if you run OpenPLi 9, with the default FullNight-HD skin, and setting to No, you will see dB's in the skin. Now you upgrade to OpenPLi 10, with DarkOS as default skin, you restore your config, and the dB's are gone, you now have SNR %.

 

This is going to cause a lot of forum complaints from end-users...

 

It would have been a lot better to simply have a config value "Show SNR as" with options "Db / % ", which makes it clear and unambiguous what the user wants to see, irrespectively of the skin.
 

 

Wouldn't the logical thing be:

config.usage.swap_snr_on_osd = ConfigSelection(default="0", choices=[("0", _("Skin Setting")), ("1", _("dB")), ("2", _("percentage"))

Edited by Huevos, 19 July 2024 - 18:40.

[WanWizard]

I can live with that. With a default of 1

[littlesat]

Can’t work as that way you need two of them…. These choices do not ‘swap’

Edited by littlesat, 19 July 2024 - 21:55.

[Huevos]

Can’t work as that way you need two of them…. These choices do not ‘swap’

No, it doesn't swap, it gives the user the option to decide their own preference or that of the skin. With that choice why would they need to swap?

[littlesat]

That does not work as the skin have two tastes dB and %… which you can swap and that config only defines one taste. So when you prefer the other on the other location you only have one. So when you define dB or so you never get % anymore. Swap=swap

[Huevos]

Swap is just the logic. The point is to achieve what the user wants, which is why the "swap" logic was a bad idea in the first place. But I guess you could add a 4th option to swap.

Edited by Huevos, 20 July 2024 - 09:01.

[WanWizard]

I think what Littlesat means is that you can have skins with both SNR% and dB (perhaps on different screens), and the current setting swaps those.

 

With your proposal, it would show either what the skin designer intended, or SNR% or dB's everywhere (losing either one or the other). In that scenario, swap is still a required option.

[Huevos]

I think what Littlesat means is that you can have skins with both SNR% and dB (perhaps on different screens), and the current setting swaps those.

 

With your proposal, it would show either what the skin designer intended, or SNR% or dB's everywhere (losing either one or the other). In that scenario, swap is still a required option.

Yes, and some screens have both in the same screen, e.g. Satfinder.

 

You could have all 4 options, e.g...

config.usage.swap_snr_on_osd = ConfigSelection(default="0", choices=[("0", _("Skin Setting")), ("1", _("dB")), ("2", _("percentage"), ("3", _("swap"))

I am just trying to give options to cover all bases.
 

Edited by Huevos, 20 July 2024 - 15:47.

[El_pelosss]

hello. I am interested in this skin. I have openpli 8..3. Where can I get it?

[Huevos]

hello. I am interested in this skin. I have openpli 8..3. Where can I get it?

Only currently for PLi Develop. Previous versions (e.g. 8.3) do not have embedded code required by this skin.

Edited by Huevos, 20 July 2024 - 16:06.

[littlesat]

Even your latest suggestion does not fit…. I would leave it as is, change the comments what wanwizard suggested and swap both at the e2os skin.
The skin needs special code that is only in the image at develop and 9.1 when it is released

Edited by littlesat, 20 July 2024 - 17:49.

[WanWizard]

 and swap both at the e2os skin.

 

That can only work if it can be done for OpenPLi only, as we're clearly the only ones having an issue with all this.

[Huevos]

Even your latest suggestion does not fit…. I would leave it as is, change the comments what wanwizard suggested and swap both at the e2os skin.
The skin needs special code that is only in the image at develop and 9.1 when it is released

Well then you need to see if Dimitar is willing to update that argument in the skin.