2520 replies to this topic

[christophecvr]

I think it's better to make an option like "use-gstreamer-1", that way you never have to compare by number. It's also easier for the user, as gstreamer options will go up at some time. The user then doesn't have to decide whether to use "1.0" "1.4" or "1.9" etc.

Perhaps but if it's done like I proposed to theparasol

 

User can set just --with-gstversion=1  or --with-gstversion="1.4" or --with-gstversion="1.0"

 

It al compiled with gst-1.0  That's the same as use-gstreamer=1.

[christophecvr]

@theparasol curious that this doe not work

 

if test "$GST_MAJOR" -lt  "1"; then

 

perhaps it must be in configure.ac 

 

if test "$GST_MAJOR" <  "1"; then

 

or

 

if test "x$GST_MAJOR" <  "x1"; then

Edited by christophecvr, 10 February 2015 - 16:22.

[christophecvr]

@ theparasol If You do it like this

diff --git a/meta-openpli/recipes-openpli/enigma2-plugins/gst10-fix-enigma2-plugins.patch b/meta-openpli/recipes-openpli/enigma2-plugins/gst10-fix-enigma2-plugins.patch
new file mode 100755
index 0000000..28d4010
--- /dev/null
+++ b/meta-openpli/recipes-openpli/enigma2-plugins/gst10-fix-enigma2-plugins.patch
@@ -0,0 +1,31 @@
+diff --git a/configure.ac b/configure.ac
+index 82785ec..419333a 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -2,6 +2,11 @@ AC_INIT([enigma2-plugins],[3.2.0],[enigma2-devel@lists.elitedvb.net])
+ AM_INIT_AUTOMAKE([dist-bzip2 foreign no-define tar-pax])
+ AC_CONFIG_HEADERS([enigma2-plugins-config.h])
+  
++#dnl versions of gstreamer and plugins-base
++AC_ARG_WITH(gstversion,
++    AS_HELP_STRING([--with-gstversion-1],[enable gstversion 1.0]),
++    [with-gstversion-1=$withval],[with-gstversion-1="no"])
++
+ # Silent rules are available since 1.11, but older versions
+ # are still in use. So don't use them unconditionally.
+ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
+@@ -23,7 +28,12 @@ AX_PTHREAD
+ TUXBOX_APPS_DVB
+  
+ PKG_CHECK_MODULES(ENIGMA2, enigma2)
+-PKG_CHECK_MODULES(GSTREAMER, gstreamer-0.10 gstreamer-pbutils-0.10)
++if test "$with-gstversion-1" = "no"; then
++    PKG_CHECK_MODULES(GSTREAMER, gstreamer-0.10 gstreamer-pbutils-0.10)
++else
++    PKG_CHECK_MODULES(GSTREAMER, gstreamer-1.0 gstreamer-pbutils-1.0)
++fi
++
+ PKG_CHECK_MODULES(LIBCRYPTO, libcrypto)
+  
+ AC_ARG_WITH(tpm,
+

[christophecvr]

and then you just have to specify --with-gstversion-1   instead of --with-gstversion=1.0

[christophecvr]

there is  one extra change

 

++AC_ARG_WITH(gstversion,

 

should be then

 

++AC_ARG_WITH(gstversion-1,

[theparasol]

Sorry cant test any longer since sourceforge is down at the moment...

[christophecvr]

Sorry cant test any longer since sourceforge is down at the moment...

no problem was wrong anyway . this should do

--- /dev/null
+++ b/meta-openpli/recipes-openpli/enigma2-plugins/gst10-fix-enigma2-plugins.patch
@@ -0,0 +1,31 @@
+diff --git a/configure.ac b/configure.ac
+index 82785ec..419333a 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -2,6 +2,11 @@ AC_INIT([enigma2-plugins],[3.2.0],[enigma2-devel@lists.elitedvb.net])
+ AM_INIT_AUTOMAKE([dist-bzip2 foreign no-define tar-pax])
+ AC_CONFIG_HEADERS([enigma2-plugins-config.h])
+ 
++#dnl versions of gstreamer and plugins-base
++AC_ARG_WITH(gstversion1,
++    AS_HELP_STRING([--with-gstversion1],[enable gstversion1]),
++    [with_gstversion1=$withval],[with_gstversion1="no"])
++
+ # Silent rules are available since 1.11, but older versions
+ # are still in use. So don't use them unconditionally.
+ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
+@@ -23,7 +28,12 @@ AX_PTHREAD
+ TUXBOX_APPS_DVB
+ 
+ PKG_CHECK_MODULES(ENIGMA2, enigma2)
+-PKG_CHECK_MODULES(GSTREAMER, gstreamer-0.10 gstreamer-pbutils-0.10)
++if test "with_gstversion1" = "no"; then
++    PKG_CHECK_MODULES(GSTREAMER, gstreamer-0.10 gstreamer-pbutils-0.10)
++else
++    PKG_CHECK_MODULES(GSTREAMER, gstreamer-1.0 gstreamer-pbutils-1.0)
++fi
++
+ PKG_CHECK_MODULES(LIBCRYPTO, libcrypto)
+ 
+ AC_ARG_WITH(tpm,
+ 

and use by configure --with-gstversion1 

 

But a do not know if somewhere else the --with-gstversion="1.0"   was required.

 

if this is the case use --with-gstversion="1.0"  and --with-gstversion1    later perhaps can be traced to also change the other places .

[peteru]

Speaking of SourceForge being down...

sf.net has been very unreliable as of late. Is it perhaps time to switch everything over to git hosting somewhere reliable and fast like GitHub or BitBucket?

[christophecvr]

but actually We could just do the test like this

--- /dev/null
+++ b/meta-openpli/recipes-openpli/enigma2-plugins/gst10-fix-enigma2-plugins.patch
@@ -0,0 +1,31 @@
+diff --git a/configure.ac b/configure.ac
+index 82785ec..419333a 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -2,6 +2,11 @@ AC_INIT([enigma2-plugins],[3.2.0],[enigma2-devel@lists.elitedvb.net])
+ AM_INIT_AUTOMAKE([dist-bzip2 foreign no-define tar-pax])
+ AC_CONFIG_HEADERS([enigma2-plugins-config.h])
+ 
++#dnl versions of gstreamer and plugins-base
++AC_ARG_WITH(gstversion,
++    AS_HELP_STRING([--with-gstversion],[use gstreamer version (major.minor)]),
++    [GST_MAJORMINOR=$withval],[GST_MAJORMINOR=0.10])
++
+ # Silent rules are available since 1.11, but older versions
+ # are still in use. So don't use them unconditionally.
+ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
+@@ -23,7 +28,12 @@ AX_PTHREAD
+ TUXBOX_APPS_DVB
+ 
+ PKG_CHECK_MODULES(ENIGMA2, enigma2)
+-PKG_CHECK_MODULES(GSTREAMER, gstreamer-0.10 gstreamer-pbutils-0.10)
++PKG_CHECK_MODULES(GSTREAMER, gstreamer-$GST_MAJORMINOR gstreamer-pbutils-$GST_MAJORMINOR)
+ PKG_CHECK_MODULES(LIBCRYPTO, libcrypto)
+ 
+ AC_ARG_WITH(tpm,
+ 

Gues patch will have to be remade.

[MastaG]

So has anyone looked at replacing the sink for Dreambox and VU receivers yet?

I have the buildsystem ready to go

[christophecvr]

So has anyone looked at replacing the sink for Dreambox and VU receivers yet?

I have the buildsystem ready to go

For the vu the sink is given by vu self. By vu we have the need of some depends which requires gst-0.1.

[christophecvr]

@Erik Slaghter

 

I know will start with a try on vuduo2,  . I will patch the vuplus repo's for that to use gst 1 dvb mediasink and at firts remove blocking packages like gst-ffmpeg  and the packages who depends on it. Neverthless software codecs will be required by vuduo2 but then it will be libav instead of gst-ffmpeg.

 

I saw that patch with the test xxxxx  and x1 still in. Indeed it can't work. (I took it over from existing patch but actually did not test) it just works now cause test gives error and then the else is followed I guess.

 

but what should be ok is simply (after i have a build I'll try to patch that and rebuild enigma2-plugins)

 

Instead of test just use

 

PKG_CHECK_MODULES(GSTREAMER, gstreamer-$GST_MAJORMINOR gstreamer-pbutils-$GST_MAJORMINOR)

 

if its 0.10 it simply should use gstreamer-0.10

if its 1.0   it simply should use gstreamer-1.0

[christophecvr]

just a small question why not use openembedded-core gstreamer ?

[christophecvr]

@Erik Slaghter

 

It builds for vuduo2 I just saw that already enigma2  conigure.ac was adapted. In the current version there are some double entry's. Here the enigma2 git patch which removes double entry's.

 

Also entry still missing by enigma2-plugins git. Now start working on that.

 

if ok patch will follow

 

 

 

Attached Files

•  0003-gst1-enigma2.patch   1.3KB   12 downloads

[christophecvr]

@ all

 

I just tried build for vuduo2 (complete with feeds)

 

The only change is the vuxx2 chnaged to have gst 1.0 dvbmediasink.

 

Then the patch 003-gst1 added to patch enigma2 git right.

then also I created a patch for plugins-enigma2 this is also applied when building enigma2-plugins.

 

Here the patch wit those build ok checked in work dir and gst1.0 is used for enigma2 and enigma2-plugins.

 

Would be nice if a dev ad this last patch included here to plugins-enigma2.git

 

p.s. the 003-gst1 (correction patch) still not in enigma2 git.

 

 

And now the test by flashing keep my fingres crossed.

Attached Files

•  004-gst1-plugins-enigma2.patch   1.36KB   22 downloads

Edited by christophecvr, 11 February 2015 - 13:36.

[Erik Slagter]

Applied (manually, the patch doesn't apply at all).

[christophecvr]

Applied (manually, the patch doesn't apply at all).

Now I just added the patch by base openpli-oe-core  recipe

 

The 003

 

set the patch in openpli-oe-core/meta-openpli/recipes-openpli/enigma2/enigma2   map

 

and changed the enigma2.bb

ENIGMA2_BRANCH ?= "master"
SRC_URI = "git://git.code.sf.net/p/openpli/enigma2;protocol=git;branch=${ENIGMA2_BRANCH}"
SRC_URI += "${@base_contains('GST_VERSION', '1.0', 'file://disablesubtitleshack.patch', '', d)}"
SRC_URI += "file://0003-gst1-enigma2.patch" # that is added.

 

The 004

 

created directory openpli-oe-core/meta-openpli/recipes-openpli/enigma2-plugins/enigma2-plugins

 

set patch in openpli-oe-core/meta-openpli/recipes-openpli/enigma2-plugins/enigma2-plugins map

and changed enigma2-plugins.bb file

 

to

 

SRCREV = "${AUTOREV}"
SRC_URI="git://git.code.sf.net/p/openpli/plugins-enigma2 \
        file://004-gst1-plugins-enigma2.patch \
"

 

Note the patch 004 is for plugins-enigma2  git not enigma2-plugins git.

 

The flash vuduo2  is ok at first test vuduo2 runs fine. More detailed test with media and so on to go.

[Erik Slagter]

I can hardly make heads or tails of what you write.

[christophecvr]

I can hardly make heads or tails of what you write.

Simple the pacth 003 is for enigma2.git

The patch 004 is for plugins-enigma2 git (not for enigma2-plugins git)

 

Not a problem.  Just tested further. Media does hardly play on vuduo2 Still just like a year ago. vuduo2 not compatible with pli's dvb mediasink(gst1.0) But I once tried a standard build by just using pli dvbmediasink for gst0.1 and whitout gst1.0 and that even did never worked just same as gst1.0 media does not play. that from scherwcraft is needed.

 

I'll reflash with standard pli.

[Erik Slagter]

Everybody happy now?