162 replies to this topic

[christophecvr]

@MiLo

 

I forgot to tell : I gues You well saw it in the patches, but for the patches I deliberately removed all audiocd support based on cdfs. It would be to unreadable sources to keep the cdfs support and also for enigma2 a real mess.

[MiLo]

Getting rid of CDFS is a good thing.

[christophecvr]

@MiLo,

 

Just discovered potential problem about busybox.

 

To let it rebuild

1) first an revision increase is needed.

openpli-oe-core/meta-openpli/recipes-core/busybox/busybox_1.22.1.bbappend

PR = "r33"

SRC_URI_IGNORED = " \

But after this is done another problems shows up.

Configuring busybox-mdev.
 Adding system startup for /etc/init.d/mdev.
Collected errors:
 * resolve_conffiles: Existing conffile /etc/mdev.conf is different from the conffile in the new package. The new conffile will be placed at /etc/mdev.conf-opkg.

Ok i solved it by erasing mdev.conf and renaming mdev.conf-opkg to mdev.conf. This followed by a clean reboot (via remote command restart box) hard reset by power blanks mdev.conf.

 

But I for regular users a box flash advice should be given.

[christophecvr]

note this last error was only on dm8000 on vuduo2 it went ok for update but gues it was cause that on dm8000 was changed manually.

 

Normally if revision is set to 33 it will update flawlessly.

And no flash advice needed

[christophecvr]

I made a patch to increase busybox revision nuimber then it builds and installs if user update his box.

 

 

Attached Files

•  busybox-revision-increase.patch   926bytes   5 downloads

[MiLo]

PR number updates happen automatically. The build server has the "PR Server" enabled.

[christophecvr]

Yes normally well, but in the case off the specific package the update off mdev.conf was (by me then) not detected. And the busybox was not rebuild with new mdev.conf setting.

[christophecvr]

@MiLo

 

I just found out that my code about the new audiocd support could in some cases crash enigma2:

 

If for example cd was inserted , You played it. You stopped. Then the user decided to replay cd (an main menu paly audiocd is made). He pressed menu. And played his cd again. runs all 100 % ok.

 

But then he stopped playning , exit mediaplayer. box will be back in main menu. That's ok and logic. Then (leaving box in main menu ) he removed cd. All works fine. But the menu item play audio cd will remain.

If he would then press ok to play the cd which was in the mean time removed , e2 crashes. Well logic as it will try to open cdlist which was gone cause cd was removed.

 

With this patch this crash can't occur anymore. sorry off my error

 

But once solved no danger more

 

Included patch for enigma2.

 

 

Attached Files

•  Newaudiocdsupport-possible-e2-crash.patch   2.77KB   10 downloads

[christophecvr]

To all apart from the little issue above :  once the patch is pushed all possible unstable issues are removed.

 

This will be for all off pli images and all correct based images . But some starts to really inventing issues becuase they are not using real pli4 images. ,

 

That's a little over it.  I MORE then once asked for HELP on some issues answers where NADA. And now suddenly they now everything ?????

 

read :

 

for Taapat and mx3L ?????? very very questionable remarks they have  .

 

read :

https://github.com/O...dab066b25196c1d

[mx3L]

I'm sorry you take it this way.

I have enigma2 on watchlist and I saw what @Taapat saw, and so I just confirmed that (since from your comments, it looked like you were not sure what was the problem) and proposed the solution, that's all.

 

I think we should be glad and not offended if someone is checking if everything is all right and makes suggestions for improvements.

 

PS. I didn't answer yesterday because your remarks were out of place, glad you delete them!

[christophecvr]

I'm sorry you take it this way.

I have enigma2 on watchlist and I saw what @Taapat saw, and so I just confirmed that (since from your comments, it looked like you were not sure what was the problem) and proposed the solution, that's all.

 

I think we should be glad and not offended if someone is checking if everything is all right and makes suggestions for improvements.

 

PS. I didn't answer yesterday because your remarks were out of place, glad you delete them!

Yes sorry.

 

@MiLo,

 

I just sended a push request with :

 

The possible GSOD error if the user uses a image without the sytems Hotplug.plugin installed. (by the call back they did the same).

Possible gsod error by trying to open cd which has been removed.

 

I also just discovered that the not standard installed plugin DVDplayer (which is well adviced i you like to play physical dvd's) Also had the same problem.

If You launched for example the dvd via mainmenu item DVDplayer, stopped the dvd remained in the menu removed the dvd . Then clicked ok on DVDplayer it tried to open a non existent dvd.

Here the patch for it , If you wish I'll push it then it will join my already push request for the Mediaplayer.

Attached Files

•  e2-DVDplayer-possible-gsod-er.patch   1.48KB   3 downloads

[mx3L]

No problem, keep up the good work.

[christophecvr]

@Beeker,

 

Did You test audiocd's with the current enigma2, hotplug-e2-helper and busybox update ?

 

By me dm8000. (with sata dvd player)

 

I can do 10 cd's in ar row let them complete play. And then sudden sometimes a single cd somewhere just stops playing at song x. whitout any reason at the begin off a track. Just pres stop and ok again cd continues playing.

 

Vuduo2 (usb dvd player)

 

always 100 % ok.

[Beeker]

I will do a new test this weekend with latest enigma2,busybox etc. I will let you know the result of it.

[Beeker]

 

I can do 10 cd's in ar row let them complete play. And then sudden sometimes a single cd somewhere just stops playing at song x. whitout any reason at the begin off a track. Just pres stop and ok again cd continues playing.

 

Vuduo2 (usb dvd player)

 

always 100 % ok.

 

CD nr 6. No problem so far.

 

Continue with testing...

Edited by Beeker, 11 October 2015 - 10:00.

[Beeker]

@christophecvr

 

13 cd's. No stops/interuptions, just playing perfect.

[christophecvr]

@christophecvr

 

13 cd's. No stops/interuptions, just playing perfect.

Yes it can be that it just a scratch on a cd which causes that.

[christophecvr]

I really thank @Beeker ,

 

Looks like he is the only one after me which is really testing all. Like all can see the test are very very good.

 

Whe are only two persons who really test it by 100%

 

The goal is : slam and audio cd in , it will play the audio cd . slam a dvd it will play the dvd.

 

This just all like it was a real cd/dvd player.

[theparasol]

Whe are only two persons who really test it by 100%

 

Congratulations!

 

I would have tested too but my small cheap box isnt equipped with a cd/dvd player (I think most of us dont have a box containing an optical station)

[christophecvr]

Indeed not so many persons do use it.

Because it actually not worked that well.

Not much boxes do have an internal optical cd/dvd.

 

Since actually external usb cd/dvd players are working fine also it's worth to make it.

 

The only improvement concerning audio cd's is to play whitout interuption between track's.

For example a cd like The wall from Pink Floyd (the real original) Is a cd with tracks but supposed to play whitout a interuption between tracks.

Now we send after each track an eos gstreamer stops restarts for next track. On the old gst-0.1 it was the only way.

The new gst-1.0 does permit to set a cd as a single track and if navigation is required it's done by toc info of the cd (made by libcdio) . using seek/flush/newsegment operation.

 

Unfortunatelly this will require a new structure in to the current used code. Think better a new .cpp module audiocd player or if it's not to much code a new function into servicemp3.cpp.

So not ready for tommorow